From 9b86874c2d01fba2e558074726d43ba3d8173fb0 Mon Sep 17 00:00:00 2001
From: Rotzbua <Rotzbua@users.noreply.github.com>
Date: Sat, 25 May 2024 22:55:09 +0200
Subject: [PATCH] chore: migrate deprecated `util.isArray`

Deprecated: Use Array.isArray() instead.

Source: https://nodejs.org/docs/latest-v18.x/api/util.html#utilisarrayobject
---
 .../@node-red/editor-api/lib/auth/permissions.js          | 4 ++--
 .../node_modules/@node-red/editor-api/lib/auth/users.js   | 2 +-
 .../node_modules/@node-red/editor-api/lib/editor/theme.js | 2 +-
 .../@node-red/nodes/core/function/10-function.js          | 8 ++++----
 .../node_modules/@node-red/runtime/lib/api/settings.js    | 2 +-
 packages/node_modules/@node-red/runtime/lib/nodes/Node.js | 4 ++--
 packages/node_modules/@node-red/util/lib/util.js          | 4 ++--
 7 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/packages/node_modules/@node-red/editor-api/lib/auth/permissions.js b/packages/node_modules/@node-red/editor-api/lib/auth/permissions.js
index ba5005ba8..77545a73c 100644
--- a/packages/node_modules/@node-red/editor-api/lib/auth/permissions.js
+++ b/packages/node_modules/@node-red/editor-api/lib/auth/permissions.js
@@ -25,7 +25,7 @@ function hasPermission(userScope,permission) {
     }
     var i;
 
-    if (util.isArray(permission)) {
+    if (Array.isArray(permission)) {
         // Multiple permissions requested - check each one
         for (i=0;i<permission.length;i++) {
             if (!hasPermission(userScope,permission[i])) {
@@ -36,7 +36,7 @@ function hasPermission(userScope,permission) {
         return true;
     }
 
-    if (util.isArray(userScope)) {
+    if (Array.isArray(userScope)) {
         if (userScope.length === 0) {
             return false;
         }
diff --git a/packages/node_modules/@node-red/editor-api/lib/auth/users.js b/packages/node_modules/@node-red/editor-api/lib/auth/users.js
index b5754bee9..a3ffab5a8 100644
--- a/packages/node_modules/@node-red/editor-api/lib/auth/users.js
+++ b/packages/node_modules/@node-red/editor-api/lib/auth/users.js
@@ -74,7 +74,7 @@ function init(config) {
             } else {
                 var us = config.users;
                 /* istanbul ignore else */
-                if (!util.isArray(us)) {
+                if (!Array.isArray(us)) {
                     us = [us];
                 }
                 for (var i=0;i<us.length;i++) {
diff --git a/packages/node_modules/@node-red/editor-api/lib/editor/theme.js b/packages/node_modules/@node-red/editor-api/lib/editor/theme.js
index 64e4f7ec3..2bbcbcd97 100644
--- a/packages/node_modules/@node-red/editor-api/lib/editor/theme.js
+++ b/packages/node_modules/@node-red/editor-api/lib/editor/theme.js
@@ -70,7 +70,7 @@ function serveFilesFromTheme(themeValue, themeApp, directory, baseDirectory) {
     var result = [];
     if (themeValue) {
         var array = themeValue;
-        if (!util.isArray(array)) {
+        if (!Array.isArray(array)) {
             array = [array];
         }
 
diff --git a/packages/node_modules/@node-red/nodes/core/function/10-function.js b/packages/node_modules/@node-red/nodes/core/function/10-function.js
index 6ef890dca..0120d8c92 100644
--- a/packages/node_modules/@node-red/nodes/core/function/10-function.js
+++ b/packages/node_modules/@node-red/nodes/core/function/10-function.js
@@ -25,19 +25,19 @@ module.exports = function(RED) {
     function sendResults(node,send,_msgid,msgs,cloneFirstMessage) {
         if (msgs == null) {
             return;
-        } else if (!util.isArray(msgs)) {
+        } else if (!Array.isArray(msgs)) {
             msgs = [msgs];
         }
         var msgCount = 0;
         for (var m=0; m<msgs.length; m++) {
             if (msgs[m]) {
-                if (!util.isArray(msgs[m])) {
+                if (!Array.isArray(msgs[m])) {
                     msgs[m] = [msgs[m]];
                 }
                 for (var n=0; n < msgs[m].length; n++) {
                     var msg = msgs[m][n];
                     if (msg !== null && msg !== undefined) {
-                        if (typeof msg === 'object' && !Buffer.isBuffer(msg) && !util.isArray(msg)) {
+                        if (typeof msg === 'object' && !Buffer.isBuffer(msg) && !Array.isArray(msg)) {
                             if (msgCount === 0 && cloneFirstMessage !== false) {
                                 msgs[m][n] = RED.util.cloneMessage(msgs[m][n]);
                                 msg = msgs[m][n];
@@ -47,7 +47,7 @@ module.exports = function(RED) {
                         } else {
                             var type = typeof msg;
                             if (type === 'object') {
-                                type = Buffer.isBuffer(msg)?'Buffer':(util.isArray(msg)?'Array':'Date');
+                                type = Buffer.isBuffer(msg)?'Buffer':(Array.isArray(msg)?'Array':'Date');
                             }
                             node.error(RED._("function.error.non-message-returned",{ type: type }));
                         }
diff --git a/packages/node_modules/@node-red/runtime/lib/api/settings.js b/packages/node_modules/@node-red/runtime/lib/api/settings.js
index 13f2cec4e..1aa335f1a 100644
--- a/packages/node_modules/@node-red/runtime/lib/api/settings.js
+++ b/packages/node_modules/@node-red/runtime/lib/api/settings.js
@@ -104,7 +104,7 @@ var api = module.exports = {
                 }
             }
             safeSettings.libraries = runtime.library.getLibraries();
-            if (util.isArray(runtime.settings.paletteCategories)) {
+            if (Array.isArray(runtime.settings.paletteCategories)) {
                 safeSettings.paletteCategories = runtime.settings.paletteCategories;
             }
 
diff --git a/packages/node_modules/@node-red/runtime/lib/nodes/Node.js b/packages/node_modules/@node-red/runtime/lib/nodes/Node.js
index 5a60cf6a0..0b1ed349b 100644
--- a/packages/node_modules/@node-red/runtime/lib/nodes/Node.js
+++ b/packages/node_modules/@node-red/runtime/lib/nodes/Node.js
@@ -377,7 +377,7 @@ Node.prototype.send = function(msg) {
 
     if (msg === null || typeof msg === "undefined") {
         return;
-    } else if (!util.isArray(msg)) {
+    } else if (!Array.isArray(msg)) {
         // A single message has been passed in
         if (typeof msg !== 'object') {
             this.error(Log._("nodes.flow.non-message-returned", { type: typeof msg }));
@@ -425,7 +425,7 @@ Node.prototype.send = function(msg) {
         if (i < msg.length) {
             var msgs = msg[i]; // msgs going to output i
             if (msgs !== null && typeof msgs !== "undefined") {
-                if (!util.isArray(msgs)) {
+                if (!Array.isArray(msgs)) {
                     msgs = [msgs];
                 }
                 var k = 0;
diff --git a/packages/node_modules/@node-red/util/lib/util.js b/packages/node_modules/@node-red/util/lib/util.js
index 06ed366a0..9ebb46bc0 100644
--- a/packages/node_modules/@node-red/util/lib/util.js
+++ b/packages/node_modules/@node-red/util/lib/util.js
@@ -862,7 +862,7 @@ function encodeObject(msg,opts) {
                     message: msg.msg.message
                 });
             } else {
-                var isArray = util.isArray(msg.msg);
+                var isArray = Array.isArray(msg.msg);
                 var needsStringify = isArray;
                 if (isArray) {
                     msg.format = "array["+msg.msg.length+"]";
@@ -906,7 +906,7 @@ function encodeObject(msg,opts) {
                             }
                         } else if (value instanceof Error) {
                             value = value.toString()
-                        } else if (util.isArray(value) && value.length > debuglength) {
+                        } else if (Array.isArray(value) && value.length > debuglength) {
                             value = {
                                 __enc__: true,
                                 type: "array",