Updates to sentiment, exec and range to handle missing payload properties

nodes/core/analysis/72-sentiment.js

@@ -23,10 +23,13 @@ module.exports = function(RED) {
         var node = this;
 
         this.on("input", function(msg) {
+            if (msg.hasOwnProperty("payload")) {
                 sentiment(msg.payload, msg.overrides || null, function (err, result) {
                     msg.sentiment = result;
                     node.send(msg);
                 });
+            }
+            else { node.send(msg); } // If no payload - just pass it on.
         });
     }
     RED.nodes.registerType("sentiment",SentimentNode);

nodes/core/core/75-exec.js

@@ -66,7 +66,7 @@ module.exports = function(RED) {
             }
             else {
                 var cl = node.cmd;
-                if ((node.addpay === true) && (msg.payload.trim() !== "")) { cl += " "+msg.payload; }
+                if ((node.addpay === true) && ((msg.payload || "").trim() !== "")) { cl += " "+msg.payload; }
                 if (node.append.trim() !== "") { cl += " "+node.append; }
                 if (RED.settings.verbose) { node.log(cl); }
                 var child = exec(cl, {encoding: 'binary', maxBuffer:10000000}, function (error, stdout, stderr) {

nodes/core/logic/16-range.js

@@ -27,6 +27,7 @@ module.exports = function(RED) {
         var node = this;
 
         this.on('input', function (msg) {
+            if (msg.hasOwnProperty("payload")) {
                 var n = Number(msg.payload);
                 if (!isNaN(n)) {
                     if (node.action == "clamp") {
@@ -42,6 +43,8 @@ module.exports = function(RED) {
                     node.send(msg);
                 }
                 else { node.log("Not a number: "+msg.payload); }
+            }
+            else { node.send(msg); } // If no payload - just pass it on.
         });
     }
     RED.nodes.registerType("range", RangeNode);

test/nodes/core/analysis/72-sentiment_spec.js

@@ -37,6 +37,22 @@ describe('sentiment Node', function() {
         });
     });
 
+    it('should pass on msg if no payload', function(done) {
+        var flow = [{id:"jn1",type:"sentiment",wires:[["jn2"]]},
+                    {id:"jn2", type:"helper"}];
+        helper.load(sentimentNode, flow, function() {
+            var jn1 = helper.getNode("jn1");
+            var jn2 = helper.getNode("jn2");
+            jn2.on("input", function(msg) {
+                msg.should.not.have.property('sentiment');
+                msg.topic.should.equal("pass on");
+                done();
+            });
+            var testString = 'good, great, best, brilliant';
+            jn1.receive({topic:"pass on"});
+        });
+    });
+
     it('should add a positive score for good words', function(done) {
         var flow = [{id:"jn1",type:"sentiment",wires:[["jn2"]]},
                     {id:"jn2", type:"helper"}];

test/nodes/core/logic/16-range_spec.js

@@ -106,6 +106,25 @@ describe('range Node', function() {
         genericRangeTest("clamp", 0, 10, 0, 1000, false, -1, 0, done);
     });
 
+    it('just passes on msg if payload not present', function(done) {
+        var flow = [{"id":"rangeNode1","type":"range","minin":0,"maxin":100,"minout":0,"maxout":100,"action":"scale","round":true,"name":"rangeNode","wires":[["helperNode1"]]},
+                    {id:"helperNode1", type:"helper", wires:[]}];
+        helper.load(rangeNode, flow, function() {
+            var rangeNode1 = helper.getNode("rangeNode1");
+            var helperNode1 = helper.getNode("helperNode1");
+            helperNode1.on("input", function(msg) {
+                try {
+                    msg.should.not.have.property('payload');
+                    msg.topic.should.equal("pass on");
+                    done();
+                } catch(err) {
+                    done(err);
+                }
+            });
+            rangeNode1.receive({topic:"pass on"});
+        });
+    });
+
     it('reports if input is not a number', function(done) {
         var flow = [{"id":"rangeNode1","type":"range","minin":0,"maxin":0,"minout":0,"maxout":0,"action":"scale","round":true,"name":"rangeNode","wires":[["helperNode1"]]},
                     {id:"helperNode1", type:"helper", wires:[]}];