From 14ac6446de3742184ba97b1b2c2113264fb24a6d Mon Sep 17 00:00:00 2001 From: Tyler Eastman Date: Mon, 22 Jul 2019 14:25:52 -0700 Subject: [PATCH 01/14] Handle undefined node._def in edit stack title. --- .../node_modules/@node-red/editor-client/src/js/ui/editor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/editor.js b/packages/node_modules/@node-red/editor-client/src/js/ui/editor.js index 1f4cf0ae9..e8c4b9b63 100644 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/editor.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/editor.js @@ -517,7 +517,7 @@ RED.editor = (function() { } else if (node.type.indexOf("subflow:")===0) { var subflow = RED.nodes.subflow(node.type.substring(8)); label = RED._("subflow.editSubflowInstance",{name:RED.utils.sanitize(subflow.name)}) - } else { + } else if (node._def !== undefined) { if (typeof node._def.paletteLabel !== "undefined") { try { label = RED.utils.sanitize((typeof node._def.paletteLabel === "function" ? node._def.paletteLabel.call(node._def) : node._def.paletteLabel)||""); From 2f5ec8b5bf4a0b1af7d2c806c09a66e1adbb9148 Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Fri, 26 Jul 2019 17:51:49 +0900 Subject: [PATCH 02/14] Fix inserting new subflow node to existing wire between nodes --- .../@node-red/editor-client/src/js/ui/palette.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js b/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js index 28d5af46e..c50af60d0 100755 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js @@ -243,7 +243,6 @@ RED.palette = (function() { RED.sidebar.info.set(helpText,RED._("sidebar.info.nodeHelp")); }); var chart = $("#chart"); - var chartOffset = chart.offset(); var chartSVG = $("#chart>svg").get(0); var activeSpliceLink; var mouseX; @@ -267,8 +266,8 @@ RED.palette = (function() { ui.originalPosition.left = $('#' + e.target.id).offset().left; if (def.inputs > 0 && def.outputs > 0) { - mouseX = ui.position.left-paletteWidth+(ui.helper.width()/2) - chartOffset.left + chart.scrollLeft(); - mouseY = ui.position.top-paletteTop+(ui.helper.height()/2) - chartOffset.top + chart.scrollTop(); + mouseX = ui.position.left - paletteWidth + (ui.helper.width()/2) + chart.scrollLeft(); + mouseY = ui.position.top - paletteTop + (ui.helper.height()/2) + chart.scrollTop(); if (!spliceTimer) { spliceTimer = setTimeout(function() { var nodes = []; From 5ab90b85dae8bfba8e9b2eedd7fd20cc3134faf7 Mon Sep 17 00:00:00 2001 From: Ben Hardill Date: Thu, 25 Jul 2019 17:18:59 +0100 Subject: [PATCH 03/14] Limit the regex for the /nodes/ api end points fixes #2240 It looks like the regex for the /nodes/... endpoints over matches. I've added `^` to the start to anchor the matches to the start of the URL. --- .../@node-red/editor-api/lib/admin/index.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/node_modules/@node-red/editor-api/lib/admin/index.js b/packages/node_modules/@node-red/editor-api/lib/admin/index.js index 32bf010c5..50d7b168f 100644 --- a/packages/node_modules/@node-red/editor-api/lib/admin/index.js +++ b/packages/node_modules/@node-red/editor-api/lib/admin/index.js @@ -48,13 +48,13 @@ module.exports = { // Nodes adminApp.get("/nodes",needsPermission("nodes.read"),nodes.getAll,apiUtil.errorHandler); adminApp.post("/nodes",needsPermission("nodes.write"),nodes.post,apiUtil.errorHandler); - adminApp.get(/\/nodes\/messages/,needsPermission("nodes.read"),nodes.getModuleCatalogs,apiUtil.errorHandler); - adminApp.get(/\/nodes\/((@[^\/]+\/)?[^\/]+\/[^\/]+)\/messages/,needsPermission("nodes.read"),nodes.getModuleCatalog,apiUtil.errorHandler); - adminApp.get(/\/nodes\/((@[^\/]+\/)?[^\/]+)$/,needsPermission("nodes.read"),nodes.getModule,apiUtil.errorHandler); - adminApp.put(/\/nodes\/((@[^\/]+\/)?[^\/]+)$/,needsPermission("nodes.write"),nodes.putModule,apiUtil.errorHandler); - adminApp.delete(/\/nodes\/((@[^\/]+\/)?[^\/]+)$/,needsPermission("nodes.write"),nodes.delete,apiUtil.errorHandler); - adminApp.get(/\/nodes\/((@[^\/]+\/)?[^\/]+)\/([^\/]+)$/,needsPermission("nodes.read"),nodes.getSet,apiUtil.errorHandler); - adminApp.put(/\/nodes\/((@[^\/]+\/)?[^\/]+)\/([^\/]+)$/,needsPermission("nodes.write"),nodes.putSet,apiUtil.errorHandler); + adminApp.get(/^\/nodes\/messages/,needsPermission("nodes.read"),nodes.getModuleCatalogs,apiUtil.errorHandler); + adminApp.get(/^\/nodes\/((@[^\/]+\/)?[^\/]+\/[^\/]+)\/messages/,needsPermission("nodes.read"),nodes.getModuleCatalog,apiUtil.errorHandler); + adminApp.get(/^\/nodes\/((@[^\/]+\/)?[^\/]+)$/,needsPermission("nodes.read"),nodes.getModule,apiUtil.errorHandler); + adminApp.put(/^\/nodes\/((@[^\/]+\/)?[^\/]+)$/,needsPermission("nodes.write"),nodes.putModule,apiUtil.errorHandler); + adminApp.delete(/^\/nodes\/((@[^\/]+\/)?[^\/]+)$/,needsPermission("nodes.write"),nodes.delete,apiUtil.errorHandler); + adminApp.get(/^\/nodes\/((@[^\/]+\/)?[^\/]+)\/([^\/]+)$/,needsPermission("nodes.read"),nodes.getSet,apiUtil.errorHandler); + adminApp.put(/^\/nodes\/((@[^\/]+\/)?[^\/]+)\/([^\/]+)$/,needsPermission("nodes.write"),nodes.putSet,apiUtil.errorHandler); // Context adminApp.get("/context/:scope(global)",needsPermission("context.read"),context.get,apiUtil.errorHandler); From b9e97792f348b3698c4cb21ecc63b1a2aff50d12 Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Tue, 30 Jul 2019 19:52:28 +0900 Subject: [PATCH 04/14] Fix wrong variable name --- CHANGELOG.md | 2 +- packages/node_modules/node-red/settings.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e6de1ce2..b1bdc154c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -677,7 +677,7 @@ Nodes - Initial support of sequence rules for SWITCH node (#1545) - initial support of SORT node (#1500) - Inject node - let once delay be editable (#1541) - - Introduce `nodeMaxMessageBufferLength` setting for msg sequence nodes + - Introduce `nodeMessageBufferMaxLength` setting for msg sequence nodes - Let CSV correct parts if we remove header row. - let default apply if msg.delay not set in override mode. (#1397) - let trigger node be reset by boolean message (#1554) diff --git a/packages/node_modules/node-red/settings.js b/packages/node_modules/node-red/settings.js index a15e533c5..679d24065 100644 --- a/packages/node_modules/node-red/settings.js +++ b/packages/node_modules/node-red/settings.js @@ -55,7 +55,7 @@ module.exports = { // The maximum number of messages nodes will buffer internally as part of their // operation. This applies across a range of nodes that operate on message sequences. // defaults to no limit. A value of 0 also means no limit is applied. - //nodeMaxMessageBufferLength: 0, + //nodeMessageBufferMaxLength: 0, // To disable the option for using local files for storing keys and certificates in the TLS configuration // node, set this to true From 0ad3eceb82f78596841f1b9f4ffcb5c58c279652 Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Wed, 31 Jul 2019 16:06:30 +0900 Subject: [PATCH 05/14] Remove unused variables --- packages/node_modules/@node-red/nodes/core/logic/10-switch.html | 1 - packages/node_modules/@node-red/nodes/core/logic/15-change.html | 1 - 2 files changed, 2 deletions(-) diff --git a/packages/node_modules/@node-red/nodes/core/logic/10-switch.html b/packages/node_modules/@node-red/nodes/core/logic/10-switch.html index 65e83ca09..3cd3fb032 100644 --- a/packages/node_modules/@node-red/nodes/core/logic/10-switch.html +++ b/packages/node_modules/@node-red/nodes/core/logic/10-switch.html @@ -352,7 +352,6 @@ }, oneditsave: function() { var rules = $("#node-input-rule-container").editableList('items'); - var ruleset; var node = this; node.rules = []; rules.each(function(i) { diff --git a/packages/node_modules/@node-red/nodes/core/logic/15-change.html b/packages/node_modules/@node-red/nodes/core/logic/15-change.html index d60c8c38e..0731fce75 100644 --- a/packages/node_modules/@node-red/nodes/core/logic/15-change.html +++ b/packages/node_modules/@node-red/nodes/core/logic/15-change.html @@ -226,7 +226,6 @@ }, oneditsave: function() { var rules = $("#node-input-rule-container").editableList('items'); - var ruleset; var node = this; node.rules= []; rules.each(function(i) { From fe18df25ba74ff596f846f80234fbfe7945dea9b Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Thu, 1 Aug 2019 20:50:35 +0900 Subject: [PATCH 06/14] Add Japanese translation to delay node --- .../@node-red/nodes/locales/en-US/core/89-delay.html | 12 ++++++------ .../@node-red/nodes/locales/ja/core/89-delay.html | 2 ++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/node_modules/@node-red/nodes/locales/en-US/core/89-delay.html b/packages/node_modules/@node-red/nodes/locales/en-US/core/89-delay.html index 87deebe2b..d6977a34a 100644 --- a/packages/node_modules/@node-red/nodes/locales/en-US/core/89-delay.html +++ b/packages/node_modules/@node-red/nodes/locales/en-US/core/89-delay.html @@ -22,12 +22,12 @@
Sets the delay, in milliseconds, to be applied to the message. This option only applies if the node is configured to allow the message to override the configured default delay interval.
-
reset
-
If the received message has this property set to any value, all - outstanding messages held by the node are cleared without being sent.
-
flush
-
If the received message has this property set to any value, all - outstanding messages held by the node are sent immediately.
+
reset
+
If the received message has this property set to any value, all + outstanding messages held by the node are cleared without being sent.
+
flush
+
If the received message has this property set to any value, all + outstanding messages held by the node are sent immediately.

Details

When configured to delay messages, the delay interval can be a fixed value, diff --git a/packages/node_modules/@node-red/nodes/locales/ja/core/89-delay.html b/packages/node_modules/@node-red/nodes/locales/ja/core/89-delay.html index 43eda93a7..ed5046f03 100644 --- a/packages/node_modules/@node-red/nodes/locales/ja/core/89-delay.html +++ b/packages/node_modules/@node-red/nodes/locales/ja/core/89-delay.html @@ -22,6 +22,8 @@

メッセージの遅延時間をミリ秒単位で設定します。これはノードの設定でデフォルトの遅延時間を上書きできるようノードを設定した場合にのみ適用します。
reset
受信メッセージでこのプロパティを任意の値に設定すると、ノードが保持する全ての未送信メッセージをクリアします。
+
flush
+
受信メッセージでこのプロパティを任意の値に設定すると、ノードが保持する全ての未送信メッセージを直ちに送信します。

詳細

メッセージを遅延させるように設定する場合、遅延時間は固定値、範囲内の乱数値、メッセージ毎の動的な指定値のいずれかを指定できます。

From 3a6448f727173fed1bc0e4c48e63118d8445ef14 Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Fri, 2 Aug 2019 13:56:37 +0900 Subject: [PATCH 07/14] Fix splitters in split node --- packages/node_modules/@node-red/nodes/core/logic/17-split.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node_modules/@node-red/nodes/core/logic/17-split.js b/packages/node_modules/@node-red/nodes/core/logic/17-split.js index c644b9e36..869fbaa3d 100644 --- a/packages/node_modules/@node-red/nodes/core/logic/17-split.js +++ b/packages/node_modules/@node-red/nodes/core/logic/17-split.js @@ -42,7 +42,7 @@ module.exports = function(RED) { node.addname = n.addname || ""; try { if (node.spltType === "str") { - this.splt = (n.splt || "\\n").replace(/\\n/,"\n").replace(/\\r/,"\r").replace(/\\t/,"\t").replace(/\\e/,"\e").replace(/\\f/,"\f").replace(/\\0/,"\0"); + this.splt = (n.splt || "\\n").replace(/\\n/g,"\n").replace(/\\r/g,"\r").replace(/\\t/g,"\t").replace(/\\e/g,"\e").replace(/\\f/g,"\f").replace(/\\0/g,"\0"); } else if (node.spltType === "bin") { var spltArray = JSON.parse(n.splt); if (Array.isArray(spltArray)) { From 9d66ca4a498a9ef3ccb940ac8c80a66f100f7484 Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Mon, 5 Aug 2019 19:03:30 +0900 Subject: [PATCH 08/14] Fix duplicated tooltip --- .../@node-red/editor-client/src/js/ui/tab-context.js | 2 +- .../@node-red/nodes/core/core/lib/debug/debug-utils.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/tab-context.js b/packages/node_modules/@node-red/editor-client/src/js/ui/tab-context.js index b62ad13c3..916fa711f 100644 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/tab-context.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/tab-context.js @@ -37,7 +37,7 @@ RED.sidebar.context = (function() { // '').appendTo(content); var footerToolbar = $('
'+ - // ' ' + + // ' ' + '
'); diff --git a/packages/node_modules/@node-red/nodes/core/core/lib/debug/debug-utils.js b/packages/node_modules/@node-red/nodes/core/core/lib/debug/debug-utils.js index edc349507..980f18790 100644 --- a/packages/node_modules/@node-red/nodes/core/core/lib/debug/debug-utils.js +++ b/packages/node_modules/@node-red/nodes/core/core/lib/debug/debug-utils.js @@ -42,14 +42,14 @@ RED.debug = (function() { var content = $("
").css({"position":"relative","height":"100%"}); var toolbar = $('
'+ ' '+ - '
').appendTo(content); + '
').appendTo(content); var footerToolbar = $('
'+ // ''+ // 'list'+ // 'table '+ // ''+ - ' ' + + ' ' + '
'); messageList = $('
').appendTo(content); From 15b99c574980357eb3414da6533a7f0cf0ef1295 Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Tue, 6 Aug 2019 19:24:45 +0900 Subject: [PATCH 09/14] Use appropriate the version of Node.js --- packages/node_modules/@node-red/runtime/lib/index.js | 2 +- packages/node_modules/node-red/lib/red.js | 6 +++--- packages/node_modules/node-red/red.js | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/node_modules/@node-red/runtime/lib/index.js b/packages/node_modules/@node-red/runtime/lib/index.js index 58b7df986..66bff6ff2 100644 --- a/packages/node_modules/@node-red/runtime/lib/index.js +++ b/packages/node_modules/@node-red/runtime/lib/index.js @@ -129,7 +129,7 @@ function start() { log.info(log._("runtime.version",{component:"Node.js ",version:process.version})); if (settings.UNSUPPORTED_VERSION) { log.error("*****************************************************************"); - log.error("* "+log._("runtime.unsupported_version",{component:"Node.js",version:process.version,requires: ">=4"})+" *"); + log.error("* "+log._("runtime.unsupported_version",{component:"Node.js",version:process.version,requires: ">=8.9.0"})+" *"); log.error("*****************************************************************"); events.emit("runtime-event",{id:"runtime-unsupported-version",payload:{type:"error",text:"notification.errors.unsupportedVersion"},retain:true}); } diff --git a/packages/node_modules/node-red/lib/red.js b/packages/node_modules/node-red/lib/red.js index 2a04df578..4d7269518 100644 --- a/packages/node_modules/node-red/lib/red.js +++ b/packages/node_modules/node-red/lib/red.js @@ -27,9 +27,9 @@ var apiEnabled = false; function checkVersion(userSettings) { var semver = require('semver'); - if (!semver.satisfies(process.version,">=4.8.0")) { + if (!semver.satisfies(process.version,">=8.9.0")) { // TODO: in the future, make this a hard error. - // var e = new Error("Unsupported version of node.js"); + // var e = new Error("Unsupported version of Node.js"); // e.code = "unsupported_version"; // throw e; userSettings.UNSUPPORTED_VERSION = process.version; @@ -39,7 +39,7 @@ function checkVersion(userSettings) { * This module provides the full Node-RED application, with both the runtime * and editor components built in. * - * The API this module exposes allows it to be embedded within another node.js + * The API this module exposes allows it to be embedded within another Node.js * application. * * @namespace node-red diff --git a/packages/node_modules/node-red/red.js b/packages/node_modules/node-red/red.js index 337eb44e8..040f2db53 100755 --- a/packages/node_modules/node-red/red.js +++ b/packages/node_modules/node-red/red.js @@ -197,8 +197,8 @@ try { RED.init(server,settings); } catch(err) { if (err.code == "unsupported_version") { - console.log("Unsupported version of node.js:",process.version); - console.log("Node-RED requires node.js v4 or later"); + console.log("Unsupported version of Node.js:",process.version); + console.log("Node-RED requires Node.js v8.9.0 or later"); } else if (err.code == "not_built") { console.log("Node-RED has not been built. See README.md for details"); } else { From fe91295704fcc313139256b3b673031d6e9720fa Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Tue, 6 Aug 2019 19:27:46 +0900 Subject: [PATCH 10/14] Replace node.js with Node.js --- .github/ISSUE_TEMPLATE.md | 2 +- .github/ISSUE_TEMPLATE/--bug_report.md | 2 +- CONTRIBUTING.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 5d4d87bb7..07efaf18e 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -28,7 +28,7 @@ To help us understand the issue, please fill-in as much of the following informa ### Please tell us about your environment: - [ ] Node-RED version: -- [ ] node.js version: +- [ ] Node.js version: - [ ] npm version: - [ ] Platform/OS: - [ ] Browser: diff --git a/.github/ISSUE_TEMPLATE/--bug_report.md b/.github/ISSUE_TEMPLATE/--bug_report.md index ff13e2ace..63923455e 100644 --- a/.github/ISSUE_TEMPLATE/--bug_report.md +++ b/.github/ISSUE_TEMPLATE/--bug_report.md @@ -33,7 +33,7 @@ To help us understand the issue, please fill-in as much of the following informa ### Please tell us about your environment: - [ ] Node-RED version: -- [ ] node.js version: +- [ ] Node.js version: - [ ] npm version: - [ ] Platform/OS: - [ ] Browser: diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 33a2f582f..f0f4096c5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -26,7 +26,7 @@ relevant nodes, press Ctrl-E and copy the flow data from the Export dialog. At a minimum, please include: - Version of Node-RED - either release number if you downloaded a zip, or the first few lines of `git log` if you are cloning the repository directly. - - Version of node.js - what does `node -v` say? + - Version of Node.js - what does `node -v` say? ## Feature requests From fde85481666c7da333599d1d07c3b643ce59d536 Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Tue, 6 Aug 2019 19:30:05 +0900 Subject: [PATCH 11/14] Remove handling for unused error code --- packages/node_modules/node-red/red.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/node_modules/node-red/red.js b/packages/node_modules/node-red/red.js index 040f2db53..94cebdfaa 100755 --- a/packages/node_modules/node-red/red.js +++ b/packages/node_modules/node-red/red.js @@ -199,8 +199,6 @@ try { if (err.code == "unsupported_version") { console.log("Unsupported version of Node.js:",process.version); console.log("Node-RED requires Node.js v8.9.0 or later"); - } else if (err.code == "not_built") { - console.log("Node-RED has not been built. See README.md for details"); } else { console.log("Failed to start server:"); if (err.stack) { From 542cf3147dedaabb05a619b862e50066b3655786 Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Tue, 6 Aug 2019 15:12:13 +0100 Subject: [PATCH 12/14] Support displaying falsey node status values Fixes #2246 --- packages/node_modules/@node-red/editor-client/src/js/ui/view.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/view.js b/packages/node_modules/@node-red/editor-client/src/js/ui/view.js index 16883d28a..0db014d46 100755 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/view.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/view.js @@ -3056,7 +3056,7 @@ RED.view = (function() { } thisNode.selectAll(".node_status").style(style); } - if (d.status.text) { + if (d.status.hasOwnProperty('text')) { thisNode.selectAll(".node_status_label").text(d.status.text); } else { thisNode.selectAll(".node_status_label").text(""); From 6c3913785d8fde78037013002ddea4479bfa0dbb Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Tue, 6 Aug 2019 15:21:57 +0100 Subject: [PATCH 13/14] Add error event handler to ssh-keygen child_process Fixes #2255 --- .../lib/storage/localfilesystem/projects/ssh/keygen.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/node_modules/@node-red/runtime/lib/storage/localfilesystem/projects/ssh/keygen.js b/packages/node_modules/@node-red/runtime/lib/storage/localfilesystem/projects/ssh/keygen.js index 218144c12..5555f841b 100644 --- a/packages/node_modules/@node-red/runtime/lib/storage/localfilesystem/projects/ssh/keygen.js +++ b/packages/node_modules/@node-red/runtime/lib/storage/localfilesystem/projects/ssh/keygen.js @@ -51,6 +51,12 @@ function runSshKeygenCommand(args,cwd,env) { resolve(stdout); } }); + child.error('error', function(err) { + if (/ENOENT/.test(err.toString())) { + err.code = "command_not_found"; + } + reject(err); + }); }); } From 9b938f6515e82fcc6a242f2e9967ba148f286814 Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Tue, 6 Aug 2019 15:55:25 +0100 Subject: [PATCH 14/14] Fix default value handling on context array access Fixes #2252 --- .../node_modules/@node-red/runtime/lib/nodes/context/index.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/node_modules/@node-red/runtime/lib/nodes/context/index.js b/packages/node_modules/@node-red/runtime/lib/nodes/context/index.js index f8de26070..322fa2868 100644 --- a/packages/node_modules/@node-red/runtime/lib/nodes/context/index.js +++ b/packages/node_modules/@node-red/runtime/lib/nodes/context/index.js @@ -234,7 +234,7 @@ function createContext(id,seed,parent) { if (err.code === "INVALID_EXPR") { throw err; } - value[0] = undefined; + values[0] = undefined; } } } else { @@ -246,7 +246,7 @@ function createContext(id,seed,parent) { if (err.code === "INVALID_EXPR") { throw err; } - value[i] = undefined; + values[i] = undefined; } } }