From 7b51f30d11e182103a6b4909c7d8d0a9b89c075b Mon Sep 17 00:00:00 2001 From: Dave Conway-Jones Date: Thu, 28 Aug 2025 15:18:02 +0100 Subject: [PATCH] Fix rounding errors for range node when using float inputs and integer outputs And add extra tests --- .../@node-red/nodes/core/function/16-range.js | 4 ++++ test/nodes/core/function/16-range_spec.js | 8 ++++++++ 2 files changed, 12 insertions(+) diff --git a/packages/node_modules/@node-red/nodes/core/function/16-range.js b/packages/node_modules/@node-red/nodes/core/function/16-range.js index 61ffd53fb..3071cd99a 100644 --- a/packages/node_modules/@node-red/nodes/core/function/16-range.js +++ b/packages/node_modules/@node-red/nodes/core/function/16-range.js @@ -24,6 +24,10 @@ module.exports = function(RED) { this.maxin = Number(n.maxin); this.minout = Number(n.minout); this.maxout = Number(n.maxout); + if (this.round) { + this.maxout = Math.floor(this.maxout); + this.minout = Math.ceil(this.minout); + } this.property = n.property||"payload"; var node = this; diff --git a/test/nodes/core/function/16-range_spec.js b/test/nodes/core/function/16-range_spec.js index 620d21b12..5bc8cbc32 100644 --- a/test/nodes/core/function/16-range_spec.js +++ b/test/nodes/core/function/16-range_spec.js @@ -106,6 +106,14 @@ describe('range Node', function() { genericRangeTest("clamp", 0, 10, 0, 1000, false, -1, 0, done); }); + it('clamps numbers within a range - above max fp', function(done) { + genericRangeTest("clamp", 0, 9.5, 0.5, 100.5, true, 13.1, 100, done); + }); + + it('clamps numbers within a range - below min fp', function(done) { + genericRangeTest("clamp", 0, 9.5, 0.3, 100.5, true, -13.1, 1, done); + }); + it('drops msg if in drop mode and input outside range', function(done) { var flow = [{"id":"rangeNode1","type":"range","minin":2,"maxin":8,"minout":20,"maxout":80,"action":"drop","round":true,"name":"rangeNode","wires":[["helperNode1"]]}, {id:"helperNode1", type:"helper", wires:[]}];