From 85fc20b52d483f162038e35e2dd4d366e35be80c Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Fri, 19 Jan 2018 11:42:19 +0000 Subject: [PATCH] Fix unhandled promise warnings in sshkeys/node8 --- test/red/api/editor/sshkeys_spec.js | 34 +++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/test/red/api/editor/sshkeys_spec.js b/test/red/api/editor/sshkeys_spec.js index c6fea9e59..b224277c4 100644 --- a/test/red/api/editor/sshkeys_spec.js +++ b/test/red/api/editor/sshkeys_spec.js @@ -135,9 +135,11 @@ describe("api/editor/sshkeys", function() { }); it('GET /settings/user/keys --- return Error', function(done) { - var errInstance = new Error("Messages....."); + var errInstance = new Error("Messages here....."); errInstance.code = "test_code"; - mockRuntime.storage.projects.ssh.listSSHKeys.returns(Promise.reject(errInstance)); + var p = Promise.reject(errInstance); + p.catch(()=>{}); + mockRuntime.storage.projects.ssh.listSSHKeys.returns(p); request(app) .get("/settings/user/keys") .expect(400) @@ -167,7 +169,9 @@ describe("api/editor/sshkeys", function() { }); it('GET /settings/user/keys --- return Unexpected Error', function(done) { var errInstance = new Error("Messages....."); - mockRuntime.storage.projects.ssh.listSSHKeys.returns(Promise.reject(errInstance)); + var p = Promise.reject(errInstance); + p.catch(()=>{}); + mockRuntime.storage.projects.ssh.listSSHKeys.returns(p); request(app) .get("/settings/user/keys") .expect(400) @@ -204,7 +208,9 @@ describe("api/editor/sshkeys", function() { var key_file_name = "test_key"; var errInstance = new Error("Messages....."); errInstance.code = "test_code"; - mockRuntime.storage.projects.ssh.getSSHKey.returns(Promise.reject(errInstance)); + var p = Promise.reject(errInstance); + p.catch(()=>{}); + mockRuntime.storage.projects.ssh.getSSHKey.returns(p); request(app) .get("/settings/user/keys/" + key_file_name) .expect(400) @@ -223,7 +229,9 @@ describe("api/editor/sshkeys", function() { it('GET /settings/user/keys/ --- return Unexpected Error', function(done) { var key_file_name = "test_key"; var errInstance = new Error("Messages....."); - mockRuntime.storage.projects.ssh.getSSHKey.returns(Promise.reject(errInstance)); + var p = Promise.reject(errInstance); + p.catch(()=>{}); + mockRuntime.storage.projects.ssh.getSSHKey.returns(p); request(app) .get("/settings/user/keys/" + key_file_name) .expect(400) @@ -276,7 +284,9 @@ describe("api/editor/sshkeys", function() { var key_file_name = "test_key"; var errInstance = new Error("Messages....."); errInstance.code = "test_code"; - mockRuntime.storage.projects.ssh.generateSSHKey.returns(Promise.reject(errInstance)); + var p = Promise.reject(errInstance); + p.catch(()=>{}); + mockRuntime.storage.projects.ssh.generateSSHKey.returns(p); request(app) .post("/settings/user/keys") .send({ name: key_file_name }) @@ -296,7 +306,9 @@ describe("api/editor/sshkeys", function() { it('POST /settings/user/keys --- return Unexpected error', function(done) { var key_file_name = "test_key"; var errInstance = new Error("Messages....."); - mockRuntime.storage.projects.ssh.generateSSHKey.returns(Promise.reject(errInstance)); + var p = Promise.reject(errInstance); + p.catch(()=>{}); + mockRuntime.storage.projects.ssh.generateSSHKey.returns(p); request(app) .post("/settings/user/keys") .send({ name: key_file_name }) @@ -332,7 +344,9 @@ describe("api/editor/sshkeys", function() { var key_file_name = "test_key"; var errInstance = new Error("Messages....."); errInstance.code = "test_code"; - mockRuntime.storage.projects.ssh.deleteSSHKey.returns(Promise.reject(errInstance)); + var p = Promise.reject(errInstance); + p.catch(()=>{}); + mockRuntime.storage.projects.ssh.deleteSSHKey.returns(p); request(app) .delete("/settings/user/keys/" + key_file_name) .expect(400) @@ -351,7 +365,9 @@ describe("api/editor/sshkeys", function() { it('DELETE /settings/user/keys/ --- return Unexpected Error', function(done) { var key_file_name = "test_key"; var errInstance = new Error("Messages....."); - mockRuntime.storage.projects.ssh.deleteSSHKey.returns(Promise.reject(errInstance)); + var p = Promise.reject(errInstance); + p.catch(()=>{}); + mockRuntime.storage.projects.ssh.deleteSSHKey.returns(p); request(app) .delete("/settings/user/keys/" + key_file_name) .expect(400)