1
0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00

localfilesystem storage must fsync writes

Closes #465
This commit is contained in:
Nick O'Leary 2014-10-31 11:40:10 +00:00
parent dfc79e3122
commit 863b85714d

View File

@ -121,6 +121,25 @@ function getFileBody(root,path) {
return body; return body;
} }
/**
* Write content to a file using UTF8 encoding.
* This forces a fsync before completing to ensure
* the write hits disk.
*/
function writeFile(path,content) {
return when.promise(function(resolve,reject) {
var stream = fs.createWriteStream(path);
stream.on('open',function(fd) {
stream.end(content,'utf8',function() {
fs.fsync(fd,resolve);
});
});
stream.on('error',function(err) {
reject(err);
});
});
}
var localfilesystem = { var localfilesystem = {
init: function(_settings) { init: function(_settings) {
settings = _settings; settings = _settings;
@ -175,8 +194,7 @@ var localfilesystem = {
} else { } else {
flowData = JSON.stringify(flows); flowData = JSON.stringify(flows);
} }
return writeFile(flowsFullPath, flowData);
return nodeFn.call(fs.writeFile, flowsFullPath, flowData);
}, },
getCredentials: function() { getCredentials: function() {
@ -208,8 +226,7 @@ var localfilesystem = {
} else { } else {
credentialData = JSON.stringify(credentials); credentialData = JSON.stringify(credentials);
} }
return writeFile(credentialsFile, credentialData);
return nodeFn.call(fs.writeFile, credentialsFile, credentialData)
}, },
getSettings: function() { getSettings: function() {
@ -230,7 +247,7 @@ var localfilesystem = {
return when.resolve({}); return when.resolve({});
}, },
saveSettings: function(settings) { saveSettings: function(settings) {
return nodeFn.call(fs.writeFile,globalSettingsFile,JSON.stringify(settings,null,1),'utf8'); return writeFile(globalSettingsFile,JSON.stringify(settings,null,1));
}, },
@ -254,7 +271,7 @@ var localfilesystem = {
saveFlow: function(fn,data) { saveFlow: function(fn,data) {
var file = fspath.join(libFlowsDir,fn+".json"); var file = fspath.join(libFlowsDir,fn+".json");
return promiseDir(fspath.dirname(file)).then(function () { return promiseDir(fspath.dirname(file)).then(function () {
return nodeFn.call(fs.writeFile, file, data); return writeFile(file,data);
}); });
}, },
@ -301,7 +318,7 @@ var localfilesystem = {
} }
} }
return promiseDir(fspath.dirname(fn)).then(function () { return promiseDir(fspath.dirname(fn)).then(function () {
nodeFn.call(fs.writeFile, fn, headers+body); writeFile(fn,headers+body);
}); });
} }
}; };