From 2b91edeb7437be104afd7a740a4e0a54aaf127f2 Mon Sep 17 00:00:00 2001
From: Hiroyasu Nishiyama <hiroyasu.nishiyama.uq@hitachi.com>
Date: Tue, 14 Jun 2022 16:49:14 +0900
Subject: [PATCH] fix uncorrect fix of junction to subflow conversion

---
 .../node_modules/@node-red/editor-client/src/js/nodes.js     | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/packages/node_modules/@node-red/editor-client/src/js/nodes.js b/packages/node_modules/@node-red/editor-client/src/js/nodes.js
index ab31e5038..052fad558 100644
--- a/packages/node_modules/@node-red/editor-client/src/js/nodes.js
+++ b/packages/node_modules/@node-red/editor-client/src/js/nodes.js
@@ -778,12 +778,13 @@ RED.nodes = (function() {
 
     function moveJunctionToTab(junction, z) {
         var index = junctionsByZ[junction.z].indexOf(junction);
-        junctionsByZ[junction.z].splice(junction,1);
+        junctionsByZ[junction.z].splice(index,1);
         junctionsByZ[z] = junctionsByZ[z] || [];
         junctionsByZ[z].push(junction);
-        junction.z = z;
 
         var oldZ = junction.z;
+        junction.z = z;
+
         var nl = nodeLinks[junction.id];
         if (nl) {
             nl.in.forEach(function(l) {