frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Gauthier Dandele <92022724+GogoVega@users.noreply.github.com>
This commit is contained in:
Nick O'Leary 2024-12-04 10:41:10 +00:00 committed by GitHub
parent 338ddf17de
commit 92dff4bacd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
packages/node_modules/@node-red/editor-client/src/js/nodes.js vendored
View File

@ -812,20 +812,6 @@ RED.nodes = (function() {
if (sf) { if (sf) {
sf.instances.splice(sf.instances.indexOf(node),1); sf.instances.splice(sf.instances.indexOf(node),1);
} }
node.env?.forEach((prop) => {
if (prop.type === "conf-type" && prop.value) {
// Remove the node from the config node users
const configNode = getNode(prop.value);
if (configNode) {
if (configNode.users.indexOf(node) !== -1) {
configNode.users.splice(configNode.users.indexOf(node), 1);
RED.events.emit('nodes:change', configNode);
updatedConfigNode = true;
}
}
}
});
} }
if (updatedConfigNode) { if (updatedConfigNode) {
@ -2764,15 +2750,27 @@ RED.nodes = (function() {
} }
// Subflows can have config node env // Subflows can have config node env
if (n.type.indexOf("subflow:") === 0) { if (node.type.indexOf("subflow:") === 0) {
n.env?.forEach((prop) => { node.env?.forEach((prop) => {
if (prop.type === "conf-type" && prop.value) { if (prop.type === "conf-type" && prop.value) {
// Add the node to the config node users // Add the node to the config node users
const configNode = getNode(prop.value); const configNode = getNode(prop.value);
if (configNode) { if (configNode) {
if (configNode.users.indexOf(n) === -1) { if (options.action === "add") {
configNode.users.push(n); if (configNode.users.indexOf(node) === -1) {
RED.events.emit('nodes:change', configNode); configNode.users.push(node);
if (options.emitEvent) {
RED.events.emit('nodes:change', configNode);
}
}
} else if (options.action === "remove") {
if (configNode.users.indexOf(node) !== -1) {
const users = configNode.users;
users.splice(users.indexOf(node), 1);
if (options.emitEvent) {
RED.events.emit('nodes:change', configNode);
}
}
} }
} }
} }