frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4816 from node-red/4814-multiplayer-uncaught

Browse Source 
Guard against undefined sessions in multiplayer
This commit is contained in:
Nick O'Leary 2024-06-28 16:58:25 +01:00 committed by GitHub
commit 93974ccd92
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 31 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/node_modules/@node-red/runtime/lib/multiplayer/index.js vendored
View File

@ -23,6 +23,7 @@ module.exports = {
if (existingSessionId) { if (existingSessionId) {
connections.delete(opts.session) connections.delete(opts.session)
const session = sessions.get(existingSessionId) const session = sessions.get(existingSessionId)
if (session) {
session.active = false session.active = false
session.idleTimeout = setTimeout(() => { session.idleTimeout = setTimeout(() => {
sessions.delete(existingSessionId) sessions.delete(existingSessionId)
@ -32,6 +33,7 @@ module.exports = {
data: { session: existingSessionId } data: { session: existingSessionId }
}) })
} }
}
}) })
runtime.events.on('comms:message:multiplayer/connect', (opts) => { runtime.events.on('comms:message:multiplayer/connect', (opts) => {
let session let session
@ -91,6 +93,7 @@ module.exports = {
const sessionId = connections.get(opts.session) const sessionId = connections.get(opts.session)
const session = sessions.get(sessionId) const session = sessions.get(sessionId)
if (session) {
if (opts.user) { if (opts.user) {
if (session.user.anonymous !== opts.user.anonymous) { if (session.user.anonymous !== opts.user.anonymous) {
session.user = opts.user session.user = opts.user
@ -114,6 +117,7 @@ module.exports = {
data: payload, data: payload,
excludeSession: opts.session excludeSession: opts.session
}) })
}
}) })
} }
} }