frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

Merge pull request #3570 from node-red/validate-tooltip-fix

Browse Source 
Ensure node validation tooltip is closed when field becomes valid
This commit is contained in:
Nick O'Leary 2022-05-03 09:22:24 +01:00 committed by GitHub
commit 95b35be541
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/node_modules/@node-red/editor-client/src/js/ui/common/popover.js vendored
View File

@ -472,6 +472,7 @@ RED.popover = (function() {
action = newAction; action = newAction;
} }
popover.delete = function() { popover.delete = function() {
popover.close(true)
target.off("mouseenter"); target.off("mouseenter");
target.off("mouseleave"); target.off("mouseleave");
}; };

23
packages/node_modules/@node-red/editor-client/src/js/ui/editor.js vendored
View File

@ -421,20 +421,11 @@ RED.editor = (function() {
* @param prefix - the prefix to use in the input element ids (node-input|node-config-input) * @param prefix - the prefix to use in the input element ids (node-input|node-config-input)
*/ */
function attachPropertyChangeHandler(node,definition,property,prefix) { function attachPropertyChangeHandler(node,definition,property,prefix) {
var input = $("#"+prefix+"-"+property); $("#"+prefix+"-"+property).on("change keyup paste", function(event) {
if (definition !== undefined && "format" in definition[property] && definition[property].format !== "" && input[0].nodeName === "DIV") { if (!$(this).attr("skipValidation")) {
$("#"+prefix+"-"+property).on('change keyup', function(event) { validateNodeEditor(node,prefix);
if (!$(this).attr("skipValidation")) { }
validateNodeEditor(node,prefix); });
}
});
} else {
$("#"+prefix+"-"+property).on("change", function(event) {
if (!$(this).attr("skipValidation")) {
validateNodeEditor(node,prefix);
}
});
}
} }
/** /**
@ -1066,7 +1057,7 @@ RED.editor = (function() {
nodeEditPanes.push('editor-tab-description'); nodeEditPanes.push('editor-tab-description');
removeInfoEditorOnClose = true; removeInfoEditorOnClose = true;
if(node.infoEditor) { if(node.infoEditor) {
//As 'editor-tab-description' adds `node.infoEditor` store original & set a //As 'editor-tab-description' adds `node.infoEditor` store original & set a
//flag to NOT remove this property //flag to NOT remove this property
node.infoEditor__orig = node.infoEditor; node.infoEditor__orig = node.infoEditor;
delete node.infoEditor; delete node.infoEditor;
@ -1975,7 +1966,7 @@ RED.editor = (function() {
if (source === "node" && thing.id) { if (source === "node" && thing.id) {
id = thing.id; id = thing.id;
} else if (selection.nodes && selection.nodes.length) { } else if (selection.nodes && selection.nodes.length) {
id = selection.nodes[0].id; id = selection.nodes[0].id;
} else { } else {
return false; //cant obtain Id. return false; //cant obtain Id.
} }