From 9c71d52d692e06ba32edfc8835a9dbd0e53f0513 Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Mon, 27 Nov 2023 17:27:32 +0000 Subject: [PATCH] Check node.broker is a string before trying to use it Fixes #4380 --- packages/node_modules/@node-red/nodes/core/network/10-mqtt.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node_modules/@node-red/nodes/core/network/10-mqtt.js b/packages/node_modules/@node-red/nodes/core/network/10-mqtt.js index a2aed0b03..0d07091b7 100644 --- a/packages/node_modules/@node-red/nodes/core/network/10-mqtt.js +++ b/packages/node_modules/@node-red/nodes/core/network/10-mqtt.js @@ -612,7 +612,7 @@ module.exports = function(RED) { node.brokerurl = node.url; } else { // if the broker is ws:// or wss:// or tcp:// - if (node.broker.indexOf("://") > -1) { + if ((typeof node.broker === 'string') && node.broker.indexOf("://") > -1) { node.brokerurl = node.broker; // Only for ws or wss, check if proxy env var for additional configuration if (node.brokerurl.indexOf("wss://") > -1 || node.brokerurl.indexOf("ws://") > -1) {