From 9f703de5ecf2eb54af51960aec4536687ccc73b2 Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Mon, 16 Apr 2018 11:20:03 +0100 Subject: [PATCH] Allow importing an unknown config node to be undone Fixes #1681 --- editor/js/nodes.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/editor/js/nodes.js b/editor/js/nodes.js index 8c8210c54..d51ef39d9 100644 --- a/editor/js/nodes.js +++ b/editor/js/nodes.js @@ -1012,6 +1012,13 @@ RED.nodes = (function() { set: registry.getNodeSet("node-red/unknown") }; node.users = []; + // This is a config node, so delete the default + // non-config node properties + delete node.x; + delete node.y; + delete node.wires; + delete node.inputLabels; + delete node.outputLabels; } var orig = {}; for (var p in n) { @@ -1047,7 +1054,9 @@ RED.nodes = (function() { addNode(node); RED.editor.validateNode(node); node_map[n.id] = node; - if (node._def.category != "config") { + // If an 'unknown' config node, it will not have been caught by the + // proper config node handling, so needs adding to new_nodes here + if (node.type === "unknown" || node._def.category !== "config") { new_nodes.push(node); } }