From fe0d4f08f35e06412cc83f68a41c2f99fe07117b Mon Sep 17 00:00:00 2001 From: Vladimir Dronnikov Date: Wed, 25 Dec 2019 06:21:55 +0300 Subject: [PATCH 1/3] Allow to know particular session from status node The rationale is to keep own list of active sessions. As a workaround for https://discourse.nodered.org/t/tcp-connection-pool-better-separation/19432 TIA --- .../node_modules/@node-red/nodes/core/network/31-tcpin.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/node_modules/@node-red/nodes/core/network/31-tcpin.js b/packages/node_modules/@node-red/nodes/core/network/31-tcpin.js index e52e9c382..655e72c1e 100644 --- a/packages/node_modules/@node-red/nodes/core/network/31-tcpin.js +++ b/packages/node_modules/@node-red/nodes/core/network/31-tcpin.js @@ -74,7 +74,7 @@ module.exports = function(RED) { buffer = (node.datatype == 'buffer') ? Buffer.alloc(0) : ""; node.connected = true; node.log(RED._("tcpin.status.connected",{host:node.host,port:node.port})); - node.status({fill:"green",shape:"dot",text:"common.status.connected"}); + node.status({fill:"green",shape:"dot",text:"common.status.connected",_session:{type:"tcp",id:id}}); }); client.setKeepAlive(true,120000); connectionPool[id] = client; @@ -121,7 +121,7 @@ module.exports = function(RED) { client.on('close', function() { delete connectionPool[id]; node.connected = false; - node.status({fill:"red",shape:"ring",text:"common.status.disconnected"}); + node.status({fill:"red",shape:"ring",text:"common.status.disconnected",_session:{type:"tcp",id:id}}); if (!node.closing) { if (end) { // if we were asked to close then try to reconnect once very quick. end = false; From 9cbc40a22990f151506b96a4ff8a20cfec5e2619 Mon Sep 17 00:00:00 2001 From: Hiroyasu Nishiyama Date: Tue, 5 May 2020 22:43:08 +0900 Subject: [PATCH 2/3] fix message catalogue for CSV ndoe & update japanese message catalogue (#2554) --- .../node_modules/@node-red/nodes/locales/en-US/messages.json | 2 +- packages/node_modules/@node-red/nodes/locales/ja/messages.json | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/node_modules/@node-red/nodes/locales/en-US/messages.json b/packages/node_modules/@node-red/nodes/locales/en-US/messages.json index 979238ac9..f87955a48 100755 --- a/packages/node_modules/@node-red/nodes/locales/en-US/messages.json +++ b/packages/node_modules/@node-red/nodes/locales/en-US/messages.json @@ -732,7 +732,7 @@ "errors": { "csv_js": "This node only handles CSV strings or js objects.", "obj_csv": "No columns template specified for object -> CSV.", - "bad_csv": "Malformed CSV file - output probably corrupt." + "bad_csv": "Malformed CSV data - output probably corrupt." } }, "html": { diff --git a/packages/node_modules/@node-red/nodes/locales/ja/messages.json b/packages/node_modules/@node-red/nodes/locales/ja/messages.json index 32b59361b..a1e3efa94 100755 --- a/packages/node_modules/@node-red/nodes/locales/ja/messages.json +++ b/packages/node_modules/@node-red/nodes/locales/ja/messages.json @@ -726,7 +726,8 @@ }, "errors": { "csv_js": "本ノードが処理できる形式は、CSV文字列またはJSONのみです", - "obj_csv": "オブジェクトをCSVへ変換する際の列名が設定されていません" + "obj_csv": "オブジェクトをCSVへ変換する際の列名が設定されていません", + "bad_csv": "不正なCSVデータ - 出力の修正を試みました" } }, "html": { From 189389f96a12975c7e2552dd29f9ade1e2ae3e21 Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Tue, 5 May 2020 17:35:08 +0100 Subject: [PATCH 3/3] [inject] Tidy up node label --- .../nodes/core/common/20-inject.html | 65 +++++++++---------- 1 file changed, 30 insertions(+), 35 deletions(-) diff --git a/packages/node_modules/@node-red/nodes/core/common/20-inject.html b/packages/node_modules/@node-red/nodes/core/common/20-inject.html index 0501042c3..af784978a 100644 --- a/packages/node_modules/@node-red/nodes/core/common/20-inject.html +++ b/packages/node_modules/@node-red/nodes/core/common/20-inject.html @@ -224,38 +224,6 @@ return lab; }, label: function() { - if (Array.isArray(this.props)) { - // find the payload & topic - var payloadProperty; - var topicProperty; - var payload; - var payloadType; - var topic; - for (var i=0,l=this.props.length; i