frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

update getObjectProperty(msg,expr)

Browse Source 
update getObjectProperty(msg,expr) to support invalid expression to return undefined instead of crashing

Quick Check 

m = {a:{b:{c:{d:{e:"hello"}}}}};

console.log(getMessageProperty(m,"a.b.c.d"))
console.log(getMessageProperty(m,"a.j.c.d"))

{ e: 'hello' }
undefined

instead of with current code 

        result = ( typeof obj[key] !== "undefined" ? obj[key] : undefined);
                              ^

TypeError: Cannot read property 'c' of undefined
This commit is contained in:
Aurelien Bruno 2019-12-02 22:29:19 +01:00 committed by GitHub
parent c1dae95f71
commit a337ebcf0d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/node_modules/@node-red/util/lib/util.js vendored
View File

@ -325,7 +325,7 @@ function getObjectProperty(msg,expr) {
var msgPropParts = normalisePropertyExpression(expr); var msgPropParts = normalisePropertyExpression(expr);
var m; var m;
msgPropParts.reduce(function(obj, key) { msgPropParts.reduce(function(obj, key) {
result = (typeof obj[key] !== "undefined" ? obj[key] : undefined); result = ((obj && typeof obj[key] !== "undefined") ? obj[key] : undefined);
return result; return result;
}, msg); }, msg);
return result; return result;