From a3cbe80a360f52a8d50a1292f69e3eb90709e61b Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Wed, 20 Mar 2019 14:58:26 +0000 Subject: [PATCH] Do not dynamically add/remove upgrade listener in ws nodes The way we dynamically added/removed event handlers for the upgrade event was causing problems with the way sockjs (as used by the worldmap node) tries to intercept the event. This fix means the ws nodes won't ever remove the upgrade listener - it gets added once when the first ws node is deployed and will then remain until the last ws node is removed and the runtime restarted. --- .../node_modules/@node-red/nodes/core/io/22-websocket.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/node_modules/@node-red/nodes/core/io/22-websocket.js b/packages/node_modules/@node-red/nodes/core/io/22-websocket.js index 3b06b0d5c..befb8bcff 100644 --- a/packages/node_modules/@node-red/nodes/core/io/22-websocket.js +++ b/packages/node_modules/@node-red/nodes/core/io/22-websocket.js @@ -141,10 +141,10 @@ module.exports = function(RED) { node.server.close(); node._inputNodes = []; activeListenerNodes--; - if (activeListenerNodes === 0 && serverUpgradeAdded) { - RED.server.removeListener('upgrade', handleServerUpgrade); - serverUpgradeAdded = false; - } + // if (activeListenerNodes === 0 && serverUpgradeAdded) { + // RED.server.removeListener('upgrade', handleServerUpgrade); + // serverUpgradeAdded = false; + // } }