From 06a1f303501ae5deb03976a24820aa005e03822f Mon Sep 17 00:00:00 2001 From: Arun Nattarayan Date: Fri, 30 Nov 2018 20:04:12 +0530 Subject: [PATCH 1/2] Added validation while export into library --- editor/js/ui/library.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/editor/js/ui/library.js b/editor/js/ui/library.js index 2f78828c3..e64a7c462 100644 --- a/editor/js/ui/library.js +++ b/editor/js/ui/library.js @@ -447,7 +447,9 @@ RED.library = (function() { click: function() { //TODO: move this to RED.library var flowName = $("#node-input-library-filename").val(); - if (!/^\s*$/.test(flowName)) { + if(flowName.split(/[\\/]/).pop() === "" || /^\s*$/.test(flowName)) { + RED.notify(RED._("library.invalidFilename"),"warning"); + } else { $.ajax({ url:'library/flows/'+flowName, type: "POST", From 7b80ae42e1cb38bd9c57e5dc9518ccd499672c48 Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Thu, 6 Dec 2018 19:20:43 +0530 Subject: [PATCH 2/2] removed regex in if statement Co-Authored-By: arunnattarayan --- editor/js/ui/library.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/editor/js/ui/library.js b/editor/js/ui/library.js index e64a7c462..a3419f99a 100644 --- a/editor/js/ui/library.js +++ b/editor/js/ui/library.js @@ -447,7 +447,8 @@ RED.library = (function() { click: function() { //TODO: move this to RED.library var flowName = $("#node-input-library-filename").val(); - if(flowName.split(/[\\/]/).pop() === "" || /^\s*$/.test(flowName)) { + flowName = flowName.trim(); + if(flowName === "" || flowName.endsWith("/")) { RED.notify(RED._("library.invalidFilename"),"warning"); } else { $.ajax({