Move core node icons into node package

packages/node_modules/@node-red/editor/lib/editor/ui.js

@@ -25,6 +25,7 @@ var theme = require("./theme");
 
 var runtimeAPI;
 
+var defaultNodeIcon = path.resolve(__dirname+"/../../src/images/icons/arrow-in.png")
 var templateDir = path.resolve(__dirname+"/../../src/templates");
 var editorTemplate;
 
@@ -55,10 +56,15 @@ module.exports = {
             icon: icon
         }
         runtimeAPI.nodes.getIcon(opts).then(function(data) {
-            var contentType = mime.lookup(icon);
-            res.set("Content-Type", contentType);
-            res.send(data);
+            if (data) {
+                var contentType = mime.lookup(icon);
+                res.set("Content-Type", contentType);
+                res.send(data);
+            } else {
+                res.sendFile(defaultNodeIcon);
+            }
         }).catch(function(err) {
+            console.log(err.stack);
             apiUtils.rejectHandler(req,res,err);
         })
     },

packages/node_modules/@node-red/editor/src/js/ui/view.js

@@ -2182,8 +2182,8 @@ RED.view = (function() {
                     //node.append("path").attr("class","node_error").attr("d","M 3,-3 l 10,0 l -5,-8 z");
 
                     //TODO: these ought to be SVG
-                    node.append("image").attr("class","node_error hidden").attr("xlink:href","icons/node-red/node-error.png").attr("x",0).attr("y",-6).attr("width",10).attr("height",9);
-                    node.append("image").attr("class","node_changed hidden").attr("xlink:href","icons/node-red/node-changed.png").attr("x",12).attr("y",-6).attr("width",10).attr("height",10);
+                    node.append("image").attr("class","node_error hidden").attr("xlink:href","red/images/icons/node-error.png").attr("x",0).attr("y",-6).attr("width",10).attr("height",9);
+                    node.append("image").attr("class","node_changed hidden").attr("xlink:href","red/images/icons/node-changed.png").attr("x",12).attr("y",-6).attr("width",10).attr("height",10);
             });
 
             node.each(function(d,i) {