frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

Ensure httpServerOptions gets applied to ALL the express apps

Browse Source 
This is silly. Turns out setting options at a top level app
does not percolate down to sub apps (and vice versa). You
have to apply the options to ALL express apps.
This commit is contained in:
Nick O'Leary 2021-06-08 21:17:42 +01:00
parent d83e543a98
commit a9b252b8fa
No known key found for this signature in database
GPG Key ID: 4F2157149161A6C9
4 changed files with 33 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/node_modules/@node-red/editor-api/lib/admin/index.js vendored
View File

@ -39,6 +39,15 @@ module.exports = {
var adminApp = express(); var adminApp = express();
var defaultServerSettings = {
"x-powered-by": false
}
var serverSettings = Object.assign({},defaultServerSettings,settings.httpServerOptions||{});
for (var eOption in serverSettings) {
adminApp.set(eOption, serverSettings[eOption]);
}
// Flows // Flows
adminApp.get("/flows",needsPermission("flows.read"),flows.get,apiUtil.errorHandler); adminApp.get("/flows",needsPermission("flows.read"),flows.get,apiUtil.errorHandler);
adminApp.post("/flows",needsPermission("flows.write"),flows.post,apiUtil.errorHandler); adminApp.post("/flows",needsPermission("flows.write"),flows.post,apiUtil.errorHandler);

10
packages/node_modules/@node-red/editor-api/lib/editor/index.js vendored
View File

@ -64,10 +64,12 @@ module.exports = {
} }
}); });
} }
if (settings.httpServerOptions) { var defaultServerSettings = {
for (var eOption in settings.httpServerOptions) { "x-powered-by": false
editorApp.set(eOption, settings.httpServerOptions[eOption]); }
} var serverSettings = Object.assign({},defaultServerSettings,settings.httpServerOptions||{});
for (var eOption in serverSettings) {
editorApp.set(eOption, serverSettings[eOption]);
} }
editorApp.get("/",ensureRuntimeStarted,ui.ensureSlash,ui.editor); editorApp.get("/",ensureRuntimeStarted,ui.ensureSlash,ui.editor);

8
packages/node_modules/@node-red/editor-api/lib/index.js vendored
View File

@ -64,6 +64,14 @@ function init(settings,_server,storage,runtimeAPI) {
} }
} }
var defaultServerSettings = {
"x-powered-by": false
}
var serverSettings = Object.assign({},defaultServerSettings,settings.httpServerOptions||{});
for (var eOption in serverSettings) {
adminApp.set(eOption, serverSettings[eOption]);
}
auth.init(settings,storage); auth.init(settings,storage);
var maxApiRequestSize = settings.apiMaxLength || '5mb'; var maxApiRequestSize = settings.apiMaxLength || '5mb';

10
packages/node_modules/node-red/red.js vendored
View File

@ -194,6 +194,16 @@ if (process.env.NODE_RED_ENABLE_PROJECTS) {
settings.editorTheme.projects.enabled = !/^false$/i.test(process.env.NODE_RED_ENABLE_PROJECTS); settings.editorTheme.projects.enabled = !/^false$/i.test(process.env.NODE_RED_ENABLE_PROJECTS);
} }
var defaultServerSettings = {
"x-powered-by": false
}
var serverSettings = Object.assign({},defaultServerSettings,settings.httpServerOptions||{});
for (var eOption in serverSettings) {
app.set(eOption, serverSettings[eOption]);
}
// Delay logging of (translated) messages until the RED object has been initialized // Delay logging of (translated) messages until the RED object has been initialized
var delayedLogItems = []; var delayedLogItems = [];