Merge pull request #4690 from Rotzbua/fix_node_requirement

fix(node): increase required node >=18.5
This commit is contained in:
Nick O'Leary 2024-05-14 13:29:52 +01:00 committed by GitHub
commit ac6a4945cb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 46 additions and 56 deletions

View File

@ -123,6 +123,6 @@
"supertest": "6.3.3"
},
"engines": {
"node": ">=18"
"node": ">=18.5"
}
}

View File

@ -47,6 +47,6 @@
"bcrypt": "5.1.0"
},
"engines": {
"node": ">=18"
"node": ">=18.5"
}
}

View File

@ -2509,15 +2509,6 @@ describe('HTTP Request Node', function() {
});
describe('should parse broken headers', function() {
const versions = process.versions.node.split('.')
if (( versions[0] == 14 && versions[1] >= 20 ) ||
( versions[0] == 16 && versions[1] >= 16 ) ||
( versions[0] == 18 && versions[1] >= 5 ) ||
( versions[0] > 18)) {
// only test if on new enough NodeJS version
let port = testPort++
let server;
@ -2572,6 +2563,5 @@ describe('HTTP Request Node', function() {
});
});
}
});
});