frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

File node - don't hose status web socket on multiple file writes

Browse Source 
and add close behaviour to info
This commit is contained in:
Dave Conway-Jones
2017-06-29 11:40:47 +01:00
parent dfc4e99560
commit adca1d7855
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
nodes/core/storage/50-file.html
View File

@@ -40,6 +40,8 @@
<h3>Details</h3> <h3>Details</h3>
<p>Each message payload will be added to the end of the file, optionally appending <p>Each message payload will be added to the end of the file, optionally appending
a newline (\n) character between each one.</p> a newline (\n) character between each one.</p>
<p>If <code>msg.filename</code> is used the file will be closed after every write.
For best performance use a fixed filename.</p>
<p>It can be configured to overwrite the entire file rather than append. For example, <p>It can be configured to overwrite the entire file rather than append. For example,
when writing binary data to a file, such as an image, this option should be used when writing binary data to a file, such as an image, this option should be used
and the option to append a newline should be disabled.</p> and the option to append a newline should be disabled.</p>

9
nodes/core/storage/50-file.js
View File

@@ -32,7 +32,13 @@ module.exports = function(RED) {
this.on("input",function(msg) { this.on("input",function(msg) {
var filename = node.filename || msg.filename || ""; var filename = node.filename || msg.filename || "";
if (!node.filename) { node.status({fill:"grey",shape:"dot",text:filename}); } if ((!node.filename) && (!node.tout)) {
node.tout = setTimeout(function() {
node.status({fill:"grey",shape:"dot",text:filename});
clearTimeout(node.tout);
node.tout = null;
},333);
}
if (filename === "") { node.warn(RED._("file.errors.nofilename")); } if (filename === "") { node.warn(RED._("file.errors.nofilename")); }
else if (node.overwriteFile === "delete") { else if (node.overwriteFile === "delete") {
fs.unlink(filename, function (err) { fs.unlink(filename, function (err) {
@@ -80,6 +86,7 @@ module.exports = function(RED) {
}); });
this.on('close', function() { this.on('close', function() {
if (node.wstream) { node.wstream.end(); } if (node.wstream) { node.wstream.end(); }
if (node.tout) { clearTimeout(node.tout); }
node.status({}); node.status({});
}); });
} }