frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

Add line/col reporting to Function runtime errors

Browse Source
This commit is contained in:
Nick O'Leary 2015-02-07 19:52:14 +00:00
parent 83dad88ad3
commit ae7f1b38a8
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
nodes/core/core/80-function.js
View File

@ -23,7 +23,7 @@ module.exports = function(RED) {
RED.nodes.createNode(this,n); RED.nodes.createNode(this,n);
this.name = n.name; this.name = n.name;
this.func = n.func; this.func = n.func;
var functionText = "var results = null; results = (function(msg){"+this.func+"\n})(msg);"; var functionText = "var results = null; results = (function(msg){\n"+this.func+"\n})(msg);";
this.topic = n.topic; this.topic = n.topic;
var sandbox = { var sandbox = {
console:console, console:console,
@ -68,10 +68,22 @@ module.exports = function(RED) {
this.status({fill:"yellow",shape:"dot",text:""+converted}); this.status({fill:"yellow",shape:"dot",text:""+converted});
} }
} catch(err) { } catch(err) {
this.error(err.toString()); var errorMessage = err.toString();
var stack = err.stack.split(/\r?\n/);
if (stack.length > 0) {
var m = /at undefined:(\d+):(\d+)$/.exec(stack[1]);
if (m) {
var line = Number(m[1])-1;
var cha = m[2];
errorMessage += " (line "+line+", col "+cha+")";
}
}
this.error(errorMessage);
} }
}); });
} catch(err) { } catch(err) {
// eg SyntaxError - which v8 doesn't include line number information
// so we can't do better than this
this.error(err); this.error(err);
} }
} }