frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

enhance a couple of tests to check more

Browse Source 
Delay node checks  times properly for both types of queue. And File
checks to make sure other payload types are handled (a bit better than
they were)
This commit is contained in:
Dave Conway-Jones 2016-04-24 17:41:22 +01:00
parent 8fc0018cb9
commit b2923d0fc4
2 changed files with 72 additions and 67 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

125
test/nodes/core/core/89-delay_spec.js
View File

@ -403,20 +403,17 @@ describe('delay Node', function() {
randomDelayTest(0.0000046296, 0.0000092593, "days", done); randomDelayTest(0.0000046296, 0.0000092593, "days", done);
}); });
it.skip('handles bursts using a buffer', function(done) { it('handles bursts using a buffer', function(done) {
// routinely timesout on Travis - needs fixing this.timeout(10000);
this.timeout(8000);
var flow = [{"id":"delayNode1","type":"delay","name":"delayNode","pauseType":"rate","timeout":5,"timeoutUnits":"seconds","rate":1000,"rateUnits":"second","randomFirst":"1","randomLast":"5","randomUnits":"seconds","drop":false,"wires":[["helperNode1"]]}, var flow = [{"id":"delayNode1","type":"delay","name":"delayNode","pauseType":"rate","timeout":5,"timeoutUnits":"seconds","rate":1000,"rateUnits":"second","randomFirst":"1","randomLast":"5","randomUnits":"seconds","drop":false,"wires":[["helperNode1"]]},
{id:"helperNode1", type:"helper", wires:[]}]; {id:"helperNode1", type:"helper", wires:[]}];
helper.load(delayNode, flow, function() { helper.load(delayNode, flow, function() {
var delayNode1 = helper.getNode("delayNode1"); var delayNode1 = helper.getNode("delayNode1");
var helperNode1 = helper.getNode("helperNode1"); var helperNode1 = helper.getNode("helperNode1");
var sinon = require('sinon'); var sinon = require('sinon');
var receivedWarning = false; var receivedWarning = false;
var messageBurstSize = 1500; var messageBurstSize = 1200;
// we ensure that we note that a warning is received for buffer growth // we ensure that we note that a warning is received for buffer growth
sinon.stub(delayNode1, 'warn', function(warning) { sinon.stub(delayNode1, 'warn', function(warning) {
@ -424,14 +421,13 @@ describe('delay Node', function() {
receivedWarning = true; receivedWarning = true;
} }
}); });
// we ensure that the warning is received for buffer size and that we get the last message // we ensure that the warning is received for buffer size and that we get the last message
helperNode1.on("input", function(msg) { helperNode1.on("input", function(msg) {
if (msg.payload === (messageBurstSize - 1) && receivedWarning === true) { if (msg.payload === (messageBurstSize - 1) && receivedWarning === true) {
done(); // it will timeout if we don't receive the last message done(); // it will timeout if we don't receive the last message
} }
}); });
// send 1500 messages as quickly as possible // send messages as quickly as possible
for (var i = 0; i < messageBurstSize; i++) { for (var i = 0; i < messageBurstSize; i++) {
delayNode1.receive({payload:i}); delayNode1.receive({payload:i});
} }
@ -439,82 +435,87 @@ describe('delay Node', function() {
}); });
it('handles delay queue', function(done) { it('handles delay queue', function(done) {
this.timeout(6000); this.timeout(2000);
var flow = [{id:"delayNode1", type :"delay","name":"delayNode","pauseType":"queue","timeout":1,"timeoutUnits":"seconds","rate":4,"rateUnits":"second","randomFirst":"1","randomLast":"5","randomUnits":"seconds","drop":false,"wires":[["helperNode1"]]},
var flow = [{"id":"delayNode1","type":"delay","name":"delayNode","pauseType":"queue","timeout":5,"timeoutUnits":"seconds","rate":1000,"rateUnits":"second","randomFirst":"1","randomLast":"5","randomUnits":"seconds","drop":false,"wires":[["helperNode1"]]},
{id:"helperNode1", type:"helper", wires:[]}]; {id:"helperNode1", type:"helper", wires:[]}];
helper.load(delayNode, flow, function() { helper.load(delayNode, flow, function() {
var delayNode1 = helper.getNode("delayNode1"); var delayNode1 = helper.getNode("delayNode1");
var helperNode1 = helper.getNode("helperNode1"); var helperNode1 = helper.getNode("helperNode1");
var messages = 2; var t = Date.now();
var c = 0;
helperNode1.on("input", function(msg) { helperNode1.on("input", function(msg) {
c += 1;
msg.should.have.a.property('payload'); msg.should.have.a.property('payload');
msg.should.have.a.property('topic'); msg.should.have.a.property('topic');
if (msg.topic === "A") { try {
msg.payload.should.equal(4); if (msg.topic === "_none_") {
} msg.payload.should.equal(2);
else { (Date.now() - t).should.be.approximately(500,50);
msg.topic.should.equal("_none_"); }
msg.payload.should.equal(2); else if (msg.topic === "A") {
} msg.payload.should.equal(4);
if (c == 2) { (Date.now() - t).should.be.approximately(750,50);
done(); // it will timeout if we don't receive both messages }
else {
msg.topic.should.equal("B");
msg.payload.should.equal(1);
(Date.now() - t).should.be.approximately(1000,50);
done();
}
} catch(e) {
done(e);
} }
}); });
setTimeout(function() {
// send test messages // send test messages
delayNode1.receive({payload:1,topic:"A"}); delayNode1.receive({payload:1}); // send something with blank topic
delayNode1.receive({payload:1}); delayNode1.receive({payload:1,topic:"A"}); // and something with a fixed topic
delayNode1.receive({payload:2,topic:"A"}); delayNode1.receive({payload:1,topic:"B"}); // and something else with a fixed topic (3rd tick)
delayNode1.receive({payload:3,topic:"A"}); delayNode1.receive({payload:2,topic:"A"}); // these should replace them in queue
delayNode1.receive({payload:2}); // only this should get out delayNode1.receive({payload:3,topic:"A"}); // ditto
delayNode1.receive({payload:4,topic:"A"}); // and this one also delayNode1.receive({payload:2}); // so only this should get out on first tick
delayNode1.receive({payload:4,topic:"A"}); // and this one on second tick
}, 275); // wait one tick beofre starting.. (to test no messages in queue path.)
}); });
}); });
it('handles timed queue', function(done) { it('handles timed queue', function(done) {
this.timeout(6000); this.timeout(2000);
var flow = [{"id":"delayNode1","type":"delay","name":"delayNode","pauseType":"timed","timeout":1,"timeoutUnits":"seconds","rate":2,"rateUnits":"second","randomFirst":"1","randomLast":"5","randomUnits":"seconds","drop":false,"wires":[["helperNode1"]]},
var flow = [{"id":"delayNode1","type":"delay","name":"delayNode","pauseType":"timed","timeout":5,"timeoutUnits":"seconds","rate":1000,"rateUnits":"second","randomFirst":"1","randomLast":"5","randomUnits":"seconds","drop":false,"wires":[["helperNode1"]]},
{id:"helperNode1", type:"helper", wires:[]}]; {id:"helperNode1", type:"helper", wires:[]}];
helper.load(delayNode, flow, function() { helper.load(delayNode, flow, function() {
var delayNode1 = helper.getNode("delayNode1"); var delayNode1 = helper.getNode("delayNode1");
var helperNode1 = helper.getNode("helperNode1"); var helperNode1 = helper.getNode("helperNode1");
var messages = 2; var t = Date.now();
var c = 0;
helperNode1.on("input", function(msg) { helperNode1.on("input", function(msg) {
c += 1; msg.should.have.a.property('payload');
if (c === 1) { msg.should.have.a.property('topic');
msg.should.have.property("topic","A"); try {
msg.should.have.property("payload",3); if (msg.topic === "_none_") {
} msg.payload.should.equal(2);
else if (c === 2) { (Date.now() - t).should.be.approximately(500,50);
msg.should.have.property("topic","_none_"); }
msg.should.have.property("payload",2); else if (msg.topic === "A") {
} msg.payload.should.equal(4);
else if (c === 3) { (Date.now() - t).should.be.approximately(500,50);
msg.should.have.property("topic","_none_"); }
msg.should.have.property("payload","Biscuit"); else {
done(); msg.topic.should.equal("B");
msg.payload.should.equal(1);
(Date.now() - t).should.be.approximately(500,50);
done();
}
} catch(e) {
done(e);
} }
}); });
// send test messages // send test messages
delayNode1.receive({payload:1,topic:"A"}); delayNode1.receive({payload:1}); // send something with blank topic
delayNode1.receive({payload:1}); delayNode1.receive({payload:1,topic:"A"}); // and something with a fixed topic
delayNode1.receive({payload:2,topic:"A"}); delayNode1.receive({payload:1,topic:"B"}); // and something else with a fixed topic
delayNode1.receive({payload:3,topic:"A"}); // should get this delayNode1.receive({payload:2,topic:"A"}); // these should replace them in queue
delayNode1.receive({payload:2}); // and this delayNode1.receive({payload:3,topic:"A"}); // ditto
setTimeout( function() { delayNode1.receive({payload:2}); // so all should go on first tick
delayNode1.receive({payload:"Biscuit"}); // and then this delayNode1.receive({payload:4,topic:"A"}); // and nothing on second
},2000);
}); });
}); });
}); });

14
test/nodes/core/storage/50-file_spec.js
View File

@ -71,13 +71,17 @@ describe('file Nodes', function() {
n1.emit("input", {payload:"test2"}); // string n1.emit("input", {payload:"test2"}); // string
setTimeout(function() { setTimeout(function() {
n1.emit("input", {payload:true}); // boolean n1.emit("input", {payload:true}); // boolean
n1.emit("input", {payload:1}); },30);
n1.emit("input", {payload:[2]}); setTimeout(function() {
},50); n1.emit("input", {payload:999}); // number
},60);
setTimeout(function() {
n1.emit("input", {payload:[2]}); // object (array)
},90);
setTimeout(function() { setTimeout(function() {
var f = fs.readFileSync(fileToTest).toString(); var f = fs.readFileSync(fileToTest).toString();
f.should.have.length(17); f.should.have.length(19);
f.should.equal("test2\ntrue\n1\n[2]\n"); f.should.equal("test2\ntrue\n999\n[2]\n");
done(); done();
},wait); },wait);
}); });