From b364f8f9b687aa005f2fd32a0fd1025e69693080 Mon Sep 17 00:00:00 2001
From: Nick O'Leary <nick.oleary@gmail.com>
Date: Fri, 4 Jul 2025 14:59:58 +0100
Subject: [PATCH] Handle deprecated calls to child_process with args

---
 .../@node-red/nodes/core/function/90-exec.js           |  8 +++++++-
 .../node_modules/@node-red/registry/lib/installer.js   |  5 +++--
 .../lib/storage/localfilesystem/projects/git/index.js  |  1 +
 packages/node_modules/@node-red/util/lib/exec.js       | 10 +++++++++-
 4 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/packages/node_modules/@node-red/nodes/core/function/90-exec.js b/packages/node_modules/@node-red/nodes/core/function/90-exec.js
index 23d94059e..02a908d4b 100644
--- a/packages/node_modules/@node-red/nodes/core/function/90-exec.js
+++ b/packages/node_modules/@node-red/nodes/core/function/90-exec.js
@@ -91,7 +91,13 @@ module.exports = function(RED) {
                     const opts = isWindows ? { ...node.spawnOpt, shell: true } : node.spawnOpt
                     /* istanbul ignore else  */
                     node.debug(cmd+" ["+arg+"]");
-                    child = spawn(cmd,arg,opts);
+                    if (opts.shell) {
+                        // When called with shell: true, passing in separate args is deprecated in Node 24
+                        // so we need to join the command and args into a single string.
+                        child = spawn([cmd].concat(arg).join(" "), opts);
+                    } else {
+                        child = spawn(cmd,arg,opts);
+                    }
                     node.status({fill:"blue",shape:"dot",text:"pid:"+child.pid});
                     var unknownCommand = (child.pid === undefined);
                     if (node.timer !== 0) {
diff --git a/packages/node_modules/@node-red/registry/lib/installer.js b/packages/node_modules/@node-red/registry/lib/installer.js
index 3ffd65513..2d8cfe193 100644
--- a/packages/node_modules/@node-red/registry/lib/installer.js
+++ b/packages/node_modules/@node-red/registry/lib/installer.js
@@ -367,9 +367,10 @@ async function getModuleVersionFromNPM(module, version) {
     if (version) {
         installName += "@" + version;
     }
+    
 
     return new Promise((resolve, reject) => {
-        child_process.execFile(npmCommand,['info','--json',installName],{ shell: true },function(err,stdout,stderr) {
+        child_process.execFile(`${npmCommand} info --json ${installName}`, { shell: true },function(err,stdout,stderr) {
             try {
                 if (!stdout) {
                     log.warn(log._("server.install.install-failed-not-found",{name:module}));
@@ -595,7 +596,7 @@ async function checkPrereq() {
         installerEnabled = false;
     } else {
         return new Promise(resolve => {
-            child_process.execFile(npmCommand,['-v'],{ shell: true },function(err,stdout) {
+            child_process.execFile(`${npmCommand} -v`,{ shell: true },function(err,stdout) {
                 if (err) {
                     log.info(log._("server.palette-editor.npm-not-found"));
                     installerEnabled = false;
diff --git a/packages/node_modules/@node-red/runtime/lib/storage/localfilesystem/projects/git/index.js b/packages/node_modules/@node-red/runtime/lib/storage/localfilesystem/projects/git/index.js
index 983b4ca52..c7eec746b 100644
--- a/packages/node_modules/@node-red/runtime/lib/storage/localfilesystem/projects/git/index.js
+++ b/packages/node_modules/@node-red/runtime/lib/storage/localfilesystem/projects/git/index.js
@@ -417,6 +417,7 @@ module.exports = {
                 log.trace("git init: "+JSON.stringify(result));
                 resolve(result);
             }).catch(function(err) {
+                console.log(err)
                 log.trace("git init: git not found");
                 resolve(null);
             });
diff --git a/packages/node_modules/@node-red/util/lib/exec.js b/packages/node_modules/@node-red/util/lib/exec.js
index 15b81aa89..6345438a6 100644
--- a/packages/node_modules/@node-red/util/lib/exec.js
+++ b/packages/node_modules/@node-red/util/lib/exec.js
@@ -57,7 +57,15 @@ module.exports = {
         return new Promise((resolve, reject) => {
             let stdout = "";
             let stderr = "";
-            const child = child_process.spawn(command,args,options);
+            let child
+            if (args && options.shell) {
+                // If we are using a shell, we need to join the args into a single string
+                // as passing a separate array of args is deprecated in Node 24
+                command = [command].concat(args).join(" ");
+                child = child_process.spawn(command, options)
+            } else {
+                child = child_process.spawn(command, args, options);
+            }
             child.stdout.on('data', (data) => {
                 const str = ""+data;
                 stdout += str;