frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent the callback to be called twice

Browse Source 
and add test cases
This commit is contained in:
HirokiUchikawa
2018-07-12 18:12:30 +09:00
parent 2a287b2ae6
commit ba18b27371
2 changed files with 140 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
red/runtime/nodes/context/memory.js
View File

@@ -30,19 +30,24 @@ Memory.prototype.close = function(){
Memory.prototype.get = function(scope, key, callback) {
var value;
var error;
try{
if(this.data[scope]){
value = util.getMessageProperty(this.data[scope], key);
}
}catch(err){
if(callback){
callback(err);
error = err;
}else{
throw err;
}
}
if(callback){
callback(null, value);
if(error){
callback(error);
} else {
callback(null, value);
}
} else {
return value;
}
@@ -52,22 +57,24 @@ Memory.prototype.set =function(scope, key, value, callback) {
if(!this.data[scope]){
this.data[scope] = {};
}
var error;
try{
util.setMessageProperty(this.data[scope],key,value);
}catch(err){
if(callback){
callback(err);
error = err;
}else{
throw err;
}
}
if(callback){
callback(null);
callback(error || null);
}
};
Memory.prototype.keys = function(scope, callback){
var values = [];
var error;
try{
if(this.data[scope]){
if (scope !== "global") {
@@ -80,13 +87,17 @@ Memory.prototype.keys = function(scope, callback){
}
}catch(err){
if(callback){
callback(err);
error = err;
}else{
throw err;
}
}
if(callback){
callback(null, values);
if(error){
callback(error);
} else {
callback(null, values);
}
} else {
return values;
}