frodovdr
/
node-red
mirror of https://github.com/node-red/node-red.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix externalModules tests

This commit is contained in:
Nick O'Leary 2021-07-14 23:38:46 +01:00
parent ddb715d88d
commit bb80fa4a2d
No known key found for this signature in database
GPG Key ID: 4F2157149161A6C9
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
test/unit/@node-red/registry/lib/externalModules_spec.js
View File

@ -67,7 +67,7 @@ describe("externalModules api", function() {
exec.run.restore(); exec.run.restore();
}) })
it("does nothing when no types are registered",async function() { it("does nothing when no types are registered",async function() {
externalModules.init({userDir: homeDir}); externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}});
await externalModules.checkFlowDependencies([ await externalModules.checkFlowDependencies([
{type: "function", libs:[{module: "foo"}]} {type: "function", libs:[{module: "foo"}]}
]) ])
@ -75,7 +75,7 @@ describe("externalModules api", function() {
}); });
it("skips install for modules already installed", async function() { it("skips install for modules already installed", async function() {
externalModules.init({userDir: homeDir}); externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}});
externalModules.register("function", "libs"); externalModules.register("function", "libs");
await setupExternalModulesPackage({"foo": "1.2.3", "bar":"2.3.4"}); await setupExternalModulesPackage({"foo": "1.2.3", "bar":"2.3.4"});
await externalModules.checkFlowDependencies([ await externalModules.checkFlowDependencies([
@ -85,7 +85,7 @@ describe("externalModules api", function() {
}) })
it("skips install for built-in modules", async function() { it("skips install for built-in modules", async function() {
externalModules.init({userDir: homeDir}); externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}});
externalModules.register("function", "libs"); externalModules.register("function", "libs");
await externalModules.checkFlowDependencies([ await externalModules.checkFlowDependencies([
{type: "function", libs:[{module: "fs"}]} {type: "function", libs:[{module: "fs"}]}
@ -94,7 +94,7 @@ describe("externalModules api", function() {
}) })
it("installs missing modules", async function() { it("installs missing modules", async function() {
externalModules.init({userDir: homeDir}); externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}});
externalModules.register("function", "libs"); externalModules.register("function", "libs");
await externalModules.checkFlowDependencies([ await externalModules.checkFlowDependencies([
{type: "function", libs:[{module: "foo"}]} {type: "function", libs:[{module: "foo"}]}
@ -104,7 +104,7 @@ describe("externalModules api", function() {
it("calls pre/postInstall hooks", async function() { it("calls pre/postInstall hooks", async function() {
externalModules.init({userDir: homeDir}); externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}});
externalModules.register("function", "libs"); externalModules.register("function", "libs");
let receivedPreEvent,receivedPostEvent; let receivedPreEvent,receivedPostEvent;
hooks.add("preInstall", function(event) { event.args = ["a"]; receivedPreEvent = event; }) hooks.add("preInstall", function(event) { event.args = ["a"]; receivedPreEvent = event; })
@ -122,7 +122,7 @@ describe("externalModules api", function() {
}) })
it("skips npm install if preInstall returns false", async function() { it("skips npm install if preInstall returns false", async function() {
externalModules.init({userDir: homeDir}); externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}});
externalModules.register("function", "libs"); externalModules.register("function", "libs");
let receivedPreEvent,receivedPostEvent; let receivedPreEvent,receivedPostEvent;
hooks.add("preInstall", function(event) { receivedPreEvent = event; return false }) hooks.add("preInstall", function(event) { receivedPreEvent = event; return false })
@ -140,7 +140,7 @@ describe("externalModules api", function() {
it("installs missing modules from inside subflow module", async function() { it("installs missing modules from inside subflow module", async function() {
externalModules.init({userDir: homeDir}); externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}});
externalModules.register("function", "libs"); externalModules.register("function", "libs");
externalModules.registerSubflow("sf", {"flow":[{type: "function", libs:[{module: "foo"}]}]}); externalModules.registerSubflow("sf", {"flow":[{type: "function", libs:[{module: "foo"}]}]});
await externalModules.checkFlowDependencies([ await externalModules.checkFlowDependencies([
@ -150,7 +150,7 @@ describe("externalModules api", function() {
}) })
it("reports install fail - 404", async function() { it("reports install fail - 404", async function() {
externalModules.init({userDir: homeDir}); externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}});
externalModules.register("function", "libs"); externalModules.register("function", "libs");
try { try {
await externalModules.checkFlowDependencies([ await externalModules.checkFlowDependencies([
@ -169,7 +169,7 @@ describe("externalModules api", function() {
} }
}) })
it("reports install fail - target", async function() { it("reports install fail - target", async function() {
externalModules.init({userDir: homeDir}); externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}});
externalModules.register("function", "libs"); externalModules.register("function", "libs");
try { try {
await externalModules.checkFlowDependencies([ await externalModules.checkFlowDependencies([
@ -188,7 +188,7 @@ describe("externalModules api", function() {
}) })
it("reports install fail - unexpected", async function() { it("reports install fail - unexpected", async function() {
externalModules.init({userDir: homeDir}); externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}});
externalModules.register("function", "libs"); externalModules.register("function", "libs");
try { try {
await externalModules.checkFlowDependencies([ await externalModules.checkFlowDependencies([
@ -206,7 +206,7 @@ describe("externalModules api", function() {
} }
}) })
it("reports install fail - multiple", async function() { it("reports install fail - multiple", async function() {
externalModules.init({userDir: homeDir}); externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}});
externalModules.register("function", "libs"); externalModules.register("function", "libs");
try { try {
await externalModules.checkFlowDependencies([ await externalModules.checkFlowDependencies([
@ -233,7 +233,7 @@ describe("externalModules api", function() {
} }
}) })
it("reports install fail - install disabled", async function() { it("reports install fail - install disabled", async function() {
externalModules.init({userDir: homeDir, externalModules: { externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}, externalModules: {
modules: { modules: {
allowInstall: false allowInstall: false
} }
@ -257,7 +257,7 @@ describe("externalModules api", function() {
}) })
it("reports install fail - module disallowed", async function() { it("reports install fail - module disallowed", async function() {
externalModules.init({userDir: homeDir, externalModules: { externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}, externalModules: {
modules: { modules: {
denyList: ['foo'] denyList: ['foo']
} }
@ -282,7 +282,7 @@ describe("externalModules api", function() {
}) })
it("reports install fail - built-in module disallowed", async function() { it("reports install fail - built-in module disallowed", async function() {
externalModules.init({userDir: homeDir, externalModules: { externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}, externalModules: {
modules: { modules: {
denyList: ['fs'] denyList: ['fs']
} }
@ -308,12 +308,12 @@ describe("externalModules api", function() {
}) })
describe("require", async function() { describe("require", async function() {
it("requires built-in modules", async function() { it("requires built-in modules", async function() {
externalModules.init({userDir: homeDir}); externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}});
const result = externalModules.require("fs") const result = externalModules.require("fs")
result.should.eql(require("fs")); result.should.eql(require("fs"));
}) })
it("rejects unknown modules", async function() { it("rejects unknown modules", async function() {
externalModules.init({userDir: homeDir}); externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}});
try { try {
externalModules.require("foo") externalModules.require("foo")
throw new Error("require did not reject after fail") throw new Error("require did not reject after fail")
@ -323,7 +323,7 @@ describe("externalModules api", function() {
}) })
it("rejects disallowed modules", async function() { it("rejects disallowed modules", async function() {
externalModules.init({userDir: homeDir, externalModules: { externalModules.init({userDir: homeDir, get:()=>{}, set:()=>{}, externalModules: {
modules: { modules: {
denyList: ['fs'] denyList: ['fs']
} }