frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added logic to fix the org variable if its been changed

Browse Source
This commit is contained in:
Steve Walsh
2021-07-12 12:47:48 +01:00
parent edae03e20e
commit d2a045a237
4 changed files with 253 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

279
test/unit/test-payloadValidator.js
View File

@@ -1,142 +1,192 @@
const PayloadValidator = require('../../nodes/PayloadValidator')
const orgEvent = require('./fixtures/data/orgEvent')
const sinon = require('sinon');
const assert = require('assert');
const PayloadValidator = require('../../nodes/PayloadValidator');
const orgEvent = require('./fixtures/data/orgEvent');
describe.only('Unit: PayloadValidator', () => {
describe('Unit: PayloadValidator', () => {
it('Should not log when no changes', () => {
const nodeId = 'abc-id'
const workerId = 'worker-id'
const nodeId = 'abc-id';
const workerId = 'worker-id';
const beforeEvent = orgEvent('before', workerId);
const payloadValidator = new PayloadValidator(beforeEvent, `before-${workerId}-${nodeId}`);
payloadValidator.verify(beforeEvent);
});
it('Should warn when org is overwritten', () => {
const nodeId = 'abc-id'
const workerId = 'worker-id'
it('Should warn when org is overwritten and fix it', () => {
const nodeId = 'abc-id';
const workerId = 'worker-id';
const beforeEvent = orgEvent('before', workerId);
errorLogStub = sinon.stub();
appLogStub = sinon.stub();
const errorLogStub = sinon.stub();
const appLogStub = sinon.stub();
beforeEvent.logger.error = errorLogStub;
beforeEvent.logger.app = {
platform:{
platform: {
organization: appLogStub
}
};
const payloadValidator = new PayloadValidator(beforeEvent, `before-${workerId}-${nodeId}`);
const modifiedEvent = orgEvent('after');
payloadValidator.verify(modifiedEvent);
assert(errorLogStub.callCount === 4)
assert(appLogStub.callCount === 4)
const [[log1], [log2], [log3], [log4]] = appLogStub.args
assert(log1.details.message.includes('logger.metadata.organization'))
assert.strictEqual(log1.details.nodeId, nodeId)
assert.strictEqual(log1.details.workerId, workerId)
assert(log2.details.message.includes('payload.system.organization'))
assert.strictEqual(log2.details.nodeId, nodeId)
assert.strictEqual(log2.details.workerId, workerId)
assert(log3.details.message.includes('event.event.organization'))
assert.strictEqual(log3.details.nodeId, nodeId)
assert.strictEqual(log3.details.workerId, workerId)
assert(log4.details.message.includes('event.event.token.contents.organization'))
assert.strictEqual(log4.details.nodeId, nodeId)
assert.strictEqual(log4.details.workerId, workerId)
const result = payloadValidator.verify(modifiedEvent);
assert(errorLogStub.callCount === 4);
assert(appLogStub.callCount === 4);
const [[log1], [log2], [log3], [log4]] = appLogStub.args;
assert(log1.details.message.includes('logger.metadata.organization'));
assert.strictEqual(log1.details.nodeId, nodeId);
assert.strictEqual(log1.details.workerId, workerId);
assert(log2.details.message.includes('payload.system.organization'));
assert.strictEqual(log2.details.nodeId, nodeId);
assert.strictEqual(log2.details.workerId, workerId);
assert(log3.details.message.includes('event.event.organization'));
assert.strictEqual(log3.details.nodeId, nodeId);
assert.strictEqual(log3.details.workerId, workerId);
assert(log4.details.message.includes('event.event.token.contents.organization'));
assert.strictEqual(log4.details.nodeId, nodeId);
assert.strictEqual(log4.details.workerId, workerId);
// deleting due to sinon funness
delete result.logger.error;
delete result.logger.app;
delete beforeEvent.logger.error;
delete beforeEvent.logger.app;
assert.deepStrictEqual(result, beforeEvent);
});
it('Should warn when org is deleted', () => {
const nodeId = 'abc-id'
const workerId = 'worker-id'
it('Should warn when org is deleted and fix it', () => {
const nodeId = 'abc-id';
const workerId = 'worker-id';
const beforeEvent = orgEvent('before', workerId);
errorLogStub = sinon.stub();
appLogStub = sinon.stub();
const errorLogStub = sinon.stub();
const appLogStub = sinon.stub();
beforeEvent.logger.error = errorLogStub;
beforeEvent.logger.app = {
platform:{
platform: {
organization: appLogStub
}
};
const payloadValidator = new PayloadValidator(beforeEvent, `before-${workerId}-${nodeId}`);
delete beforeEvent.logger.metadata.organization;
delete beforeEvent.payload.system.organization;
delete beforeEvent.event.event.organization;
delete beforeEvent.event.event.token.contents.organization;
payloadValidator.verify(beforeEvent);
assert(errorLogStub.callCount === 4)
assert(appLogStub.callCount === 4)
const [[log1], [log2], [log3], [log4]] = appLogStub.args
assert(log1.details.message.includes('logger.metadata.organization'))
assert.strictEqual(log1.details.nodeId, nodeId)
assert.strictEqual(log1.details.workerId, workerId)
assert(log2.details.message.includes('payload.system.organization'))
assert.strictEqual(log2.details.nodeId, nodeId)
assert.strictEqual(log2.details.workerId, workerId)
assert(log3.details.message.includes('event.event.organization'))
assert.strictEqual(log3.details.nodeId, nodeId)
assert.strictEqual(log3.details.workerId, workerId)
assert(log4.details.message.includes('event.event.token.contents.organization'))
assert.strictEqual(log4.details.nodeId, nodeId)
assert.strictEqual(log4.details.workerId, workerId)
const result = payloadValidator.verify(beforeEvent);
assert(errorLogStub.callCount === 4);
assert(appLogStub.callCount === 4);
const [[log1], [log2], [log3], [log4]] = appLogStub.args;
assert(log1.details.message.includes('logger.metadata.organization'));
assert.strictEqual(log1.details.nodeId, nodeId);
assert.strictEqual(log1.details.workerId, workerId);
assert(log2.details.message.includes('payload.system.organization'));
assert.strictEqual(log2.details.nodeId, nodeId);
assert.strictEqual(log2.details.workerId, workerId);
assert(log3.details.message.includes('event.event.organization'));
assert.strictEqual(log3.details.nodeId, nodeId);
assert.strictEqual(log3.details.workerId, workerId);
assert(log4.details.message.includes('event.event.token.contents.organization'));
assert.strictEqual(log4.details.nodeId, nodeId);
assert.strictEqual(log4.details.workerId, workerId);
// deleting due to sinon funness
delete result.logger.error;
delete result.logger.app;
delete beforeEvent.logger.error;
delete beforeEvent.logger.app;
assert.deepStrictEqual(result, beforeEvent);
});
it('Should handle when after is an array', () =>{
const nodeId = 'abc-id'
const workerId = 'worker-id'
it('Should handle when after is an array and not find any issues', () => {
const nodeId = 'abc-id';
const workerId = 'worker-id';
const beforeEvent = orgEvent('before', workerId);
errorLogStub = sinon.stub();
appLogStub = sinon.stub();
const errorLogStub = sinon.stub();
const appLogStub = sinon.stub();
beforeEvent.logger.error = errorLogStub;
beforeEvent.logger.app = {
platform:{
platform: {
organization: appLogStub
}
};
const payloadValidator = new PayloadValidator(beforeEvent, `before-${workerId}-${nodeId}`);
const modifiedEvent = orgEvent('before');
modifiedEvent.logger.metadata.organization = 'after'
payloadValidator.verify([modifiedEvent]);
assert(errorLogStub.callCount === 1)
assert(appLogStub.callCount === 1)
const [[log1]] = appLogStub.args
assert(log1.details.message.includes('logger.metadata.organization'))
assert.strictEqual(log1.details.nodeId, nodeId)
assert.strictEqual(log1.details.workerId, workerId)
})
const after = orgEvent('before');
const [result] = payloadValidator.verify([after]);
// deleting due to sinon funness
delete result.logger.error;
delete result.logger.app;
delete beforeEvent.logger.error;
delete beforeEvent.logger.app;
assert.deepStrictEqual(result, beforeEvent);
});
it('Should handle when after is an array in something other than first position', () =>{
const nodeId = 'abc-id'
const workerId = 'worker-id'
it('Should handle when after is an array', () => {
const nodeId = 'abc-id';
const workerId = 'worker-id';
const beforeEvent = orgEvent('before', workerId);
errorLogStub = sinon.stub();
appLogStub = sinon.stub();
const errorLogStub = sinon.stub();
const appLogStub = sinon.stub();
beforeEvent.logger.error = errorLogStub;
beforeEvent.logger.app = {
platform:{
platform: {
organization: appLogStub
}
};
const payloadValidator = new PayloadValidator(beforeEvent, `before-${workerId}-${nodeId}`);
const modifiedEvent = orgEvent('before');
modifiedEvent.logger.metadata.organization = 'after'
payloadValidator.verify([null, null, modifiedEvent, null]);
assert(errorLogStub.callCount === 1)
assert(appLogStub.callCount === 1)
const [[log1]] = appLogStub.args
assert(log1.details.message.includes('logger.metadata.organization'))
assert.strictEqual(log1.details.nodeId, nodeId)
assert.strictEqual(log1.details.workerId, workerId)
})
modifiedEvent.logger.metadata.organization = 'after';
const [result] = payloadValidator.verify([modifiedEvent]);
assert(errorLogStub.callCount === 1);
assert(appLogStub.callCount === 1);
const [[log1]] = appLogStub.args;
assert(log1.details.message.includes('logger.metadata.organization'));
assert.strictEqual(log1.details.nodeId, nodeId);
assert.strictEqual(log1.details.workerId, workerId);
// deleting due to sinon funness
delete result.logger.error;
delete result.logger.app;
delete beforeEvent.logger.error;
delete beforeEvent.logger.app;
assert.deepStrictEqual(result, beforeEvent);
});
it('Should handle when after is an array in something other than first position', () => {
const nodeId = 'abc-id';
const workerId = 'worker-id';
const beforeEvent = orgEvent('before', workerId);
const errorLogStub = sinon.stub();
const appLogStub = sinon.stub();
beforeEvent.logger.error = errorLogStub;
beforeEvent.logger.app = {
platform: {
organization: appLogStub
}
};
const payloadValidator = new PayloadValidator(beforeEvent, `before-${workerId}-${nodeId}`);
const modifiedEvent = orgEvent('before');
modifiedEvent.logger.metadata.organization = 'after';
const [,, result] = payloadValidator.verify([null, null, modifiedEvent, null]);
assert(errorLogStub.callCount === 1);
assert(appLogStub.callCount === 1);
const [[log1]] = appLogStub.args;
assert(log1.details.message.includes('logger.metadata.organization'));
assert.strictEqual(log1.details.nodeId, nodeId);
assert.strictEqual(log1.details.workerId, workerId);
// deleting due to sinon funness
delete result.logger.error;
delete result.logger.app;
delete beforeEvent.logger.error;
delete beforeEvent.logger.app;
assert.deepStrictEqual(result, beforeEvent);
});
it('Should not die when error', () => {
const beforeEvent = orgEvent('before');
const payloadValidator = new PayloadValidator(beforeEvent);
@@ -155,5 +205,58 @@ describe.only('Unit: PayloadValidator', () => {
payloadValidator.verify({});
});
});
describe('Get Value', () => {
let payloadValidator;
before(() => {
const event = orgEvent('event');
payloadValidator = new PayloadValidator(event);
});
it('Should set a root level variable', () => {
const location = 'hello';
const value = 'world';
const object = {
[location]: value
};
const result = payloadValidator.getValue(object, location);
assert.strictEqual(result, value);
});
it('Should set a nested variable', () => {
const value = 'world';
const object = {
should: {
have: {
hello: value
}
}
};
const location = 'should.have.hello';
const result = payloadValidator.getValue(object, location);
assert.strictEqual(result, value);
});
});
describe('Set Value', () => {
let payloadValidator;
before(() => {
const event = orgEvent('event');
payloadValidator = new PayloadValidator(event);
});
it('Should set a root level variable', () => {
const object = {};
const location = 'hello';
const value = 'world';
const result = payloadValidator.setValue(object, location, value);
assert.strictEqual(result[location], value);
});
it('Should set a nested variable', () => {
const object = {};
const location = 'should.set.hello';
const value = 'world';
const result = payloadValidator.setValue(object, location, value);
assert.strictEqual(result.should.set.hello, value);
});
});
});