From d4a21be6668bac57f3df5e531b92d6016f74b3dd Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Thu, 9 Oct 2014 14:21:53 +0100 Subject: [PATCH] Clone settings to avoid modifying original values --- red/settings.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/red/settings.js b/red/settings.js index 4994953f1..f4301efc0 100644 --- a/red/settings.js +++ b/red/settings.js @@ -15,7 +15,7 @@ **/ var when = require("when"); - +var clone = require("clone"); var assert = require("assert"); var userSettings = null; @@ -45,12 +45,12 @@ var persistentSettings = { }, get: function(prop) { if (userSettings.hasOwnProperty(prop)) { - return userSettings[prop]; + return clone(userSettings[prop]); } if (globalSettings === null) { throw new Error("Settings not available"); } - return globalSettings[prop]; + return clone(globalSettings[prop]); }, set: function(prop,value) {