frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

Fix error handling in Websocket broadcast function

Browse Source 
Fixes #2182
This commit is contained in:
Nick O'Leary 2019-05-28 11:51:34 +01:00
parent d360f30af6
commit d583c68de5
No known key found for this signature in database
GPG Key ID: 4F2157149161A6C9
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
packages/node_modules/@node-red/nodes/core/io/22-websocket.js vendored
View File

@ -194,20 +194,23 @@ module.exports = function(RED) {
} }
WebSocketListenerNode.prototype.broadcast = function(data) { WebSocketListenerNode.prototype.broadcast = function(data) {
try { if (this.isServer) {
if (this.isServer) { for (let client in this._clients) {
for (let client in this._clients) { if (this._clients.hasOwnProperty(client)) {
if (this._clients.hasOwnProperty(client)) { try {
this._clients[client].send(data); this._clients[client].send(data);
} catch(err) {
this.warn(RED._("websocket.errors.send-error")+" "+client+" "+err.toString())
} }
} }
} }
else {
this.server.send(data);
}
} }
catch(e) { // swallow any errors else {
this.warn("ws:"+i+" : "+e); try {
this.server.send(data);
} catch(err) {
this.warn(RED._("websocket.errors.send-error")+" "+err.toString())
}
} }
} }