frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

let setMessageProperty return success flag

Browse Source 
so calling node can warn if operation tries to overwrite primitive type
This commit is contained in:
Dave Conway-Jones
2020-01-26 18:20:25 +00:00
parent 9d4238e5cc
commit d5d9ac5c76
3 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/node_modules/@node-red/util/lib/util.js vendored
View File

@@ -368,10 +368,15 @@ function setObjectProperty(msg,prop,value,createMissing) {
var length = msgPropParts.length;
var obj = msg;
var key;
var flag = true;
for (var i=0;i<length-1;i++) {
key = msgPropParts[i];
if (typeof key === 'string' || (typeof key === 'number' && !Array.isArray(obj))) {
if (obj.hasOwnProperty(key)) {
if (length > 1 && ((typeof obj[key] !== "object" && typeof obj[key] !== "function") || obj[key] === null)) {
//console.log("Can't override primitive type with object.");
flag = false;
}
obj = obj[key];
} else if (createMissing) {
if (typeof msgPropParts[i+1] === 'string') {
@@ -409,8 +414,14 @@ function setObjectProperty(msg,prop,value,createMissing) {
delete obj[key]
}
} else {
obj[key] = value;
if (typeof obj === "object" && obj !== null) {
obj[key] = value;
} else {
//console.log("Can't override primitive type with object.");
flag = false;
}
}
return flag;
}
/*!