From dd89ea3731ffe4831b1f62118091127133a74760 Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Thu, 28 Mar 2019 10:48:48 +0000 Subject: [PATCH] Prevent wire from normal node to link virtual port Fixes #2114 --- .../@node-red/editor-client/src/js/ui/view.js | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/view.js b/packages/node_modules/@node-red/editor-client/src/js/ui/view.js index 4fa6f66dc..75df20c95 100755 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/view.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/view.js @@ -1903,10 +1903,18 @@ RED.view = (function() { } } } else { - var existingLink = RED.nodes.filterLinks({source:src,target:dst,sourcePort: src_port}).length !== 0; - if (!existingLink) { - RED.nodes.addLink(link); - addedLinks.push(link); + // This is not a virtualLink - which means it started + // on a regular node port. Need to ensure the this isn't + // connecting to a link node virual port. + if (!( + (d.type === "link out" && portType === PORT_TYPE_OUTPUT) || + (d.type === "link in" && portType === PORT_TYPE_INPUT) + )) { + var existingLink = RED.nodes.filterLinks({source:src,target:dst,sourcePort: src_port}).length !== 0; + if (!existingLink) { + RED.nodes.addLink(link); + addedLinks.push(link); + } } } }