fix many test problems (#1677)

* fix many test problems

- adds [stoppable](https://npm.im/stoppable) to force-stop net & http
  servers
- upgrades to latest mocha
- much cleanup of servers
- some removal of useless code

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>

* increase wait time to hack at race condition

* PoC with fork of stoppable

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>

* fix custom stoppable url for newer npm

* make travis go faster; attempt to avoid npm troubles

* fix coveralls executable path

* add extra time for flake to trigger spec

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>

test/nodes/core/logic/10-switch_spec.js

@@ -28,8 +28,8 @@ describe('switch Node', function() {
 
     afterEach(function(done) {
         helper.unload();
-        helper.stopServer(done);
         RED.settings.nodeMessageBufferMaxLength = 0;
+        helper.stopServer(done);
     });
 
     it('should be loaded with some defaults', function(done) {

test/nodes/core/logic/15-change_spec.js

@@ -578,7 +578,6 @@ describe('change Node', function() {
         });
 
         it('reports invalid regex', function(done) {
-            var sinon = require('sinon');
             var flow = [{"id":"changeNode1","type":"change","action":"change","property":"payload","from":"\\+**+","to":"NUMBER","reg":true,"name":"changeNode","wires":[["helperNode1"]]},
                         {id:"helperNode1", type:"helper", wires:[]}];
             helper.load(changeNode, flow, function() {

test/nodes/core/logic/16-range_spec.js

@@ -135,11 +135,13 @@ describe('range Node', function() {
             var sinon = require('sinon');
             sinon.stub(rangeNode1, 'log', function(log) {
                 if (log.indexOf("notnumber") > -1) {
+                    rangeNode1.log.restore();
                     done();
                 } else {
                     try {
                         should.fail(null, null, "Non-number inputs should be reported!");
                     } catch (err) {
+                        rangeNode1.log.restore();
                         done(err);
                     }
                 }

test/nodes/core/logic/17-split_spec.js

@@ -26,6 +26,10 @@ describe('SPLIT node', function() {
         helper.startServer(done);
     });
 
+    after(function(done) {
+        helper.stopServer(done);
+    });
+
     afterEach(function() {
         helper.unload();
     });
@@ -268,6 +272,10 @@ describe('JOIN node', function() {
         helper.startServer(done);
     });
 
+    after(function(done) {
+        helper.stopServer(done);
+    });
+
     afterEach(function() {
         helper.unload();
         RED.settings.nodeMessageBufferMaxLength = 0;

test/nodes/core/logic/18-sort_spec.js

@@ -25,6 +25,10 @@ describe('SORT node', function() {
         helper.startServer(done);
     });
 
+    after(function(done) {
+        helper.stopServer(done);
+    });
+
     afterEach(function() {
         helper.unload();
         RED.settings.nodeMessageBufferMaxLength = 0;

test/nodes/core/logic/19-batch_spec.js

@@ -26,6 +26,10 @@ describe('BATCH node', function() {
         helper.startServer(done);
     });
 
+    after(function(done) {
+        helper.stopServer(done);
+    });
+
     afterEach(function() {
         helper.unload();
         RED.settings.nodeMessageBufferMaxLength = 0;