From e2aebaf0e7b17a6d2a1d254fafb839a411174230 Mon Sep 17 00:00:00 2001 From: Dave Conway-Jones Date: Mon, 4 May 2020 14:17:11 +0100 Subject: [PATCH] CSV : add warn when unpaired quotes detected on input. helps handling now that we allow line breaks within fields (as per spec). --- packages/node_modules/@node-red/nodes/core/parsers/70-CSV.js | 2 +- .../node_modules/@node-red/nodes/locales/en-US/messages.json | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/node_modules/@node-red/nodes/core/parsers/70-CSV.js b/packages/node_modules/@node-red/nodes/core/parsers/70-CSV.js index fe39f4c59..5f0cd3e99 100644 --- a/packages/node_modules/@node-red/nodes/core/parsers/70-CSV.js +++ b/packages/node_modules/@node-red/nodes/core/parsers/70-CSV.js @@ -213,7 +213,7 @@ module.exports = function(RED) { } } // Finished so finalize and send anything left - //console.log(j,k,o,k[j]); + if (f === false) { node.warn(RED._("csv.errors.bad_csv")); } if (!node.goodtmpl) { node.template[j] = "col"+(j+1); } if ( node.template[j] && (node.template[j] !== "") ) { diff --git a/packages/node_modules/@node-red/nodes/locales/en-US/messages.json b/packages/node_modules/@node-red/nodes/locales/en-US/messages.json index b5f4474d3..e40d99ea7 100755 --- a/packages/node_modules/@node-red/nodes/locales/en-US/messages.json +++ b/packages/node_modules/@node-red/nodes/locales/en-US/messages.json @@ -725,7 +725,8 @@ }, "errors": { "csv_js": "This node only handles CSV strings or js objects.", - "obj_csv": "No columns template specified for object -> CSV." + "obj_csv": "No columns template specified for object -> CSV.", + "bad_csv": "Malformed CSV file - output probably corrupt." } }, "html": {