1
0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00

better logging of set with no types

This commit is contained in:
Steve-Mcl 2022-09-29 21:28:13 +01:00
parent 6a19d8246c
commit e6b379358a
3 changed files with 11 additions and 7 deletions

View File

@ -185,17 +185,18 @@ function loadNodeConfigs() {
function addModule(module) { function addModule(module) {
moduleNodes[module.name] = []; moduleNodes[module.name] = [];
moduleConfigs[module.name] = module; moduleConfigs[module.name] = module;
for (var setName in module.nodes) { for (const setName in module.nodes) {
if (module.nodes.hasOwnProperty(setName)) { if (module.nodes.hasOwnProperty(setName)) {
var set = module.nodes[setName]; const set = module.nodes[setName];
if(setName === 'lower-case') {
delete set.types
}
if (!set.types) { if (!set.types) {
const err = new Error("Node has no types") const err = new Error("Set has no types")
err.code = "has_no_types" err.code = "set_has_no_types"
err.details = { err.details = {
setName: set.name, ...set
set: { ...set }
} }
console.warn(err)
set.err = err set.err = err
} }
moduleNodes[module.name].push(set.name); moduleNodes[module.name].push(set.name);

View File

@ -161,6 +161,8 @@ function start() {
for (i=0;i<nodeErrors.length;i+=1) { for (i=0;i<nodeErrors.length;i+=1) {
if (nodeErrors[i].err.code === "type_already_registered") { if (nodeErrors[i].err.code === "type_already_registered") {
log.warn("["+nodeErrors[i].id+"] "+log._("server.type-already-registered",{type:nodeErrors[i].err.details.type,module: nodeErrors[i].err.details.moduleA})); log.warn("["+nodeErrors[i].id+"] "+log._("server.type-already-registered",{type:nodeErrors[i].err.details.type,module: nodeErrors[i].err.details.moduleA}));
} else if (nodeErrors[i].err.code === "set_has_no_types") {
log.warn("["+nodeErrors[i].id+"] "+log._("server.set-has-no-types", nodeErrors[i].err.details));
} else { } else {
log.warn("["+nodeErrors[i].id+"] "+nodeErrors[i].err); log.warn("["+nodeErrors[i].id+"] "+nodeErrors[i].err);
} }

View File

@ -20,6 +20,7 @@
"errors-help": "Run with -v for details", "errors-help": "Run with -v for details",
"missing-modules": "Missing node modules:", "missing-modules": "Missing node modules:",
"node-version-mismatch": "Node module cannot be loaded on this version. Requires: __version__ ", "node-version-mismatch": "Node module cannot be loaded on this version. Requires: __version__ ",
"set-has-no-types": "Set does not have any types. name: '__name__', module: '__module__', file: '__file__'",
"type-already-registered": "'__type__' already registered by module __module__", "type-already-registered": "'__type__' already registered by module __module__",
"removing-modules": "Removing modules from config", "removing-modules": "Removing modules from config",
"added-types": "Added node types:", "added-types": "Added node types:",