diff --git a/nodes/core/storage/50-file.js b/nodes/core/storage/50-file.js index 936e2f84f..b9659b2cf 100644 --- a/nodes/core/storage/50-file.js +++ b/nodes/core/storage/50-file.js @@ -75,6 +75,7 @@ module.exports = function(RED) { if (typeof data === "boolean") { data = data.toString(); } if (typeof data === "number") { data = data.toString(); } if ((node.appendNewline) && (!Buffer.isBuffer(data))) { data += os.EOL; } + var buf = Buffer.from(data); if (node.overwriteFile === "true") { var wstream = fs.createWriteStream(filename, { encoding:'binary', flags:'w', autoClose:true }); node.wstream = wstream; @@ -83,7 +84,7 @@ module.exports = function(RED) { done(); }); wstream.on("open", function() { - wstream.end(data, function() { + wstream.end(buf, function() { node.send(msg); done(); }); @@ -132,13 +133,13 @@ module.exports = function(RED) { } if (node.filename) { // Static filename - write and reuse the stream next time - node.wstream.write(data, function() { + node.wstream.write(buf, function() { node.send(msg); done(); }); } else { // Dynamic filename - write and close the stream - node.wstream.end(data, function() { + node.wstream.end(buf, function() { node.send(msg); delete node.wstream; delete node.wstreamIno; diff --git a/test/nodes/core/storage/50-file_spec.js b/test/nodes/core/storage/50-file_spec.js index b60933649..cf6491c42 100644 --- a/test/nodes/core/storage/50-file_spec.js +++ b/test/nodes/core/storage/50-file_spec.js @@ -79,6 +79,29 @@ describe('file Nodes', function() { }); }); + it('should write multi-byte string to a file', function(done) { + var flow = [{id:"fileNode1", type:"file", name: "fileNode", "filename":fileToTest, "appendNewline":false, "overwriteFile":true, wires: [["helperNode1"]]}, + {id:"helperNode1", type:"helper"}]; + helper.load(fileNode, flow, function() { + var n1 = helper.getNode("fileNode1"); + var n2 = helper.getNode("helperNode1"); + n2.on("input", function(msg) { + try { + var f = fs.readFileSync(fileToTest).toString(); + f.should.have.length(2); + f.should.equal("試験"); + fs.unlinkSync(fileToTest); + msg.should.have.property("payload", "試験"); + done(); + } + catch (e) { + done(e); + } + }); + n1.receive({payload:"試験"}); + }); + }); + it('should append to a file and add newline', function(done) { var flow = [{id:"fileNode1", type:"file", name: "fileNode", "filename":fileToTest, "appendNewline":true, "overwriteFile":false, wires: [["helperNode1"]]}, {id:"helperNode1", type:"helper"}];