From f0193b0f67d750ab88d6bb44ce86468dfd509d54 Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Tue, 2 Jun 2020 22:52:22 +0100 Subject: [PATCH] Add better messages for 404 errors on admin api --- .../node_modules/@node-red/runtime/lib/api/nodes.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/node_modules/@node-red/runtime/lib/api/nodes.js b/packages/node_modules/@node-red/runtime/lib/api/nodes.js index fb16cc631..7624b0b76 100644 --- a/packages/node_modules/@node-red/runtime/lib/api/nodes.js +++ b/packages/node_modules/@node-red/runtime/lib/api/nodes.js @@ -62,7 +62,7 @@ var api = module.exports = { return resolve(result); } else { runtime.log.audit({event: "nodes.info.get",id:id,error:"not_found"}, opts.req); - var err = new Error(); + var err = new Error("Node not found"); err.code = "not_found"; err.status = 404; return reject(err); @@ -105,7 +105,7 @@ var api = module.exports = { return resolve(result); } else { runtime.log.audit({event: "nodes.config.get",id:id,error:"not_found"}, opts.req); - var err = new Error(); + var err = new Error("Node not found"); err.code = "not_found"; err.status = 404; return reject(err); @@ -145,7 +145,7 @@ var api = module.exports = { return resolve(result); } else { runtime.log.audit({event: "nodes.module.get",id:opts.module,error:"not_found"}, opts.req); - var err = new Error(); + var err = new Error("Module not found"); err.code = "not_found"; err.status = 404; return reject(err); @@ -232,7 +232,7 @@ var api = module.exports = { var module = runtime.nodes.getModuleInfo(opts.module); if (!module) { runtime.log.audit({event: "nodes.remove",module:opts.module,error:"not_found"}, opts.req); - var err = new Error(); + var err = new Error("Module not found"); err.code = "not_found"; err.status = 404; return reject(err); @@ -278,7 +278,7 @@ var api = module.exports = { var module = runtime.nodes.getModuleInfo(mod); if (!module) { runtime.log.audit({event: "nodes.module.set",module:mod,error:"not_found"}, opts.req); - var err = new Error(); + var err = new Error("Module not found"); err.code = "not_found"; err.status = 404; return reject(err); @@ -329,7 +329,7 @@ var api = module.exports = { var node = runtime.nodes.getNodeInfo(id); if (!node) { runtime.log.audit({event: "nodes.info.set",id:id,error:"not_found"}, opts.req); - var err = new Error(); + var err = new Error("Node not found"); err.code = "not_found"; err.status = 404; return reject(err);