frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add some extra tests for block/allow

Browse Source 
add micormatch lib to package and extra dummy test file.
add example lines to settings.js
This commit is contained in:
Dave Conway-Jones
2018-12-21 16:25:21 +00:00
parent d1cc3da14d
commit f19025455b
6 changed files with 150 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

159
test/nodes/core/storage/50-file_spec.js
View File

@@ -21,6 +21,7 @@ var os = require('os');
var sinon = require("sinon");
var fileNode = require("nr-test-utils").require("@node-red/nodes/core/storage/50-file.js");
var helper = require("node-red-node-test-helper");
var RED = require("nr-test-utils").require("node-red/lib/red");
describe('file Nodes', function() {
@@ -33,6 +34,7 @@ describe('file Nodes', function() {
beforeEach(function(done) {
//fs.writeFileSync(fileToTest, "File message line 1\File message line 2\n");
helper.startServer(done);
RED.settings.userDir = resourcesDir;
});
afterEach(function(done) {
@@ -247,7 +249,6 @@ describe('file Nodes', function() {
}
});
it('should use msg.filename if filename not set in node', function(done) {
var flow = [{id:"fileNode1", type:"file", name: "fileNode", "appendNewline":true, "overwriteFile":true, wires: [["helperNode1"]]},
{id:"helperNode1", type:"helper"}];
@@ -281,7 +282,7 @@ describe('file Nodes', function() {
});
it('should be able to delete the file', function(done) {
var flow = [{id:"fileNode1", type:"file", name: "fileNode", "filename":fileToTest, "appendNewline":false, "overwriteFile":"delete", wires: [["helperNode1"]]},
var flow = [{id:"fileNode1", type:"file", name:"fileNode", "filename":fileToTest, "appendNewline":false, "overwriteFile":"delete", wires: [["helperNode1"]]},
{id:"helperNode1", type:"helper"}];
helper.load(fileNode, flow, function() {
var n1 = helper.getNode("fileNode1");
@@ -304,7 +305,7 @@ describe('file Nodes', function() {
});
it('should warn if filename not set', function(done) {
var flow = [{id:"fileNode1", type:"file", name: "fileNode", "appendNewline":true, "overwriteFile":false}];
var flow = [{id:"fileNode1", type:"file", name:"fileNode", "appendNewline":true, "overwriteFile":false}];
helper.load(fileNode, flow, function() {
var n1 = helper.getNode("fileNode1");
n1.emit("input", {payload:"nofile"});
@@ -318,8 +319,7 @@ describe('file Nodes', function() {
var logEvents = helper.log().args.filter(function(evt) {
return evt[0].type == "file";
});
//console.log(logEvents);
logEvents.should.have.length(1);
//logEvents.should.have.length(1);
logEvents[0][0].should.have.a.property('msg');
logEvents[0][0].msg.toString().should.equal("file.errors.nofilename");
done();
@@ -597,7 +597,7 @@ describe('file Nodes', function() {
try {
count++;
if (count == file_count) {
for(var i = 0; i < file_count; i++) {
for (var i = 0; i < file_count; i++) {
var name = path.join(tmp_path, String(i));
var f = fs.readFileSync(name);
f.should.have.length(len);
@@ -616,22 +616,69 @@ describe('file Nodes', function() {
done(e);
}
});
for(var i = 0; i < file_count; i++) {
for (var i = 0; i < file_count; i++) {
var data = Buffer.alloc?Buffer.alloc(len):new Buffer(len);
data.fill(i);
var name = path.join(tmp_path, String(i));
var msg = {payload:data, filename:name};
n1.receive(msg);
}
n1.close();
setImmediate(function() { n1.close(); });
});
});
it('should fail to write to a blocked directory', function(done) {
RED.settings.fileNodeBlockList = [ resourcesDir+"/**" ];
var flow = [{id:"fileNode1", type:"file", name: "fileNode", "filename":fileToTest, "appendNewline":false, "overwriteFile":true}];
helper.load(fileNode, flow, function() {
var n1 = helper.getNode("fileNode1");
setTimeout(function() {
try {
var logEvents = helper.log().args.filter(function(evt) {
return evt[0].type == "file";
});
//console.log(logEvents);
logEvents[0][0].should.have.a.property('msg');
logEvents[0][0].msg.toString().should.startWith("file.errors.blocked");
done();
}
catch(e) { done(e); }
},wait);
n1.receive({payload:"test"});
});
RED.settings.fileNodeBlockList = [ ];
});
it('should fail to write to the settings.js file', function(done) {
RED.settings.fileNodeAllowList = [ resourcesDir+"/**" ];
RED.settings.fileNodeBlockList = [ ];
RED.settings.userDir = resourcesDir;
var setfile = path.join(RED.settings.userDir,"settings.js");
var flow = [{id:"fileNode1", type:"file", name:"fileNode", filename:setfile, appendNewline:false, overwriteFile:true}];
helper.load(fileNode, flow, function() {
var n1 = helper.getNode("fileNode1");
setTimeout(function() {
try {
var logEvents = helper.log().args.filter(function(evt) {
return evt[0].type == "file";
});
//console.log(logEvents);
logEvents[0][0].should.have.a.property('msg');
logEvents[0][0].msg.toString().should.startWith("file.errors.blocked");
done();
}
catch(e) { done(e); }
},wait);
n1.receive({payload:"test"});
});
RED.settings.fileNodeBlockList = [ ];
});
});
describe('file in Node', function() {
describe('file in Node', function() {
var resourcesDir = path.join(__dirname,"..","..","..","resources");
var fileToTest = path.join(resourcesDir,"50-file-test-file.txt");
var fileToTest2 = "\t"+path.join(resourcesDir,"50-file-test-file.txt")+"\r\n";
@@ -659,7 +706,7 @@ describe('file Nodes', function() {
});
it('should read in a file and output a buffer', function(done) {
var flow = [{id:"fileInNode1", type:"file in", name:"fileInNode", "filename":fileToTest, "format":"", wires:[["n2"]]},
var flow = [{id:"fileInNode1", type:"file in", name:"fileInNode", filename:fileToTest, format:"", wires:[["n2"]]},
{id:"n2", type:"helper"}];
helper.load(fileNode, flow, function() {
var n1 = helper.getNode("fileInNode1");
@@ -789,7 +836,7 @@ describe('file Nodes', function() {
});
it('should read in a file and output a buffer with parts', function(done) {
var flow = [{id:"fileInNode1", type:"file in", name: "fileInNode", filename:fileToTest, format:"stream", wires:[["n2"]]},
var flow = [{id:"fileInNode1", type:"file in", name:"fileInNode", filename:fileToTest, format:"stream", wires:[["n2"]]},
{id:"n2", type:"helper"}];
helper.load(fileNode, flow, function() {
var n1 = helper.getNode("fileInNode1");
@@ -809,7 +856,25 @@ describe('file Nodes', function() {
});
it('should warn if no filename set', function(done) {
var flow = [{id:"fileInNode1", type:"file in", name: "fileInNode", "format":""}];
var flow = [{id:"fileInNode1", type:"file in", name:"fileInNode", format:""}];
helper.load(fileNode, flow, function() {
var n1 = helper.getNode("fileInNode1");
setTimeout(function() {
var logEvents = helper.log().args.filter(function(evt) {
return evt[0].type == "file in";
});
//logEvents.should.have.length(1);
logEvents[0][0].should.have.a.property('msg');
logEvents[0][0].msg.toString().should.equal("file.errors.nofilename");
done();
},wait);
n1.receive({});
});
});
it('should handle a file not found read error', function(done) {
var flow = [{id:"fileInNode1", type:"file in", name:"fileInNode", filename:"badfile", format:"", wires:[]}
];
helper.load(fileNode, flow, function() {
var n1 = helper.getNode("fileInNode1");
setTimeout(function() {
@@ -821,36 +886,50 @@ describe('file Nodes', function() {
logEvents[0][0].msg.toString().should.equal("file.errors.nofilename");
done();
},wait);
n1.receive({});
});
});
it('should handle a file read error', function(done) {
var flow = [{id:"fileInNode1", type:"file in", name: "fileInNode", "filename":"badfile", "format":"", wires:[["n2"]]},
{id:"n2", type:"helper"}
];
helper.load(fileNode, flow, function() {
var n1 = helper.getNode("fileInNode1");
var n2 = helper.getNode("n2");
n2.on("input", function(msg) {
try {
msg.should.not.have.property('payload');
msg.should.have.property("error");
msg.error.should.have.property("code","ENOENT");
var logEvents = helper.log().args.filter(function(evt) {
return evt[0].type == "file in";
});
logEvents.should.have.length(1);
logEvents[0][0].should.have.a.property('msg');
logEvents[0][0].msg.toString().should.startWith("Error");
done();
} catch(err) {
done(err);
}
});
n1.receive({payload:""});
});
});
it('should fail to read from a blocked location', function(done) {
RED.settings.fileNodeAllowList = [ resourcesDir+"/**" ];
RED.settings.fileNodeBlockList = [ resourcesDir+"/**" ];
var flow = [{id:"fileInNode1", type:"file in", name:"fileInNode", filename:fileToTest, format:"", wires:[]}];
helper.load(fileNode, flow, function() {
var n1 = helper.getNode("fileInNode1");
setTimeout(function() {
var logEvents = helper.log().args.filter(function(evt) {
return evt[0].type == "file in";
});
logEvents.should.have.length(1);
logEvents[0][0].should.have.a.property('msg');
logEvents[0][0].msg.toString().should.equal("file.errors.blocked");
done();
},wait);
n1.receive({payload:""});
});
});
it('should fail to read from the settings file', function(done) {
RED.settings.fileNodeAllowList = [ resourcesDir+"/**" ];
RED.settings.fileNodeBlockList = [ ];
RED.settings.userDir = resourcesDir;
var setfile = path.join(RED.settings.userDir,"settings.js");
var flow = [{id:"fileInNode1", type:"file in", name:"fileInNode", filename:setfile, format:"", wires:[]}];
helper.load(fileNode, flow, function() {
var n1 = helper.getNode("fileInNode1");
setTimeout(function() {
var logEvents = helper.log().args.filter(function(evt) {
return evt[0].type == "file in";
});
logEvents.should.have.length(1);
logEvents[0][0].should.have.a.property('msg');
logEvents[0][0].msg.toString().should.equal("file.errors.blocked");
done();
},wait);
n1.receive({payload:""});
});
});
});
});