From f21260370f161704ab053454f157590b7018f9da Mon Sep 17 00:00:00 2001 From: Kazuki-Nakanishi Date: Thu, 22 Feb 2018 14:10:31 +0900 Subject: [PATCH] Fixed the problems when using a node without defaults --- editor/js/history.js | 2 +- editor/js/ui/editor.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/editor/js/history.js b/editor/js/history.js index ac155bd88..12650c9a2 100644 --- a/editor/js/history.js +++ b/editor/js/history.js @@ -191,7 +191,7 @@ RED.history = (function() { } else if (ev.t == "edit") { for (i in ev.changes) { if (ev.changes.hasOwnProperty(i)) { - if (ev.node._def.defaults[i] && ev.node._def.defaults[i].type) { + if (ev.node._def.defaults && ev.node._def.defaults[i] && ev.node._def.defaults[i].type) { // This is a config node property var currentConfigNode = RED.nodes.node(ev.node[i]); if (currentConfigNode) { diff --git a/editor/js/ui/editor.js b/editor/js/ui/editor.js index c14b81fef..c3f0d4ea5 100644 --- a/editor/js/ui/editor.js +++ b/editor/js/ui/editor.js @@ -742,7 +742,7 @@ RED.editor = (function() { buildLabelRow().appendTo(outputsDiv); } - if (!node._def.defaults.hasOwnProperty("icon") && node.type !== "subflow") { + if ((!node._def.defaults || !node._def.defaults.hasOwnProperty("icon")) && node.type !== "subflow") { $('
').appendTo(dialogForm); var iconDiv = $("#node-settings-icon"); $('