From f3040ae95ceb9b9229b74b3925e6c6e308c8288f Mon Sep 17 00:00:00 2001
From: Dave C-J <dave@conway-jones.co.uk>
Date: Wed, 16 Oct 2013 19:04:32 +0100
Subject: [PATCH] Add warning to Arduino node (as underlying firmata won't
 allow pins to be both inputas and outputs at the same time)

---
 nodes/hardware/35-arduino.html |  28 ++--
 nodes/hardware/35-arduino.js   | 292 +++++++++++++++++----------------
 2 files changed, 166 insertions(+), 154 deletions(-)

diff --git a/nodes/hardware/35-arduino.html b/nodes/hardware/35-arduino.html
index 6640b77a0..58fdc9c30 100644
--- a/nodes/hardware/35-arduino.html
+++ b/nodes/hardware/35-arduino.html
@@ -1,12 +1,12 @@
 <!--
   Copyright 2013 IBM Corp.
- 
+
   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
   You may obtain a copy of the License at
- 
+
   http://www.apache.org/licenses/LICENSE-2.0
- 
+
   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -14,7 +14,7 @@
   limitations under the License.
 -->
 <script type="text/x-red" data-template-name="arduino in">
-	<div class="form-row">
+    <div class="form-row">
         <label for="node-input-arduino"><i class="icon-tasks"></i> Arduino</label>
         <input type="text" id="node-input-arduino">
     </div>
@@ -33,13 +33,14 @@
         <label for="node-input-name"><i class="icon-tag"></i> Name</label>
         <input type="text" id="node-input-name" placeholder="Name">
     </div>
+    <div class="form-tips"><b>Note:</b> You cannot use the same pin for both output and input.</div>
 </script>
 
 <script type="text/x-red" data-help-name="arduino in">
-	<p>Arduino input node. Connects to local Arduino and monitors the selected pin for changes. Uses <a href="http://firmata.org/" target="_new"><i>Firmata</i>.</a></p>
-	<p>You can select either Digital or Analogue input. Outputs the value read as <b>msg.payload</b> and the pin number as <b>msg.topic</b>.</p>
-	<p>It only outputs on a change of value - fine for digital inputs, but you can get a lot of data from analogue pins which you must then handle.</p>
-	<p>You can set the sample rate in ms from 20 to 65535.</p>
+    <p>Arduino input node. Connects to local Arduino and monitors the selected pin for changes. Uses <a href="http://firmata.org/" target="_new"><i>Firmata</i>.</a></p>
+    <p>You can select either Digital or Analogue input. Outputs the value read as <b>msg.payload</b> and the pin number as <b>msg.topic</b>.</p>
+    <p>It only outputs on a change of value - fine for digital inputs, but you can get a lot of data from analogue pins which you must then handle.</p>
+    <p>You can set the sample rate in ms from 20 to 65535.</p>
 </script>
 
 <script type="text/javascript">
@@ -56,8 +57,8 @@
         outputs:1,
         icon: "arduino.png",
         label: function() {
-			var a = "";
-			if (this.state == "ANALOG") a = "A";
+            var a = "";
+            if (this.state == "ANALOG") a = "A";
             return this.name||"Pin: "+a+this.pin;
         },
         labelStyle: function() {
@@ -67,7 +68,7 @@
 </script>
 
 <script type="text/x-red" data-template-name="arduino out">
-	<div class="form-row">
+    <div class="form-row">
         <label for="node-input-arduino"><i class="icon-tasks"></i> Arduino</label>
         <input type="text" id="node-input-arduino">
     </div>
@@ -87,11 +88,12 @@
         <label for="node-input-name"><i class="icon-tag"></i> Name</label>
         <input type="text" id="node-input-name" placeholder="Name">
     </div>
+    <div class="form-tips"><b>Note:</b> You cannot use the same pin for both output and input.</div>
 </script>
 
 <script type="text/x-red" data-help-name="arduino out">
-	<p>Arduino output node. Connects to local Arduino and writes to the selected digital pin. Uses <a href="http://firmata.org/" target="_new"><i>Firmata</i>.</a></p>
-	<p>You can select Digital, Analogue (PWM) or Servo type outputs. Expects a numeric value in <b>msg.payload</b>. The pin number is set in the properties panel.</p>
+    <p>Arduino output node. Connects to local Arduino and writes to the selected digital pin. Uses <a href="http://firmata.org/" target="_new"><i>Firmata</i>.</a></p>
+    <p>You can select Digital, Analogue (PWM) or Servo type outputs. Expects a numeric value in <b>msg.payload</b>. The pin number is set in the properties panel.</p>
 </script>
 
 <script type="text/javascript">
diff --git a/nodes/hardware/35-arduino.js b/nodes/hardware/35-arduino.js
index b81ea7cfc..3ec126f7f 100644
--- a/nodes/hardware/35-arduino.js
+++ b/nodes/hardware/35-arduino.js
@@ -19,168 +19,178 @@ var util = require("util");
 var firmata = require("firmata");
 var arduinoReady = false;
 var thisboard = null;
+var pins = [];
 
 // The Board Definition - this opens (and closes) the connection
 function ArduinoNode(n) {
-	RED.nodes.createNode(this,n);
-	this.device = n.device;
-	this.repeat = n.repeat||25;
-	util.log("[firmata] Opening "+this.device);
-	var node = this;
+    RED.nodes.createNode(this,n);
+    this.device = n.device;
+    this.repeat = n.repeat||25;
+    util.log("[firmata] Opening "+this.device);
+    var node = this;
 
-	node.toun = setInterval(function() {
-		if (!arduinoReady) {
-			if (thisboard == null) {
-				node.board = new firmata.Board(node.device, function(err) {
-					if (err) {
-						console.log("[firmata] error: ",err);
-						return;
-					}
-					arduinoReady = true;
-					thisboard = node.board;
-					clearInterval(node.toun);
-					util.log('[firmata] Arduino connected');
-				});
-			}
-			else {
-				node.board = thisboard;
-				node.board.removeAllListeners();
-				arduinoReady = true;
-				clearInterval(node.toun);
-				node.toun = false;
-				util.log("[firmata] Arduino already connected");
-			}
-		} else { util.log("[firmata] Waiting for Firmata"); }
-	}, 10000); // wait for firmata to connect to arduino
+    node.toun = setInterval(function() {
+        if (!arduinoReady) {
+            if (thisboard == null) {
+                node.board = new firmata.Board(node.device, function(err) {
+                    if (err) {
+                        util.log("[firmata] error: "+err);
+                        return;
+                    }
+                    arduinoReady = true;
+                    thisboard = node.board;
+                    clearInterval(node.toun);
+                    util.log('[firmata] Arduino connected');
+                });
+            }
+            else {
+                node.board = thisboard;
+                node.board.removeAllListeners();
+                arduinoReady = true;
+                clearInterval(node.toun);
+                node.toun = false;
+                util.log("[firmata] Arduino already connected");
+            }
+        } else { util.log("[firmata] Waiting for Firmata"); }
+    }, 10000); // wait for firmata to connect to arduino
 
-	this.on('close', function() {
-		//this.board.sp.close(function() { console.log("[firmata] Serial port closed"); arduinoReady = false; });
-		arduinoReady = false;
-		if (node.toun) {
-			clearInterval(node.toun);
-			util.log("[firmata] arduino wait loop stopped");
-		}
-		util.log("[firmata] Stopped");
-	});
+    this.on('close', function() {
+        //this.board.sp.close(function() { console.log("[firmata] Serial port closed"); arduinoReady = false; });
+        arduinoReady = false;
+        if (node.toun) {
+            clearInterval(node.toun);
+            util.log("[firmata] arduino wait loop stopped");
+        }
+        util.log("[firmata] Stopped");
+    });
 }
 RED.nodes.registerType("arduino-board",ArduinoNode);
 
 
 // The Input Node
 function DuinoNodeIn(n) {
-	RED.nodes.createNode(this,n);
-	this.buttonState = -1;
-	this.pin = n.pin;
-	this.state = n.state;
-	this.arduino = n.arduino;
-	this.serverConfig = RED.nodes.getNode(this.arduino);
-	if (typeof this.serverConfig === "object") {
-	this.board = this.serverConfig.board;
-		this.repeat = this.serverConfig.repeat;
-		var node = this;
+    RED.nodes.createNode(this,n);
+    this.buttonState = -1;
+    this.pin = n.pin;
+    this.state = n.state;
+    this.arduino = n.arduino;
+    this.serverConfig = RED.nodes.getNode(this.arduino);
+    if (pins.indexOf(this.pin) > -1) {
+        this.error("Arduino pin being used more than once");
+    }
+    else pins.push(this.pin);
+    if (typeof this.serverConfig === "object") {
+        this.board = this.serverConfig.board;
+        this.repeat = this.serverConfig.repeat;
+        var node = this;
 
-		node.toui = setInterval(function() {
-			if (thisboard != null) {
-				node.board = thisboard;
-				clearInterval(node.toui);
-				node.toui = false;
-				//console.log(node.state,node.pin,node.board.MODES[node.state]);
-				node.board.pinMode(node.pin, node.board.MODES[node.state]);
-				node.board.setSamplingInterval(node.repeat);
-				var oldrdg = "";
-				if (node.state == "ANALOG") {
-					node.board.analogRead(node.pin, function(data) {
-						var msg = {payload:data, topic:"A"+node.pin};
-						if (data != oldrdg) {
-							node.send(msg);
-							oldrdg = data;
-						}
-					});
-				}
-				else {
-					node.board.digitalRead(node.pin, function(data) {
-						var msg = {payload:data, topic:node.pin};
-						node.send(msg);
-					});
-				}
-			}
-			else { node.log("Waiting for Arduino"); }
-		}, 5000); // loop to wait for firmata to connect to arduino
+        node.toui = setInterval(function() {
+            if (thisboard != null) {
+                node.board = thisboard;
+                clearInterval(node.toui);
+                node.toui = false;
+                //console.log("i",node.state,node.pin,node.board.MODES[node.state]);
+                node.board.pinMode(node.pin, node.board.MODES[node.state]);
+                node.board.setSamplingInterval(node.repeat);
+                var oldrdg = "";
+                if (node.state == "ANALOG") {
+                    node.board.analogRead(node.pin, function(data) {
+                        var msg = {payload:data, topic:"A"+node.pin};
+                        if (data != oldrdg) {
+                            node.send(msg);
+                            oldrdg = data;
+                        }
+                    });
+                }
+                else {
+                    node.board.digitalRead(node.pin, function(data) {
+                        var msg = {payload:data, topic:node.pin};
+                        node.send(msg);
+                    });
+                }
+            }
+            else { node.log("Waiting for Arduino"); }
+        }, 5000); // loop to wait for firmata to connect to arduino
 
-		this.on('close', function() {
-			if (node.toui) {
-				clearInterval(node.toui);
-				util.log("[firmata] input wait loop stopped");
-			}
-		});
-	}
-	else {
-		util.log("[firmata] Serial Port not Configured");
-	}
+        this.on('close', function() {
+            if (node.toui) {
+                clearInterval(node.toui);
+                util.log("[firmata] input wait loop stopped");
+            }
+        });
+    }
+    else {
+        util.log("[firmata] Serial Port not Configured");
+    }
 }
 RED.nodes.registerType("arduino in",DuinoNodeIn);
 
 
 // The Output Node
 function DuinoNodeOut(n) {
-	RED.nodes.createNode(this,n);
-	this.buttonState = -1;
-	this.pin = n.pin;
-	this.state = n.state;
-	this.arduino = n.arduino;
-	this.serverConfig = RED.nodes.getNode(this.arduino);
-	if (typeof this.serverConfig === "object") {
-		this.board = this.serverConfig.board;
-		var node = this;
+    RED.nodes.createNode(this,n);
+    this.buttonState = -1;
+    this.pin = n.pin;
+    this.state = n.state;
+    this.arduino = n.arduino;
+    if (pins.indexOf(this.pin) > -1) {
+        this.error("Arduino pin being used more than once");
+    }
+    else pins.push(this.pin);
+    this.serverConfig = RED.nodes.getNode(this.arduino);
+    if (typeof this.serverConfig === "object") {
+        this.board = this.serverConfig.board;
+        var node = this;
 
-		this.on("input", function(msg) {
-			//console.log(msg);
-			if (thisboard != null) {
-				if (node.state == "OUTPUT") {
-					if ((msg.payload == true)||(msg.payload == 1)||(msg.payload.toString().toLowerCase() == "on")) {
-						node.board.digitalWrite(node.pin, node.board.HIGH);
-					}
-					if ((msg.payload == false)||(msg.payload == 0)||(msg.payload.toString().toLowerCase() == "off")) {
-						node.board.digitalWrite(node.pin, node.board.LOW);
-					}
-				}
-				if (node.state == "PWM") {
-					msg.payload = msg.payload * 1;
-					if ((msg.payload >= 0) && (msg.payload <= 255)) {
-						//console.log(msg.payload, node.pin);
-						node.board.servoWrite(node.pin, msg.payload);
-					}
-				}
-				if (node.state == "SERVO") {
-					msg.payload = msg.payload * 1;
-					if ((msg.payload >= 0) && (msg.payload <= 180)) {
-						//console.log(msg.payload, node.pin);
-						node.board.servoWrite(node.pin, msg.payload);
-					}
-				}
-			}
-			//else { console.log("Arduino not ready"); }
-		});
+        this.on("input", function(msg) {
+            //console.log(msg);
+            if (node.board != null) {
+                if (node.state == "OUTPUT") {
+                    if ((msg.payload == true)||(msg.payload == 1)||(msg.payload.toString().toLowerCase() == "on")) {
+                        node.board.digitalWrite(node.pin, node.board.HIGH);
+                    }
+                    if ((msg.payload == false)||(msg.payload == 0)||(msg.payload.toString().toLowerCase() == "off")) {
+                        node.board.digitalWrite(node.pin, node.board.LOW);
+                    }
+                }
+                if (node.state == "PWM") {
+                    msg.payload = msg.payload * 1;
+                    if ((msg.payload >= 0) && (msg.payload <= 255)) {
+                        //console.log(msg.payload, node.pin);
+                        node.board.servoWrite(node.pin, msg.payload);
+                    }
+                }
+                if (node.state == "SERVO") {
+                    msg.payload = msg.payload * 1;
+                    if ((msg.payload >= 0) && (msg.payload <= 180)) {
+                        //console.log(msg.payload, node.pin);
+                        node.board.servoWrite(node.pin, msg.payload);
+                    }
+                }
+            }
+            //else { console.log("Arduino not ready"); }
+        });
 
-		node.touo = setInterval(function() {
-			if (thisboard != null) {
-				clearInterval(node.touo);
-				node.touo = false;
-				node.board = thisboard;
-				node.board.pinMode(node.pin, node.board.MODES[node.state]);
-			}
-			else { util.log("[firmata] waiting for arduino to connect"); }
-		}, 5000); // loop to wait for firmata to connect to arduino
+        node.touo = setInterval(function() {
+            if (thisboard != null) {
+                clearInterval(node.touo);
+                node.touo = false;
+                node.board = thisboard;
+                //console.log("o",node.state,node.pin,node.board.MODES[node.state]);
+                node.board.pinMode(node.pin, node.board.MODES[node.state]);
+            }
+            else { util.log("[firmata] waiting for arduino to connect"); }
+        }, 5000); // loop to wait for firmata to connect to arduino
 
-		this.on('close', function() {
-			if (node.touo) {
-				clearInterval(node.touo);
-				util.log("[firmata] output wait loop stopped");
-			}
-		});
-	}
-	else {
-		util.log("[firmata] Serial Port not Configured");
-	}
+        this.on('close', function() {
+            if (node.touo) {
+                clearInterval(node.touo);
+                util.log("[firmata] output wait loop stopped");
+            }
+        });
+    }
+    else {
+        util.log("[firmata] Serial Port not Configured");
+    }
 }
 RED.nodes.registerType("arduino out",DuinoNodeOut);