frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(node): increase required node >=18.5

Browse Source 
Statement can be simplified by increasing the required minor version.
This commit is contained in:
Rotzbua 2024-05-12 22:25:51 +02:00
parent edc5e88d5a
commit f3c561cd86
No known key found for this signature in database
GPG Key ID: C69022D529C17845
3 changed files with 46 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -123,6 +123,6 @@
"supertest": "6.3.3" "supertest": "6.3.3"
}, },
"engines": { "engines": {
"node": ">=18" "node": ">=18.5"
} }
} }

2
packages/node_modules/node-red/package.json vendored
View File

@ -47,6 +47,6 @@
"bcrypt": "5.1.0" "bcrypt": "5.1.0"
}, },
"engines": { "engines": {
"node": ">=18" "node": ">=18.5"
} }
} }

98
test/nodes/core/network/21-httprequest_spec.js
View File

@ -2509,69 +2509,59 @@ describe('HTTP Request Node', function() {
}); });
describe('should parse broken headers', function() { describe('should parse broken headers', function() {
let port = testPort++
const versions = process.versions.node.split('.') let server;
if (( versions[0] == 14 && versions[1] >= 20 ) || before(function() {
( versions[0] == 16 && versions[1] >= 16 ) || server = net.createServer(function (socket) {
( versions[0] == 18 && versions[1] >= 5 ) || socket.write("HTTP/1.0 200\nContent-Type: text/plain\n\nHelloWorld")
( versions[0] > 18)) { socket.end()
// only test if on new enough NodeJS version })
let port = testPort++ server.listen(port,'127.0.0.1', function(err) {
})
});
let server; after(function() {
server.close()
});
before(function() { it('should accept broken headers', function (done) {
server = net.createServer(function (socket) { var flow = [{id:'n1',type:'http request',wires:[['n2']],method:'GET',ret:'obj',url:`http://localhost:${port}/`, insecureHTTPParser: true},
socket.write("HTTP/1.0 200\nContent-Type: text/plain\n\nHelloWorld") {id:"n2", type:"helper"}];
socket.end() helper.load(httpRequestNode, flow, function() {
var n1 = helper.getNode("n1");
var n2 = helper.getNode("n2");
n2.on('input', function(msg) {
try {
msg.payload.should.equal('HelloWorld')
done()
} catch (err) {
done(err)
}
}) })
n1.receive({payload: 'foo'})
});
});
server.listen(port,'127.0.0.1', function(err) { it('should reject broken headers', function (done) {
var flow = [{id:'n1',type:'http request',wires:[['n2']],method:'GET',ret:'obj',url:`http://localhost:${port}/`},
{id:"n2", type:"helper"}];
helper.load(httpRequestNode, flow, function() {
var n1 = helper.getNode("n1");
var n2 = helper.getNode("n2");
n2.on('input', function(msg) {
try{
msg.payload.should.match(/RequestError: Parse Error/)
done()
} catch (err) {
done(err)
}
}) })
}); n1.receive({payload: 'foo'})
after(function() {
server.close()
}); });
});
it('should accept broken headers', function (done) {
var flow = [{id:'n1',type:'http request',wires:[['n2']],method:'GET',ret:'obj',url:`http://localhost:${port}/`, insecureHTTPParser: true},
{id:"n2", type:"helper"}];
helper.load(httpRequestNode, flow, function() {
var n1 = helper.getNode("n1");
var n2 = helper.getNode("n2");
n2.on('input', function(msg) {
try {
msg.payload.should.equal('HelloWorld')
done()
} catch (err) {
done(err)
}
})
n1.receive({payload: 'foo'})
});
});
it('should reject broken headers', function (done) {
var flow = [{id:'n1',type:'http request',wires:[['n2']],method:'GET',ret:'obj',url:`http://localhost:${port}/`},
{id:"n2", type:"helper"}];
helper.load(httpRequestNode, flow, function() {
var n1 = helper.getNode("n1");
var n2 = helper.getNode("n2");
n2.on('input', function(msg) {
try{
msg.payload.should.match(/RequestError: Parse Error/)
done()
} catch (err) {
done(err)
}
})
n1.receive({payload: 'foo'})
});
});
}
}); });
}); });