frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

Merge branch 'pr_2751' into dev

Browse Source
This commit is contained in:
Nick O'Leary 2020-12-07 13:58:53 +00:00
commit f5fcf23678
No known key found for this signature in database
GPG Key ID: 4F2157149161A6C9
2 changed files with 61 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
packages/node_modules/@node-red/nodes/core/function/89-trigger.js vendored
View File

@ -82,10 +82,10 @@ module.exports = function(RED) {
var npay = {}; var npay = {};
var pendingMessages = []; var pendingMessages = [];
var activeMessagePromise = null; var activeMessagePromise = null;
var processMessageQueue = function(msg) { var processMessageQueue = function(msgInfo) {
if (msg) { if (msgInfo) {
// A new message has arrived - add it to the message queue // A new message has arrived - add it to the message queue
pendingMessages.push(msg); pendingMessages.push(msgInfo);
if (activeMessagePromise !== null) { if (activeMessagePromise !== null) {
// The node is currently processing a message, so do nothing // The node is currently processing a message, so do nothing
// more with this message // more with this message
@ -101,17 +101,17 @@ module.exports = function(RED) {
// There are more messages to process. Get the next message and // There are more messages to process. Get the next message and
// start processing it. Recurse back in to check for any more // start processing it. Recurse back in to check for any more
var nextMsg = pendingMessages.shift(); var nextMsgInfo = pendingMessages.shift();
activeMessagePromise = processMessage(nextMsg) activeMessagePromise = processMessage(nextMsgInfo)
.then(processMessageQueue) .then(processMessageQueue)
.catch((err) => { .catch((err) => {
node.error(err,nextMsg); nextMsgInfo.done(err);
return processMessageQueue(); return processMessageQueue();
}); });
} }
this.on('input', function(msg) { this.on('input', function(msg, send, done) {
processMessageQueue(msg); processMessageQueue({msg, send, done});
}); });
var stat = function() { var stat = function() {
@ -121,7 +121,8 @@ module.exports = function(RED) {
else return {fill:"blue",shape:"dot",text:l}; else return {fill:"blue",shape:"dot",text:l};
} }
var processMessage = function(msg) { var processMessage = function(msgInfo) {
let msg = msgInfo.msg;
var topic = RED.util.getMessageProperty(msg,node.topic) || "_none"; var topic = RED.util.getMessageProperty(msg,node.topic) || "_none";
var promise; var promise;
var delayDuration = node.duration; var delayDuration = node.duration;
@ -181,7 +182,7 @@ module.exports = function(RED) {
var msg2 = RED.util.cloneMessage(msg); var msg2 = RED.util.cloneMessage(msg);
node.topics[topic].tout = setInterval(function() { node.topics[topic].tout = setInterval(function() {
if (node.op1type === "date") { msg2.payload = Date.now(); } if (node.op1type === "date") { msg2.payload = Date.now(); }
node.send(RED.util.cloneMessage(msg2)); msgInfo.send(RED.util.cloneMessage(msg2));
}, delayDuration); }, delayDuration);
} }
} }
@ -206,15 +207,15 @@ module.exports = function(RED) {
} }
promise.then(() => { promise.then(() => {
if (node.op2type === "payl") { if (node.op2type === "payl") {
if (node.second === true) { node.send([null,npay[topic]]); } if (node.second === true) { msgInfo.send([null,npay[topic]]); }
else { node.send(npay[topic]); } else { msgInfo.send(npay[topic]); }
delete npay[topic]; delete npay[topic];
} }
else { else {
msg2.payload = node.topics[topic].m2; msg2.payload = node.topics[topic].m2;
if (node.op2type === "date") { msg2.payload = Date.now(); } if (node.op2type === "date") { msg2.payload = Date.now(); }
if (node.second === true) { node.send([null,msg2]); } if (node.second === true) { msgInfo.send([null,msg2]); }
else { node.send(msg2); } else { msgInfo.send(msg2); }
} }
delete node.topics[topic]; delete node.topics[topic];
node.status(stat()); node.status(stat());
@ -229,8 +230,9 @@ module.exports = function(RED) {
}, delayDuration); }, delayDuration);
} }
} }
msgInfo.done();
node.status(stat()); node.status(stat());
if (node.op1type !== "nul") { node.send(RED.util.cloneMessage(msg)); } if (node.op1type !== "nul") { msgInfo.send(RED.util.cloneMessage(msg)); }
}); });
}); });
} }
@ -266,8 +268,8 @@ module.exports = function(RED) {
} }
delete node.topics[topic]; delete node.topics[topic];
node.status(stat()); node.status(stat());
if (node.second === true) { node.send([null,msg2]); } if (node.second === true) { msgInfo.send([null,msg2]); }
else { node.send(msg2); } else { msgInfo.send(msg2); }
}).catch(err => { }).catch(err => {
node.error(err); node.error(err);
}); });
@ -277,6 +279,7 @@ module.exports = function(RED) {
// if (node.op2type === "payl") {node.topics[topic].m2 = RED.util.cloneMessage(msg.payload); } // if (node.op2type === "payl") {node.topics[topic].m2 = RED.util.cloneMessage(msg.payload); }
// } // }
} }
msgInfo.done();
return Promise.resolve(); return Promise.resolve();
} }
this.on("close", function() { this.on("close", function() {

42
test/nodes/core/function/89-trigger_spec.js
View File

@ -1154,5 +1154,45 @@ describe('trigger node', function() {
},180); },180);
}); });
}); });
describe('messaging API', function () {
function mapiDoneTriggerTestHelper(done, nodeSetting, msgAndTimings) {
const completeNode = require("nr-test-utils").require("@node-red/nodes/core/common/24-complete.js");
const catchNode = require("nr-test-utils").require("@node-red/nodes/core/common/25-catch.js");
const flow = [
{ ...nodeSetting, id: "triggerNode1", type: "trigger", wires: [[]] },
{ id: "completeNode1", type: "complete", scope: ["triggerNode1"], uncaught: false, wires: [["helperNode1"]] },
{ id: "catchNode1", type: "catch", scope: ["triggerNode1"], uncaught: false, wires: [["helperNode1"]] },
{ id: "helperNode1", type: "helper", wires: [[]] }];
const numMsgs = msgAndTimings.length;
helper.load([triggerNode, completeNode, catchNode], flow, function () {
const triggerNode1 = helper.getNode("triggerNode1");
const helperNode1 = helper.getNode("helperNode1");
RED.settings.nodeMessageBufferMaxLength = 3;
const t = Date.now();
let c = 0;
helperNode1.on("input", function (msg) {
msg.should.have.a.property('payload');
(Date.now() - t).should.be.approximately(msgAndTimings[msg.seq].avr, msgAndTimings[msg.seq].var);
c += 1;
if (c === numMsgs) {
done();
}
});
for (let i = 0; i < numMsgs; i++) {
setTimeout(function () { triggerNode1.receive(msgAndTimings[i].msg); }, msgAndTimings[i].delay);
}
});
}
it('should call done() when first message has been processed', function (done) {
// not when second and more messages are emitted.
mapiDoneTriggerTestHelper(done, { units:"s", duration:"1" }, [
{ msg: { seq: 0, payload: "A"}, delay: 0, avr: 0, var: 100}
]);
});
it('should call done() when it receives reset message', function (done) {
mapiDoneTriggerTestHelper(done, {units:"s", duration:"1"}, [
{msg: { seq: 0, payload: "A", reset:true}, delay: 0, avr: 0, var:100}
]);
})
});
}); });