1
0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Commit Graph

12 Commits

Author SHA1 Message Date
Frank van de Pol
44e920fde2 Disable the notification for the Change node editor
Disable the notification on the Change node.
Once the infrastructure for validation error messages is implemented
this can be re-enabled and retrofitted to the
new structure.
2013-12-24 23:29:40 +01:00
Frank van de Pol
1ebc5979aa Add validation to Change node editor for invalid regex
This change adds input validation to the gui of Change Nodes to prevent
the user from unintentionally entering an invalid regular expression
(in case the ‘use regular expressions’  option is enabled).

The user will be notified (using the RED notification mechanism) on the
specific error code to help resolve the issue.
2013-12-24 20:28:08 +01:00
Frank van de Pol
b411d59d43 Make log message in invalid regular expressions more verbose
Make logging of erratic regular expressions more verbose to help
identification and resolving of the configuration issue:

eg.:
old: 24 Dec 18:40:09 - [error] [change:Strip kW] Invalid regex: *kW
new: 24 Dec 18:40:09 - [error] [change:Strip kW] Invalid regular
expression: /*kW/: Nothing to repeat

old: 24 Dec 20:15:57 - [error] [change:Strip kW] Invalid regex: *kW
new: 24 Dec 20:15:57 - [error] [change:Strip kW] Invalid regular
expression: /[kW/: Unterminated character class
2013-12-24 20:17:42 +01:00
Frank van de Pol
231f8b6a4d undo my changes to the Change node; revert to original
undo the local changes to the Change node to get back aligned with the
master tree
2013-12-24 20:02:30 +01:00
Frank van de Pol
a03b4e4dd4 Added validation logic to Change editor for validity of regular expressions
This change adds input validation to the gui of Change Nodes to prevent
the user from unintentionally entering an invalid regular expression.
The user will be notified on the specific error code to help resolve
the issue.
2013-12-22 17:46:25 +01:00
Frank van de Pol
655e777a3e Add exception handing to Change node
Adding exception handling to the change node to prevent node-RED from
crashing on invalid regular expressions eg. “*kW” (missing escape
before the asterix)
2013-12-22 14:00:25 +01:00
Nicholas O'Leary
d2ce6af486 Switch node: infer intent to compare numbers
Fixes #108
2013-12-06 20:26:55 +00:00
Nicholas O'Leary
5767478871 Switch node null/not null tests don't always work
a === null / a !=== null

is different to

    typeof a == "undefined" / typeof a != "undefined"
2013-12-03 01:12:29 +00:00
Dave C-J
3982dcdaf1 Add change node to core/logic - allows simple(r) manipulation of some payloads and msg.properties to save having to write functions for these basic tasks. You can replace contents (regex based or simple swap), and add, modify or delete proerties. 2013-11-24 22:25:35 +00:00
Dave C-J
0a78838c71 Add default name to switch node (for when name not specified - to be more consistent with other nodes) 2013-11-24 22:22:35 +00:00
Dave C-J
ff8db09fd9 Add "otherwise" option to switch node - also added ability to stop checking after first match or keep matching (as-is today). Fixes Issue #88 2013-11-22 16:25:02 +00:00
Nicholas O'Leary
48dabffefc Move all nodes into core subdirectory
This makes it easier to distinguish core nodes from those added later
2013-11-14 15:52:19 +00:00