Stephen McLaughlin
51d429f9ae
Dont delete TCP socket twice
2022-05-26 10:18:34 +01:00
Stephen McLaughlin
020eaef5ba
Fix incorrect MQTT status
...
fixes #3550
2022-04-26 16:12:54 +01:00
Nick O'Leary
4706e20a1d
Merge pull request #3526 from node-red-hitachi/fix-status-reference-in-debug-node
...
fix reference error of msg.status in debug node
2022-04-20 10:56:25 +01:00
Steve-Mcl
8df53e441d
remove unused vars
2022-04-19 10:42:00 +01:00
Stephen McLaughlin
6f89efa40b
remove unused if block
...
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
2022-04-19 10:30:08 +01:00
Steve-Mcl
97678577fb
call done after ws disconnects
...
fixes #3527
2022-04-14 22:07:52 +01:00
Hiroyasu Nishiyama
226f45d8d5
fix reference error of msg.status in debug node
2022-04-12 11:33:02 +09:00
Nick O'Leary
0f37b326a0
Merge pull request #3502 from Steve-Mcl/fix-mqtt-will-props
...
fix typo of will properties (properies)
2022-03-21 19:29:23 +00:00
Steve-Mcl
7f9f551cfe
fix typo of will properties (properies)
...
Fixes #3501
2022-03-21 15:24:23 +00:00
Steve-Mcl
10b18de3e0
fix: ensure mqtt v5 props can be set false
...
fixes #3471
2022-03-05 11:24:25 +00:00
Dave Conway-Jones
c0612e6193
Merge branch 'master' of https://github.com/node-red/node-red
2022-02-28 09:59:35 +00:00
萧十一郎
380a08242a
fix html label mistake ( #3459 )
2022-02-26 10:10:17 +00:00
Dave Conway-Jones
0398ef3b90
undo regression in tcp-in node (missed one)
...
and add test
2022-02-25 16:06:44 +00:00
Dave Conway-Jones
25f4fbf2bb
undo regression to tcp-in node
...
To fix #3454
2022-02-21 20:03:25 +00:00
Steve-Mcl
669aa769c2
Fix close timeout on MQTT nodes
...
fixes #2934
2022-02-17 10:18:46 +00:00
Nick O'Leary
be11fda814
Allow nbRateUnits to be undefined when validating
...
Fixes #3407
2022-02-14 20:44:55 +00:00
Alexandre Alapetite
280d63fde7
Fix util.encodeObject
2022-02-03 15:59:25 +01:00
Alexandre Alapetite
e55cbb3e3d
Fix bug in debug node due to msg.hasOwnProperty construct
...
`msg.hasOwnProperty("status")` might make the debug node crash/produce an error if the payload was created with `Object.create(null)`.
This is the case e.g. for `ini` (to parse INI files), an official NPM node:
4f289946b3/lib/ini.js (L63)
My Node-RED node `node-red-contrib-parser-ini`, which is using that library, was hit by this bug and I had to ship a workaround
fe6b1eb4b1/parser-ini.js (L14)
The `msg.hasOwnProperty("xxx")` construct should not be used since ECMAScript 5.1.
ESLint advises in the same direction https://eslint.org/docs/rules/no-prototype-builtins
This patch was produced using the following regex:
Search: `\b([\w.]+).hasOwnProperty\(`
Replace: `Object.prototype.hasOwnProperty.call($1, `
This could be applied more gobally if desired.
2022-02-03 02:01:22 +01:00
Nick O'Leary
1cea1ced82
Merge pull request #3371 from node-red/node-alias
...
Add _path property to nodes and expose as node.path in Function node
2022-01-26 11:10:43 +00:00
Nick O'Leary
703c5adba7
Add _path property to nodes and expose as node.path in Function node
2022-01-25 21:32:28 +00:00
Steve-Mcl
8948ca5323
Merge branch 'dev' into mqtt-reconnect-fix
2022-01-25 12:32:49 +00:00
Steve-Mcl
9c3be51fe9
Improve MQTT broker disconnect situation
...
* Ensure topic is sane to prevent error 129
* Ensure a log entry is made
* Update node status
2022-01-25 12:29:51 +00:00
Nick O'Leary
4e5ddd57bf
Merge branch 'dev' of github.com:node-red/node-red into dev
2022-01-24 23:18:43 +00:00
Nick O'Leary
e0d4ecf835
Merge branch 'master' into dev
2022-01-24 23:18:25 +00:00
Hiroyasu Nishiyama
5effcdb024
use setCookieSync instead of setCookie
2022-01-19 23:45:13 +09:00
Nick O'Leary
c4465ba58d
Merge pull request #3351 from node-red-hitachi/fix-delay-rate-unit-validation
...
fix unit value validation of delay node
2022-01-18 09:45:56 +00:00
Hiroyasu Nishiyama
e7189ab81f
fix unit value validation of delay node
2022-01-13 23:52:06 +09:00
Hiroyasu Nishiyama
f786c7f144
fix JSON propety validation of inject node
2022-01-13 21:42:50 +09:00
Nick O'Leary
51f45293b8
Merge branch 'master' into dev
2022-01-13 10:52:36 +00:00
Nick O'Leary
e1467dfe23
Merge pull request #3348 from node-red/scrollbar-expand
...
Prevent function scrollbar from obscuring expand button
2022-01-13 09:49:15 +00:00
Nick O'Leary
c480f96d30
Prevent function scrollbar from obscuring expand button
...
Fixes #2955
2022-01-13 09:46:37 +00:00
Nick O'Leary
036a825892
Only setup ws client heartbeat once it is connected
...
Fixes #3264
2022-01-12 21:46:56 +00:00
Nick O'Leary
30b00741b5
Merge pull request #3296 from node-red/Json-try-parse-buffer
...
Let JSON node attempt to parse buffer if it contains a valid string
2022-01-12 18:58:02 +00:00
Nick O'Leary
f86e743cce
Merge branch 'master' into dev
2022-01-12 17:59:26 +00:00
Nick O'Leary
c6a38b8355
Merge pull request #3300 from node-red/remove-use-of-verbose-flag-in-core-nodes
...
Remove use of verbose flag in core nodes - and use node.debug level instead
2022-01-12 17:38:34 +00:00
Nick O'Leary
ee84eb666b
Merge pull request #3307 from node-red/add-tls-option-to-tcp-node
...
Add TLS option to tcp client nodes
2022-01-12 17:37:43 +00:00
Tobias Oort
555f155cad
Added support for commaseparated subprotocols
...
Removed placeholder from html
2022-01-12 09:10:35 +01:00
Dave Conway-Jones
52e4e0e569
Fix for narrrowbandEq mode start condition failure
...
And add test
As discussed https://discourse.nodered.org/t/the-filter-node-or-the-old-rbe-node/56371
2022-01-11 13:56:44 +00:00
Dave Conway-Jones
f77d161643
remove debug msg from inject close
2022-01-10 20:22:20 +00:00
Nick O'Leary
062f76214e
Merge pull request #3325 from hardillb/http-basic-username-only
...
Fix basic auth with empty username or password
2022-01-10 18:27:55 +00:00
Tobias Oort
bd77d7eec3
Implemented support for Websocket Subprotocols in WS Client Node.
2022-01-08 22:18:05 +01:00
Steve-Mcl
b5e48aa509
load extralibs when expanding monaco. fixes #3319
2022-01-08 19:29:49 +00:00
Ben Hardill
44616c6872
Fix basic auth with empty username or password
...
fix for #3324
2022-01-05 20:56:46 +00:00
Nick O'Leary
aaa2b4c3db
Merge pull request #3322 from node-red/inject-props-fix
...
Fix incorrect clearing of blank payload property in Inject node
2022-01-04 18:59:05 +00:00
Nick O'Leary
942b17b807
Fix incorrect clearing of blank payload property in Inject node
...
Fixes #3316
2022-01-03 21:51:49 +00:00
Nick O'Leary
0dbc35c252
Update Function to use correct api to access env vars
...
Fixes #3299
2021-12-27 11:55:10 +00:00
Dave Conway-Jones
c9f03f1ac5
better tests
...
(and a small fix as a result)
2021-12-27 09:51:50 +00:00
Dave Conway-Jones
02bd292b8c
fix and test
2021-12-26 16:12:47 +00:00
Dave Conway-Jones
e5f1029d0c
fix variable names for test
2021-12-26 15:37:41 +00:00
Dave Conway-Jones
cae247160f
Let tcprequest split incoming strings on delimiter (as per tcpin node)
...
and fixup i18n messages
2021-12-26 15:28:16 +00:00