* fix many test problems
- adds [stoppable](https://npm.im/stoppable) to force-stop net & http
servers
- upgrades to latest mocha
- much cleanup of servers
- some removal of useless code
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
* increase wait time to hack at race condition
* PoC with fork of stoppable
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
* fix custom stoppable url for newer npm
* make travis go faster; attempt to avoid npm troubles
* fix coveralls executable path
* add extra time for flake to trigger spec
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
* Call fsync() before closing file
* Fix race condition in tests due to incorrect stub.
The startFlows() function wasn't really being stubbed, so it was still being called. But there was no corresponding call to stopFlows().
In later tests, the check in Flows.init() was throwing the "Cannot init without a stop" error.
* Test coverage for fsync() calls
For issue #1478
* Revert "Fix race condition in tests due to incorrect stub."
This reverts commit 4f71d7851b.
* Fix race condition in tests due to incorrect stub.
The startFlows() function wasn't really being stubbed, so it was still being called. But there was no corresponding call to stopFlows().
In later tests, the check in Flows.init() was throwing the "Cannot init without a stop" error.
* Fix intermittent test failure in Exec node.
Occasionally, the error text on stderr will come in more than one piece. The test only worked correctly if a single message was received.
* Resolve dir argument of getLocalNodeFiles function
The getLocalNodeFiles is called 3 times. Each time it called, the callee needs to resolve the dir argument.
That was not done for several of calls, and local modules (specified in the "nodesDir" setting) were not returned to client because of that.
This fix will allow to make sure the dir is consistently resolved.
* Several changes in "localfilesystem_spec.js":
- Changed checkNodes to verify that every node's file property is resolved, i.e. containst absolute path, not relative.
- Added a unit-test "Finds nodes in settings.nodesDir (string,relative path)"
