Nick O'Leary
a6ecb54cc4
Clear node.close timeout to avoid unnecessary work on restart
2020-03-31 19:25:20 +01:00
Nick O'Leary
5c06761b1a
Remove console.log from subflow
2020-03-30 23:42:30 +01:00
Nick O'Leary
84771f5864
Flows/subflows must preinitialise their context objects
...
Fixes #2513
If a node inside a subflow accessed its context object in its
constructor, the subflow-instance flow context would not yet
have been created. This would cause a place holder context
to get created on its behalf, but that place holder doesn't
have its parent set properly. This then breaks the usage
of $parent inside such a subflow.
This fix has changed it so flows (and subflows) create their
flow context as part of their initial creation. That ensures
it exists when individual nodes from the subflow are created,
allowing them to safely access their context.
This has also fixed a related issue where any attempt to use
$parent to access beyond the root parent would seemingly hang
as the callback was never being called. This would cause
messages to get stuck in flows. The fix ensures the callback
is used in the root context objects and undefined is returned.
2020-03-27 23:47:12 +00:00
Nick O'Leary
4304d44851
Ensure complete node scope is remapped in subflows
...
Fixes #2514
2020-03-27 09:44:15 +00:00
Nick O'Leary
d6b5494625
Allow credentials to be provided as part of /flows api
2020-02-13 16:44:48 +00:00
Nick O'Leary
95a51aafdc
Add path property to debug messages
...
Fixes #2358
This property can be used to identify the full path to the node that
logged a given message. If the node is inside a subflow (and maybe
nested many levels deep), this path can be used to help find the
node, rather than just the top-level subflow instance node.
A side-effect of this change is the Debug sidebar is now able to
show the message tools for a message coming from a deeply nested
subflow
2020-01-17 16:56:30 +00:00
Dave Conway-Jones
2f4dcba54d
let subflow add node-red context to status
...
For all those nodes thaht don't specify it.
So that subflow status then works ok
2019-11-20 06:12:33 -05:00
Nick O'Leary
b734097d16
Merge pull request #2227 from node-red/node-done
...
Adds Done callback to Input event handler
2019-08-21 11:15:00 +01:00
Nick O'Leary
880757fb5d
Rework Subflow Instance property UI ( #2236 )
...
* Add support of Subflow UI definition
* new UI definition for env var
* fix label
* fixed value obtaining
* fixed label width
* fix checkbox
* fix subflow info
* remove old subflow ui tests
* add tests
* merge ui new changes
* fix initial open button
* fix environment variable edit tab
* WIP: cp-1
* Rework subflow ui property
* Restrict SF value type according to input selection
* Move subflow property UI code to subflow.js
* Update subflow ui type select appearance
* Present subflow instance properties as table rather than generated UI
* Move subflow instance properties to separate tab
* Fix subflow property ui element layout issues
2019-08-12 15:01:54 +01:00
Nick O'Leary
3b5ea0f15f
Add node done API
2019-07-08 23:23:33 +01:00
Nick O'Leary
24b38407e4
Merge branch 'master' into dev
2019-07-01 12:43:16 +01:00
Nick O'Leary
f49d1ae860
Ensure the subflow stop promise is waiting for before restarting
2019-07-01 12:42:11 +01:00
Nick O'Leary
a941b1437c
Handle subflow internal node wired to a non-existant node
...
Fixes #2202
2019-06-21 12:47:37 +01:00
Nick O'Leary
2473249c8b
Allow config nodes to be disabled, tidy css and add actions
2019-06-17 22:46:34 +01:00
Nick O'Leary
41a0af032c
Enable individual flow nodes to be disabled
2019-06-14 22:12:47 +01:00
Nick O'Leary
ae2162beaf
Handle subflow internal node wired to a non-existant node
...
Fixes #2202
2019-06-13 14:23:46 +01:00
Nick O'Leary
ee6c6266cc
Avoid env var reference loops and support $parent. prefix
...
Fixes #2099
2019-03-20 13:37:33 +00:00
Nick O'Leary
962a29110c
Ensure config._flow is non-enumerable so is ignored by JSON.stringify
...
Fixes https://github.com/pdmangel/node-red-contrib-openhab2/issues/36
2019-03-18 15:11:56 +00:00
Nick O'Leary
afa69f4c0e
Ensure all subflow instances are stopped when flow stopping
...
Fixes #2095
2019-03-15 09:13:32 +00:00
Nick O'Leary
c9ff05ba80
Subflow status node must pass status to parent flow
...
Fixes #2087
2019-03-13 13:14:34 +00:00
Nick O'Leary
c944eaab5c
Fix max call stack err when getting node from inside subflow
2019-03-12 14:40:47 +00:00
Nick O'Leary
d3d9533493
Search subflows instances when looking for given node id
2019-03-12 14:25:36 +00:00
Nick O'Leary
28e08ebaf5
Add envVarExcludes setting to block named env vars
2019-03-07 22:54:20 +00:00
Nick O'Leary
8fb6bc059e
Pass complete status to Status node and filter to editor
2019-03-04 10:23:10 +00:00
Nick O'Leary
f4f664a4a2
Ensure flows wait for all nodes to close before restarting
...
Fixes #2067
2019-02-27 20:56:58 +00:00
Nick O'Leary
75393c0b28
Clear subflow status no close
2019-02-09 21:24:31 +00:00
Nick O'Leary
d48a09e68b
Add env type to subflow env var types
...
Also remove date and regex types
2019-02-06 13:58:31 +00:00
Nick O'Leary
79f3669fac
Add 'catch uncaught only' mode to Catch node
...
Closes #1747
This was inspired by a PR from @mauriciom75 but implemented in a different way
due to some of the internal reworking done to Flow and Subflow in the dev branch
2019-02-05 14:29:50 +00:00
Nick O'Leary
5110eaff96
Merge branch 'dev' into pr_2042
2019-02-04 14:39:00 +00:00
Nick O'Leary
db3eee72b5
Do not convert falsey env vars to blank string
...
Only blank out undefined as that's what we've always done
2019-02-04 14:12:34 +00:00
Nick O'Leary
3bcff91328
Add Status Node to Subflow to allow subflow-specific status
...
Closes #597
2019-02-01 23:44:50 +00:00
Hiroyasu Nishiyama
e843f192ec
convert subflow env vars to dict
2019-02-02 08:34:33 +09:00
Hiroyasu Nishiyama
ce507b3b52
simplified meta-data
2019-01-30 20:57:51 +09:00
Nick O'Leary
d534a8952d
Do not propagate Flow.getNode to parent when called from outside flow
2019-01-29 21:49:20 +00:00
Hiroyasu Nishiyama
6937aa5ddd
fix type of env values
2019-01-29 23:46:56 +09:00
Hiroyasu Nishiyama
8f6b24e0aa
fixed to access last variable with same name
2019-01-29 21:46:50 +09:00
Hiroyasu Nishiyama
0881c6a20b
update test cases
2019-01-28 23:14:49 +09:00
Hiroyasu Nishiyama
f88a4b1791
fixed comments from @knolleary
2019-01-28 22:14:08 +09:00
Hiroyasu Nishiyama
a413f3cded
Add support of subflow env var
2019-01-26 23:15:20 +09:00
Nick O'Leary
4baaaa8d59
Propagate Status/Error events from global config nodes
2019-01-25 15:46:39 +00:00
Nick O'Leary
c99b35428b
Ensure status/error events are propagated to parent properly
2019-01-25 13:35:02 +00:00
Nick O'Leary
490903ca25
Tidy up when usage in Flow and Node
2019-01-17 13:18:26 +00:00
Nick O'Leary
dd72046922
Add some comments to Flow and Subflow classes
2019-01-16 23:33:04 +00:00
Nick O'Leary
6286b34d00
Add Flow.getSetting for resolving env-var properties
...
This lays the groundwork for subflow-specific settings
2019-01-16 22:38:04 +00:00
Nick O'Leary
81f4e0de56
Refactor Subflow logic into own class
2019-01-16 16:27:19 +00:00
Nick O'Leary
da756fa568
WIP: Start refactor of nodes/Flow.js
2019-01-11 14:53:21 +00:00
Nick O'Leary
d887ab126b
Add --safe mode flag to allow starting without flows running
2018-09-25 11:20:50 +01:00
Nick O'Leary
e57d8ba0ef
pull out editor-client and editor-api
2018-08-17 22:10:54 +01:00
