frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity
7,312 Commits 119 Branches 156 Tags 55 MiB
b2c2b9bd14
Commit Graph

2879 Commits

Author SHA1 Message Date
Nick O'Leary
95f7177ef4
Merge pull request #3445 from node-red-hitachi/fix-path-substitution 
Fix substitution of NR_NODE_PATH
 2022-02-15 11:26:19 +00:00
Steve-Mcl
efd8c1229d improve "Unexpected Node Error" logging 
- fixes #3389
- adds additional info to aid sourcing the issue
- removes lots of undefined info when node type is incorrect
- stores and reports original stack before internal try/catch exception
- ensure this._flow is something before attempting to call `handleError`
 2022-02-15 10:51:18 +00:00
Hiroyasu Nishiyama
6a41cbebc9 evaluate env var after path initialization 2022-02-15 14:23:01 +09:00
Nick O'Leary
bffb91f196
Merge pull request #3443 from node-red/delay-field-validation 
Allow nbRateUnits to be undefined when validating
 2022-02-14 23:18:41 +00:00
Nick O'Leary
4573b65639
Merge pull request #3444 from node-red/keyboard-filter-case 
Handle mixed-cased filter terms in keyboard shortcut dialog
 2022-02-14 23:18:16 +00:00
Nick O'Leary
3d8505385a
Merge pull request #3442 from node-red/dupe-links 
Prevent duplicate links being added between nodes
 2022-02-14 23:18:01 +00:00
Nick O'Leary
99c053f86b
Merge pull request #3440 from Steve-Mcl/monaco-env-suggestions 
Coding help for recently added node-red Predefined Environment Variables
 2022-02-14 23:02:55 +00:00
Nick O'Leary
f2dde705ef
Handle mixed-cased filter terms in keyboard shortcut dialog 
Fixes #3400
 2022-02-14 20:59:43 +00:00
Nick O'Leary
be11fda814
Allow nbRateUnits to be undefined when validating 
Fixes #3407
 2022-02-14 20:44:55 +00:00
Nick O'Leary
0261105c52
Prevent duplicate links being added between nodes 2022-02-14 20:35:47 +00:00
Nick O'Leary
264047dc0c
Merge pull request #3437 from Steve-Mcl/fix-multiple-wires 
bug fix: Dont add wires to undo buffer twice
 2022-02-14 20:12:46 +00:00
Steve-Mcl
4d84926ed2 Update monaco for Predefined Environment Variables 
- add Predefined Environment Variables to snippet suggestions
- update jsdoc for `env.get`
 2022-02-14 13:38:37 +00:00
Nick O'Leary
1388b03cf2
Remove console.log when ignoring disabled module 2022-02-14 10:46:08 +00:00
Steve-Mcl
b3f1401ab4 Dont add wires to undo buffer twice 
Fixes #3433
 2022-02-13 16:56:26 +00:00
Hiroyasu Nishiyama
e5e3832809
fix Japanese message of delay node (#3434) 2022-02-12 16:13:59 +00:00
Nick O'Leary
2eff7da171
Merge pull request #3397 from node-red-hitachi/fix-config-node-validation 
fix node validation to be applied to config node
 2022-02-09 19:47:23 +00:00
Nick O'Leary
e9622bcfe8
Merge pull request #3391 from node-red-hitachi/fix-hide-flow-tooltip 
fix to hide tooltip after removing subflow tab
 2022-02-09 19:44:05 +00:00
Hiroyasu Nishiyama
dc73997be3 fix not to use hasOwnProperty 2022-02-08 09:21:52 +09:00
Hiroyasu Nishiyama
fb81121bd3 fix node validation to be applied to config node 2022-02-04 17:45:00 +09:00
Alexandre Alapetite
2e1e61dabe
Remove part of JSDoc 2022-02-03 16:32:51 +01:00
Alexandre Alapetite
280d63fde7
Fix util.encodeObject 2022-02-03 15:59:25 +01:00
Alexandre Alapetite
e55cbb3e3d
Fix bug in debug node due to msg.hasOwnProperty construct 
`msg.hasOwnProperty("status")` might make the debug node crash/produce an error if the payload was created with `Object.create(null)`.
This is the case e.g. for `ini` (to parse INI files), an official NPM node:
4f289946b3/lib/ini.js (L63)

My Node-RED node `node-red-contrib-parser-ini`, which is using that library, was hit by this bug and I had to ship a workaround
fe6b1eb4b1/parser-ini.js (L14)

The `msg.hasOwnProperty("xxx")` construct should not be used since ECMAScript 5.1.

ESLint advises in the same direction https://eslint.org/docs/rules/no-prototype-builtins

This patch was produced using the following regex:
Search: `\b([\w.]+).hasOwnProperty\(`
Replace: `Object.prototype.hasOwnProperty.call($1, `

This could be applied more gobally if desired.
 2022-02-03 02:01:22 +01:00
Hiroyasu Nishiyama
7959d18248 hide tooltip after removing subflow tab 2022-02-02 11:34:58 +09:00
Nick O'Leary
b7bae18849
Update inner package dependency 2022-01-27 12:58:43 +00:00
Nick O'Leary
5c87a6cb76
Update package readmes and licenses 2022-01-27 12:49:48 +00:00
Nick O'Leary
d1bd303dfa
Update version for 2.2.0 2022-01-27 10:13:28 +00:00
Nick O'Leary
3304ebe9d3
Merge pull request #3382 from node-red-hitachi/fix-subflow-update 
fix opening/closing subflow template not to make subflow changed
 2022-01-27 09:30:26 +00:00
Hiroyasu Nishiyama
b06049d5a3 fix opening/closing subflow template not to make subflow changed 2022-01-27 12:57:37 +09:00
Kazuhito Yokoi
0f50355deb Add Japanese translations for v2.2.0 2022-01-27 11:14:24 +09:00
Nick O'Leary
bd6e35fea2
Merge branch 'dev' of github.com:node-red/node-red into dev 2022-01-26 17:46:47 +00:00
Nick O'Leary
a4fd63cd44
Merge pull request #3380 from Steve-Mcl/search-find-filenode 
Pallet Label (if different to type) should be indexed for search
 2022-01-26 17:00:47 +00:00
Steve-Mcl
fdc4219b68 palletLabel (if different) should be indexed 
for search - fixes #3297
 2022-01-26 16:14:34 +00:00
Nick O'Leary
5b428bb8e6
Merge pull request #3379 from node-red-hitachi/nr_node_path-support 
add NR_NODE_PATH path support
 2022-01-26 14:29:03 +00:00
Hiroyasu Nishiyama
c948ff88a5 add support of NR_NODE_PATH 2022-01-26 21:24:48 +09:00
Nick O'Leary
9b9a0d7060
Update dependencies 2022-01-26 12:20:45 +00:00
Nick O'Leary
be7f84bc67
Merge pull request #3377 from Steve-Mcl/function-node-decs 
Update `node` declarations in func.d.ts
 2022-01-26 12:03:56 +00:00
Nick O'Leary
4c0826b1c4
Update tour for 2.2.0 2022-01-26 12:00:30 +00:00
Steve-Mcl
c4cc204c94 Add static declerations to func ts. fixes #3376 2022-01-26 11:40:05 +00:00
Nick O'Leary
4173625fca
Merge pull request #3243 from node-red/delete-global-context 
Clear context contents when switching projects
 2022-01-26 11:28:34 +00:00
Nick O'Leary
207ba00ad2
Add editorTheme.tours property to default settings file 2022-01-26 11:21:11 +00:00
Nick O'Leary
87c89586a5
Merge pull request #3356 from node-red-hitachi/node-prop-env-var 
Add support for accessing node id & name as environment variable
 2022-01-26 11:11:02 +00:00
Nick O'Leary
1cea1ced82
Merge pull request #3371 from node-red/node-alias 
Add _path property to nodes and expose as node.path in Function node
 2022-01-26 11:10:43 +00:00
Nick O'Leary
08732bac0f
Merge pull request #3374 from Steve-Mcl/mqtt-reconnect-fix 
Mqtt reconnect fix
 2022-01-26 11:03:20 +00:00
Nick O'Leary
283e8d3c08
Merge pull request #3373 from Steve-Mcl/merge-fix 
bug: merge issue. fixes #3364
 2022-01-26 11:01:35 +00:00
Nick O'Leary
42a7165596
Merge pull request #3372 from Steve-Mcl/use-paletteLabel-in-help 
Use a nodes palette label in help tree
 2022-01-26 11:00:53 +00:00
Hiroyasu Nishiyama
ba304c9651 add NR_ prefix to special environment variables 2022-01-26 09:25:30 +09:00
Nick O'Leary
703c5adba7
Add _path property to nodes and expose as node.path in Function node 2022-01-25 21:32:28 +00:00
Steve-Mcl
8b85f6e0a6 ensure help search is case insensitive 2022-01-25 18:27:47 +00:00
Nick O'Leary
42358419ad
Fix vertical align of subflow port labels 2022-01-25 17:08:04 +00:00
Nick O'Leary
ab2ced5c37
Merge pull request #3352 from ralphwetzel/dev 
Subflow: Add labels to OUTPUT nodes
 2022-01-25 17:07:12 +00:00
Steve-Mcl
faf31be0dc Ensure label is shown in help tree 2022-01-25 16:30:30 +00:00
Nick O'Leary
ff4c67d068
Merge pull request #3353 from kazuhitoyokoi/dev-addjpn 
Add Japanese translations for v2.2.0-beta.1
 2022-01-25 16:02:29 +00:00
Steve-Mcl
10b133db02 bug: merge issue. fixes #3364 2022-01-25 14:47:36 +00:00
Nick O'Leary
f0bf607b43
Merge pull request #3359 from node-red-hitachi/fix-action-list-i18n 
fix to make actions list i18n ready and Japanese translation
 2022-01-25 14:47:18 +00:00
Steve-Mcl
8948ca5323 Merge branch 'dev' into mqtt-reconnect-fix 2022-01-25 12:32:49 +00:00
Steve-Mcl
9c3be51fe9 Improve MQTT broker disconnect situation 
* Ensure topic is sane to prevent error 129
* Ensure a log entry is made
* Update node status
 2022-01-25 12:29:51 +00:00
Hiroyasu Nishiyama
2da9161f29
Update packages/node_modules/@node-red/editor-client/src/js/ui/actions.js 
Oh, I'm sorry about this.

Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
 2022-01-25 21:21:39 +09:00
Hiroyasu Nishiyama
8b23d341b4 add support for env var access of GROUP_ID & GROUP_NAME 2022-01-25 21:04:43 +09:00
Hiroyasu Nishiyama
289815e128 add support of FLOW_ID & FLOW_NAME 2022-01-25 20:46:01 +09:00
Kazuhito Yokoi
f7ee83f1b9 Add translations for restoring zoom level and scroll position 2022-01-25 11:18:35 +09:00
Nick O'Leary
f67aafa8d3
Merge pull request #3361 from node-red/zoom-level 
Remember Zoom level and Sidebar tab selection between sessions
 2022-01-24 23:21:31 +00:00
Nick O'Leary
4e5ddd57bf
Merge branch 'dev' of github.com:node-red/node-red into dev 2022-01-24 23:18:43 +00:00
Nick O'Leary
e0d4ecf835
Merge branch 'master' into dev 2022-01-24 23:18:25 +00:00
Nick O'Leary
d679b02658
Add option to remember zoom and scroll position in localStorage 2022-01-24 21:04:27 +00:00
Hiroyasu Nishiyama
5effcdb024 use setCookieSync instead of setCookie 2022-01-19 23:45:13 +09:00
Nick O'Leary
211a5eb2bb
Bump for 2.1.6 2022-01-18 09:46:57 +00:00
Nick O'Leary
c4465ba58d
Merge pull request #3351 from node-red-hitachi/fix-delay-rate-unit-validation 
fix unit value validation of delay node
 2022-01-18 09:45:56 +00:00
Nick O'Leary
dbefe6a560
Revert copy-text change and apply alternative fix 
Reverts PR #3331 and applies the alternative fix originally proposed
in PR #3329
 2022-01-18 09:27:15 +00:00
Nick O'Leary
a2e0074061
Update marked to latest 2022-01-18 09:20:52 +00:00
Nick O'Leary
5fc920087b
Store user zoom level in localStorage 2022-01-17 21:27:48 +00:00
Nick O'Leary
085233ab9b
Remember last sidebar tab between editor sessions 2022-01-17 21:27:21 +00:00
Hiroyasu Nishiyama
6657b2629f move i18n code to action list according to PR comment 2022-01-16 12:10:19 +09:00
Nick O'Leary
310a279aaf
Merge pull request #3358 from node-red-hitachi/fix-property-error-tooltip 
fix to make start of property error tooltip messages aligned
 2022-01-15 19:44:18 +00:00
Hiroyasu Nishiyama
58f3a76da7 fix to make actions list i18n ready and Japanese translation 2022-01-15 20:39:05 +09:00
Hiroyasu Nishiyama
a2c9458b1b aligin start of property error tooltip messages 2022-01-15 13:11:56 +09:00
Hiroyasu Nishiyama
75bcd9e8d5 add support for accessing node id & name as env var 2022-01-14 23:40:12 +09:00
Kazuhito Yokoi
977e7ef395 Add Japanese translations for v2.2.0-beta.1 2022-01-14 14:43:28 +09:00
ralphwetzel
eb1b8b577f
Merge branch 'node-red:dev' into dev 2022-01-13 23:36:23 +01:00
ralphwetzel
28f91685ce Subflow: Add labels to OUTPUT nodes 2022-01-13 23:33:06 +01:00
Nick O'Leary
81a4fe59d9
Update changelog/welcome tour for 2.2 2022-01-13 15:16:16 +00:00
Hiroyasu Nishiyama
e7189ab81f fix unit value validation of delay node 2022-01-13 23:52:06 +09:00
Hiroyasu Nishiyama
f786c7f144 fix JSON propety validation of inject node 2022-01-13 21:42:50 +09:00
Nick O'Leary
51f45293b8
Merge branch 'master' into dev 2022-01-13 10:52:36 +00:00
Nick O'Leary
f055d42277
Update package version for 2.1.5 2022-01-13 10:22:41 +00:00
Nick O'Leary
fb7a2a8d5d
Update dependencies 2022-01-13 10:19:56 +00:00
Nick O'Leary
1e5ed2a2e3
Merge pull request #3331 from kazuhitoyokoi/master-fixcopybutton2 
Fix copy buttons on the debug window (another method)
 2022-01-13 09:50:27 +00:00
Nick O'Leary
e1467dfe23
Merge pull request #3348 from node-red/scrollbar-expand 
Prevent function scrollbar from obscuring expand button
 2022-01-13 09:49:15 +00:00
Nick O'Leary
c480f96d30
Prevent function scrollbar from obscuring expand button 
Fixes #2955
 2022-01-13 09:46:37 +00:00
Kazuhito Yokoi
cf613aafb2
Update packages/node_modules/@node-red/editor-client/src/js/ui/clipboard.js 
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
 2022-01-13 10:35:12 +09:00
Nick O'Leary
20dbf7c5f4
Merge pull request #3346 from node-red/fix-stack-capture 
Handle reporting error location when stack is truncated
 2022-01-12 22:54:25 +00:00
Nick O'Leary
47c912c25b
Merge pull request #3345 from node-red/jsonata-compat-mode-fix 
Improve jsonata legacy mode detection regex
 2022-01-12 22:54:05 +00:00
Nick O'Leary
48fb1a8127
Merge pull request #3344 from node-red/fix-ws-hb 
Only setup ws client heartbeat once it is connected
 2022-01-12 22:53:51 +00:00
Nick O'Leary
df70c8a800
Fix generating flow name with incrementing number 
Fixes #3295
 2022-01-12 22:45:18 +00:00
Nick O'Leary
82ae2e7118
Handle reporting error location when stack is truncated 
Fixes #3292
 2022-01-12 22:07:44 +00:00
Nick O'Leary
0cf9b5f3df
Improve jsonata legacy mode detection regex 
Fixes #3290
 2022-01-12 21:56:38 +00:00
Nick O'Leary
036a825892
Only setup ws client heartbeat once it is connected 
Fixes #3264
 2022-01-12 21:46:56 +00:00
Nick O'Leary
8b43b31c64
Add checkbox on project-open screen to clear context 2022-01-12 21:05:47 +00:00
Nick O'Leary
3abef972a7
Clear context contents when switching projects 
Fixes #3240
 2022-01-12 18:59:29 +00:00
Nick O'Leary
30b00741b5
Merge pull request #3296 from node-red/Json-try-parse-buffer 
Let JSON node attempt to parse buffer if it contains a valid string
 2022-01-12 18:58:02 +00:00
Nick O'Leary
f86e743cce
Merge branch 'master' into dev 2022-01-12 17:59:26 +00:00
Nick O'Leary
cb96fb735e
Merge pull request #3289 from node-red/snap-grid 
Snap nodes on grid using either edge as reference
 2022-01-12 17:57:26 +00:00
Nick O'Leary
459a52d31d
Merge pull request #3340 from node-red/cut-wires 
Add wire-slice mode to delete wires with Ctrl-RHClick-Drag
 2022-01-12 17:52:54 +00:00
Nick O'Leary
44ef9a13d6
Merge pull request #3338 from node-red/detach-action 
Detach action
 2022-01-12 17:52:32 +00:00
Nick O'Leary
0bb3652a63
Merge pull request #3323 from node-red/highlight-links 
Highlight links when selecting nodes
 2022-01-12 17:52:03 +00:00
Nick O'Leary
6a82d683a9
Merge pull request #3262 from node-red/search-history 
Add search history to main search box
 2022-01-12 17:51:46 +00:00
Nick O'Leary
fad708e8de
Merge pull request #3294 from node-red/multi-select-links 
Allow multiple links to be selected by ctrl-click
 2022-01-12 17:51:15 +00:00
Nick O'Leary
c6a38b8355
Merge pull request #3300 from node-red/remove-use-of-verbose-flag-in-core-nodes 
Remove use of verbose flag in core nodes - and use node.debug level instead
 2022-01-12 17:38:34 +00:00
Nick O'Leary
ee84eb666b
Merge pull request #3307 from node-red/add-tls-option-to-tcp-node 
Add TLS option to tcp client nodes
 2022-01-12 17:37:43 +00:00
Nick O'Leary
6d2793cac6
Merge pull request #3336 from node-red-hitachi/add-link-call-example 
add link call example
 2022-01-12 17:31:57 +00:00
Nick O'Leary
86d518fc2e
Merge pull request #3343 from node-red/adminAuth-logging 
Initialize passport when only adminAuth.tokens is set
 2022-01-12 17:31:44 +00:00
Nick O'Leary
af949c62c2
Allow 'escape' to cancel wire-slicing 2022-01-12 17:24:25 +00:00
Nick O'Leary
ea20342d76
Handle non-error responses from token function 2022-01-12 13:48:06 +00:00
Nick O'Leary
7732d52583
Initialize passport when only adminAuth.tokens is set 
Fixes #3341
 2022-01-12 13:27:01 +00:00
Nick O'Leary
c801bc5e6b
Add error logging if Node.log throws an error 
Part of #3327
 2022-01-12 11:13:29 +00:00
Nick O'Leary
ea43729063
Add _module to Node object to provide module info 2022-01-12 11:07:25 +00:00
Nick O'Leary
e26bae8027
Merge pull request #3333 from tobiasoort/dev 
Implemented support for Websocket Subprotocols in WS Client Node.
 2022-01-12 09:31:55 +00:00
Tobias Oort
555f155cad Added support for commaseparated subprotocols 
Removed placeholder from html
 2022-01-12 09:10:35 +01:00
Nick O'Leary
f3997128b9
Add wire-slice mode to delete wires with Ctrl-RHClick-Drag 2022-01-11 19:49:40 +00:00
Nick O'Leary
154a4e23dd
Add delete-selection-and-reconnect action 2022-01-11 14:11:55 +00:00
Dave Conway-Jones
52e4e0e569
Fix for narrrowbandEq mode start condition failure 
And add test
As discussed https://discourse.nodered.org/t/the-filter-node-or-the-old-rbe-node/56371
 2022-01-11 13:56:44 +00:00
Nick O'Leary
30f2b96c68
Pressing escape whilst DETACH_DRAGGING should revert change 2022-01-11 00:24:34 +00:00
Nick O'Leary
58c94b7773
Add core:detach-selected-nodes action 2022-01-11 00:16:24 +00:00
Dave Conway-Jones
f77d161643
remove debug msg from inject close 2022-01-10 20:22:20 +00:00
Nick O'Leary
6580b139c0
Merge pull request #3288 from node-red/wiring-shortcut 
Wiring shortcut
 2022-01-10 18:34:06 +00:00
Nick O'Leary
2743c7c6ac
Merge pull request #3304 from node-red-hitachi/dev-unknownconfig 
Check availability of type of config node on deploy
 2022-01-10 18:33:36 +00:00
Nick O'Leary
062f76214e
Merge pull request #3325 from hardillb/http-basic-username-only 
Fix basic auth with empty username or password
 2022-01-10 18:27:55 +00:00
Nick O'Leary
ce98ed98a2
Merge pull request #3334 from Steve-Mcl/fix-monaco-expanded 
load extralibs when expanding monaco. fixes #3319
 2022-01-10 18:23:07 +00:00
Nick O'Leary
dce9d93f6c
Merge pull request #3335 from node-red-hitachi/fix-file-node-example 
Update file node examples according to node name change
 2022-01-10 18:22:39 +00:00
Hiroyasu Nishiyama
931335220f resume focus after import/export dialog close 2022-01-09 23:34:08 +09:00
Hiroyasu Nishiyama
3ce35a8a4b add link call example 2022-01-09 20:24:15 +09:00
Hiroyasu Nishiyama
9ac4e5cf6a update file node examples according to node name change 2022-01-09 19:49:06 +09:00
Tobias Oort
bd77d7eec3 Implemented support for Websocket Subprotocols in WS Client Node. 2022-01-08 22:18:05 +01:00
Steve-Mcl
b5e48aa509 load extralibs when expanding monaco. fixes #3319 2022-01-08 19:29:49 +00:00
Kazuhito Yokoi
b14c42b6a4
Update Japanese translations in node help (#3332) 
* Update Japanese translations in node help

* Fix typos
 2022-01-07 17:43:53 +00:00
Kazuhito Yokoi
ba794ba58c Use clipboard.writeText() instead of execCommand("copy") 2022-01-07 11:49:26 +09:00
Kazuhito Yokoi
b00282590d Fix copy buttons on the debug window 2022-01-07 09:27:01 +09:00
Ben Hardill
44616c6872
Fix basic auth with empty username or password 
fix for #3324
 2022-01-05 20:56:46 +00:00
Nick O'Leary
aaa2b4c3db
Merge pull request #3322 from node-red/inject-props-fix 
Fix incorrect clearing of blank payload property in Inject node
 2022-01-04 18:59:05 +00:00
Nick O'Leary
8974d8e4df
Merge pull request #3321 from node-red/fix-prev-tab-action 
Fix findPreviousVisibleTab action
 2022-01-04 18:58:45 +00:00
Nick O'Leary
699063cbb0
Merge pull request #3312 from node-red/hide-tabs-fix 
Fix storing hidden tab state when not hidden via action
 2022-01-04 18:58:32 +00:00
Nick O'Leary
e76000b713
Merge pull request #3311 from node-red/strip-empty-env 
Avoid adding empty env properties to tabs/groups
 2022-01-04 18:57:53 +00:00
Nick O'Leary
cb3fcb7bfa
Ctrl-Shift-Click on node should add to existing selection 2022-01-03 23:29:42 +00:00
Nick O'Leary
bef641609e
Select links when nodes on either side selected 2022-01-03 23:29:12 +00:00
Nick O'Leary
24b52f09df
Add RED.nodes.getNodeLinks to help node-link lookup 2022-01-03 23:27:25 +00:00
Nick O'Leary
942b17b807
Fix incorrect clearing of blank payload property in Inject node 
Fixes #3316
 2022-01-03 21:51:49 +00:00
Nick O'Leary
cf19d7f3ad
Fix findPreviousVisibleTab action 
Fixes #3320
 2022-01-03 21:20:23 +00:00
Nick O'Leary
ebd62a4112
Fix storing hidden tab state when not hidden via action 
Fixes #3305
 2021-12-28 10:29:42 +00:00
Nick O'Leary
9af7357ca4
Avoid adding empty env properties to tabs/groups 
Fixes #3306
 2021-12-27 12:03:40 +00:00
Nick O'Leary
0dbc35c252
Update Function to use correct api to access env vars 
Fixes #3299
 2021-12-27 11:55:10 +00:00
Dave Conway-Jones
c9f03f1ac5
better tests 
(and a small fix as a result)
 2021-12-27 09:51:50 +00:00