Commit Graph

158 Commits

Author SHA1 Message Date
Ben Hardill b77a2dc353
Better fix 2021-10-28 10:08:28 +01:00
Ben Hardill 87af31de20
HTTP Basic Auth should always add : to username
fix for #3235
2021-10-28 09:18:17 +01:00
Steve-Mcl 153f87704b fix datatype in node config not used. fixes #3215 2021-10-24 22:21:44 +01:00
Dave Conway-Jones a7413cccd0
reuse existing labels for tcp request buffer/string option 2021-10-20 09:36:08 +01:00
Dave Conway-Jones d3f978c90c
Add optional string type output to tcp request node
to be similar to tcp in. node
2021-10-19 21:34:23 +01:00
Nick O'Leary b8f1386ad0
Dynamic MQTT connections (#3189)
* add mqtt-control
- adds auto-connect option to broker
- add new node mqtt-control
- adds i18n messages
- adds documentation

* documentation tweaks

* built in documentation improvements

* fix tip layout causing oversized editor

* remove unused requires

* add missing `unsubscribe` dropdown option
- oddly forgotten - now added

* ensure clientid is updated dynamically

* [rewrite] move mqtt-control login into mqtt-in

* Remove dynamic label

* remove redundant mqtt-control code left overs

* Callback for brokerConn.connect (improve done())
- done is now called on connect callback

* fix race condition if connect/disconnect too fast
- node.connected and node.client.connected getting out of sync

* fix connection fail when switching protocol 3 ~ 5
- ensure protocolId is correct for protocolVersion

* change msg.subscribe prop to `msg.topic`

* unsub all topics if msg.topic is `true`

* delete temprary debugger statements

* Final rework of dynamic mqtt connections

Co-authored-by: Steve-Mcl <sdmclaughlin@gmail.com>
2021-10-14 12:05:06 +01:00
Nick O'Leary 8042fe4e2b
Merge branch 'master' into dev 2021-10-06 09:12:16 +01:00
Nick O'Leary 3759e0f778
Add option to only send http response errors to Catch node 2021-10-04 14:04:59 +01:00
Nick O'Leary 0171ffac6a
Fix sizing of HTTP Response header fields 2021-10-04 10:52:36 +01:00
Dave Conway-Jones 4f23847546
Fix UDP node to not not use port if unassigned 2021-09-16 16:22:01 +01:00
Kunihiko Toumura 490547cd3d Use httpRequestTimingLog for enable detailed timing log 2021-09-05 15:22:13 +09:00
Dave Conway-Jones 17f9829498
Fix for incorrect tcpout connection count
to Close #3098
seems to need dummy data receiver in order to recognise other callbacks.
2021-09-03 13:00:06 +01:00
Kunihiko Toumura 401466d6c0 Add timing log 2021-08-23 11:54:05 +09:00
Nick O'Leary 6364e00202
Merge pull request #3092 from hardillb/http-req-ca-fix
Copy tls.cert to tls.certificate for GOT
2021-07-28 10:05:19 +01:00
Ben Hardill a76c6f86c6
Add Testcase & Fix typo 2021-07-28 08:52:35 +01:00
Ben Hardill 555e815402
Copy tls.cert to tls.certificate for GOT 2021-07-27 22:19:35 +01:00
Nick O'Leary f1775d4fd1
Handle partially encoded url query strings in request node 2021-07-26 14:21:52 +01:00
Ben Hardill 26087f8dc7
Fix support for supplied CA certs 2021-07-26 10:25:06 +01:00
Nick O'Leary 6e69cfbca4
Preserve case of user-provided http headers in request node
Fixes #3081
2021-07-23 09:55:32 +01:00
Nick O'Leary 775181f761
Set decompress to false for HTTP Request to keep 1.x compatibility
Fixes #3083
2021-07-23 08:57:44 +01:00
Nick O'Leary 5f6fcb2bc0
Do not throw HTTP errors in request node
Fixes #3082

GOT will throw errors for non-successful http responses by default. We need to turn that
off to be consistent with the 1.x behaviour using the request module
2021-07-22 23:48:30 +01:00
Nick O'Leary 7b106e5650
Ensure uri is properly encoded before passing to got module
Fixes #3080
2021-07-22 23:47:32 +01:00
Nick O'Leary 79d9c83a2d
Better detection of broken agent-base function patching 2021-07-22 11:19:25 +01:00
Nick O'Leary f7606e92ca
Detect if agent-base has patch https.request and undo it
Fixes #3072
2021-07-21 16:22:28 +01:00
Nick O'Leary 6750be3ec9
HTTP Request node - ignore invalid cookies rather than fail request
Fixes #3075

Keeps behaviour consistent with the request module
2021-07-21 14:09:15 +01:00
Ben Hardill 32dd186f4d
Prevent Overwite of configured creds 2021-07-16 08:47:30 +01:00
Ben Hardill 81f0fb3c74
Fix creds in URL 2021-07-15 18:32:51 +01:00
Ben Hardill 972c83cd52
Fix for #3067
Check if there are any content to the credential object
2021-07-15 17:35:03 +01:00
Nick O'Leary d8ee766860
Allow websocket client node to send pings 2021-07-08 10:51:36 +01:00
Nick O'Leary 19589d9117
Merge branch 'master' into dev 2021-07-02 10:00:43 +01:00
Nick O'Leary b848fe249f
Remove stray console.log from mqtt.html 2021-07-01 21:01:11 +01:00
Kazuhito Yokoi 13f1c12912 Add translations to message catalog 2021-06-14 15:54:05 +09:00
Ben Hardill 919aee64f9
Add support for user/pass in URL 2021-06-11 14:48:41 +01:00
Ben Hardill bcb6d1cf93
Fix for basic auth with @ in username 2021-06-11 14:25:18 +01:00
Nick O'Leary 133df75bd4
Merge branch 'dev' into get-got 2021-06-09 09:59:23 +01:00
Ben Hardill d5c5738aab
Fix proxy authentication problem & reinstate tests
Down to only 2 of the previous tests not working
2021-06-08 14:22:20 +01:00
Nick O'Leary 7bf938901a
Merge branch 'pr_2952' into dev 2021-06-08 11:09:56 +01:00
Nick O'Leary 01b5fc4d49
Merge pull request #2987 from node-red/clean-ids
Change node id generation to give fixed length values without '.'
2021-05-27 12:18:38 +01:00
Ben Hardill 0b52cd8b31
Fixes from testing
I set up a NGINX instance to test this and found I'd missed some bits.

Still can't find a way to test this easily from a nodejs unit test
2021-05-19 10:41:24 +01:00
Ben Hardill 8c95067ec4
Add ALPN support to TLS node 2021-05-18 13:13:32 +01:00
Nick O'Leary 8bbed2c831
Change node id generation to give fixed length values without '.' 2021-05-18 11:32:17 +01:00
Ben Hardill 8c1a749a5a
Fix msg.responseUrl
The original version would pick up the proxy servers port number
2021-05-12 11:08:57 +01:00
Ben Hardill 4c8e895ac7
Clean up console.logs 2021-05-11 09:56:22 +01:00
Ben Hardill f6a3671366
Get the http-request node got port working with Proxy 2021-05-10 23:01:29 +01:00
Nick O'Leary e23f20227a
Initial migration from request to got for http-request node 2021-04-23 14:19:15 +01:00
Ben Hardill 235690064f
Fix for #2935 2021-04-16 13:26:11 +01:00
Nick O'Leary 04a3c4bb22
Ensure mqtt-close message is published when closing mqtt nodes
The change in 1.3 where we ensure config nodes are closed last broke this behaviour. Previously, the config node would get closed triggering the close message. With the new 1.3 behaviour, the flow nodes are stopped and as soon as the last flow node deregisters itself, the broker node would disconnect without sending the close message.

The fix is to send the close message as part of the deregister flow as that will handle all cases properly
2021-04-14 22:28:25 +01:00
Nick O'Leary 5028377d45
Fix MQTT Broker TLS config row layout
Fixes #2927
2021-04-12 11:48:10 +01:00
Nick O'Leary 16e021e94f
Request node: set followAllRedirects to work with POSTs
Fixes #2017
2021-04-07 14:35:29 +01:00
Hiroyasu Nishiyama 7e40cb5331 update i18n and Japanese message for nodes 2021-03-03 10:07:33 +09:00
Steve-Mcl 080e2f2589 mqtt v5 fixes
- copy/paste issues with willMsg
- ensure helper func is ran for lwt messages
2021-02-25 19:58:59 +00:00
Nick O'Leary 255b8f2005
Update mqtt nodes for v5 2021-02-25 15:49:56 +00:00
Steve-Mcl 833ecfb1af MQTT V5 - prep for 1.3.0 beta...
* MQTT IN node tidy up
  * remove userProperties
  * remove subscriptionIdentifier
* MQTT OUT node tidy up
  * remove topicAlias
  * remove payloadFormatIndicator
  * remove subscriptionIdentifier
* MQTT BROKER node tidy up
  * remove topicAliasMaximum
  * remove maximumPacketSize
  * remove receiveMaximum
  * remove userProperties
2021-02-20 19:58:13 +00:00
Steve-Mcl c20bab2436 more specific class selectors for show/hide items 2021-02-20 15:52:14 +00:00
Steve-Mcl ab4a9e72d4 Merge branch 'dev' into mqtt5 2021-02-18 18:50:26 +00:00
Hiroyasu Nishiyama d8c8d7bc57
hide unused input field (#2823) 2021-01-16 16:58:13 +00:00
Kevin Godell 79b10ed18a
allow for adding an array of middleware functions 2020-12-22 16:30:38 -06:00
Steve-Mcl be52ec1390 mark more TODO areas (mostly debugging) 2020-12-07 12:48:33 +00:00
Steve-Mcl 00db43198d design/TODO comments 2020-12-07 12:26:27 +00:00
Steve-Mcl 6bac207611 better handling of server properties 2020-12-07 12:25:51 +00:00
Steve-Mcl 6150ae787d userProperties input type correction 2020-12-07 11:50:33 +00:00
Steve-Mcl b72ea63100 config node userProperties should only permit json 2020-12-07 11:45:02 +00:00
Steve-Mcl 27550f2d4b automatically use resposeTopic if topic is empty 2020-12-07 09:43:52 +00:00
Steve-Mcl 6917919f35 show name as @x if alias is set but topic is not
- e.g. @1 denotes alias 1 is set but topic is empty
2020-12-07 09:41:43 +00:00
Steve-Mcl a776ba248e correction to retain handling def value 2020-10-25 09:50:57 +00:00
Steve-Mcl 195aeb5caf mqttv5 progress 2020-10-14 23:30:03 +01:00
Steve-Mcl 38649de85f debugging 2020-10-10 10:56:10 +01:00
Steve-Mcl 33bb86cbcf mqtt5 1st draft 2020-10-08 20:24:35 +01:00
Nick O'Leary bcd85b11a1
Merge branch 'master' into dev 2020-08-05 15:19:54 +01:00
Dave Conway-Jones 889224715b
Fix hhp-in to handle application/cbor as binary
as per discussion https://discourse.nodered.org/t/http-request-node-invalid-message-body-was-specified-to-be-cbor-but-could-not-decode-message-failed-to-parse/30503
2020-07-23 10:04:24 +01:00
Kunihiko Toumura 4f3a6821d1 new-style callback function (http response node) 2020-07-14 19:08:22 +09:00
Dave Conway-Jones b72ca439e2
Fix tcp in node finishing packets when in streaming base64 receive mode. 2020-06-22 22:40:15 +01:00
Hiroyasu Nishiyama 7694349078 prevent charAt call on websocket listener 2020-06-11 23:00:56 +09:00
Nick O'Leary 774751a25c
Tweak HTTP Request GET payload handling labels 2020-05-29 17:35:18 +01:00
Nick O'Leary 13718032f6
Merge branch 'dev' into pr_2478 2020-05-29 17:04:54 +01:00
Nick O'Leary 95d1b7bc36
Merge branch 'dev' into pr_2570 2020-05-27 11:52:37 +01:00
Nick O'Leary 9f1373945b
[help-sidebar] Tidy up some errors 2020-05-12 13:42:01 +01:00
Nick O'Leary 18bf220ca4
Merge pull request #2413 from dvv/patch-1
Allow to know particular session from status node
2020-05-05 14:42:26 +01:00
Nick O'Leary d7df20413d
Merge branch 'master' into dev 2020-05-04 11:41:44 +01:00
Vladimir Kuznetsov 33200b2d08 Fix: Remove nodejs deprecation warning in 21-httpin node 2020-04-15 15:39:59 +02:00
Dave Conway-Jones bc96f2d0cb
udp node: when reusing input socket honour the broadcast mode. 2020-04-11 22:33:11 +01:00
Dave Conway-Jones 1d417c07cd
TCP out - tidy up select of which rows to display
to help address #2525
2020-04-03 11:14:23 +01:00
Nick O'Leary 05fc3c5eca
Merge branch 'master' into dev 2020-03-30 23:41:33 +01:00
Nick O'Leary 9b6e798eb6
Merge pull request #2502 from kazuhitoyokoi/master-updatemsgcatalog4websocketnode
Add Japanese translation to node property of websocket node
2020-03-24 15:14:17 +00:00
Dave Conway-Jones b0c3c78899
MQTT out - Add warning if topic contains + or #
still sends msg as it causes connection to bounce which may be useful and dropping it would be a change in behaviour.
2020-03-18 15:47:03 +00:00
Kazuhito Yokoi 369c5754f2 Add Japanese translation to node property of websocket node 2020-03-13 16:26:48 +09:00
Ben Hardill 7723ff461b
Remove console.logs 2020-02-26 19:46:54 +00:00
Ben Hardill 0ca36a89e3
Updates to match Nick's suggestions 2020-02-26 19:45:01 +00:00
Ben Hardill 37bcd5c603
First pass at adding support for GET requests
with a body
2020-02-25 21:28:15 +00:00
Nick O'Leary 608834eafb
Ensure IPv6 broker names are wrapped in brackets
Fixes #2462
2020-02-24 21:52:07 +00:00
Nick O'Leary 1f8ed9dcb9
Merge branch 'master' into dev 2020-02-10 11:07:50 +00:00
Tscherno 663ed9833a
Add HEAD as Method 2020-02-01 17:21:33 +01:00
Nick O'Leary 6b52206186
Merge branch 'master' into dev 2020-01-22 11:54:24 +00:00
Kazuhito Yokoi 74a015c329 Change types from text/x-red to text/html in node html files 2020-01-15 11:40:48 +09:00
Dave Conway-Jones 9c4640e010
Make min-height for change, switch, batch and mqtt consistent
to allow fit to smaller screens before scrolling
(to fix comment from forum)
2020-01-01 21:32:56 +00:00
Vladimir Dronnikov fe0d4f08f3
Allow to know particular session from status node
The rationale is to keep own list of active sessions.
As a workaround for https://discourse.nodered.org/t/tcp-connection-pool-better-separation/19432
TIA
2019-12-25 06:21:55 +03:00
Nick O'Leary b93165592e
Merge pull request #2372 from btsimonh/proxy-support
noproxy support in mqtt, Proxy & noproxy support in websocket
2019-11-21 10:45:23 +00:00
Simon Hailes 175a871ee0 repalce for-in with 'normal' for loop in mqtt and http 2019-11-18 17:14:38 +00:00
btsimonh b4e2061e85
Update packages/node_modules/@node-red/nodes/core/network/21-httprequest.js
Co-Authored-By: Nick O'Leary <nick.oleary@gmail.com>
2019-11-18 17:03:59 +00:00
Simon Hailes aa86cfc55f Add fix for HttpsProxyAgent using an incorrect default port for http: 2019-11-03 11:08:24 +00:00