Stephen McLaughlin
6f89efa40b
remove unused if block
...
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
2022-04-19 10:30:08 +01:00
Steve-Mcl
013af7619e
add tests
...
- fix 2 issues found when developing tests :)
2022-04-16 17:13:54 +01:00
Steve-Mcl
aa302ecc32
Ensure filename is at least an empty string!
2022-04-16 14:42:03 +01:00
Steve-Mcl
99b049fe2d
final updates to file node filename typedInput
...
- ensure node settings are auto updated to correct typedInput type/value
- improve label
- ensure str and env are considered "static" (keep stream open)
2022-04-16 14:25:37 +01:00
Steve-Mcl
6e35a9f682
use typedInput for filename on file nodes
2022-04-14 23:55:57 +01:00
Stephen McLaughlin
78f456911a
auto mode to auto parse string to JS Object
2022-04-14 22:47:18 +01:00
Steve-Mcl
8f5d3dc49c
Use v5 properties to aid auto parsing payload
...
- closes #3421
- fixes bug in `function setBoolProp()`
2022-04-14 22:47:18 +01:00
Steve-Mcl
97678577fb
call done after ws disconnects
...
fixes #3527
2022-04-14 22:07:52 +01:00
Steve-Mcl
b9919b0a9c
Show link targets for link call in subflow
...
fixes #3248
2022-04-12 22:11:34 +01:00
Hiroyasu Nishiyama
226f45d8d5
fix reference error of msg.status in debug node
2022-04-12 11:33:02 +09:00
Hiroyasu Nishiyama
accbf6ecfc
update validator arguments not to use optional object
2022-04-12 08:09:46 +09:00
Stephen McLaughlin
a7932da207
Merge pull request #3488 from Steve-Mcl/httpreq-headers-ui
...
Add UI for Http Request node headers
2022-04-06 08:35:32 +01:00
Nick O'Leary
e606d0b1de
Merge pull request #3385 from node-red/allow-inject-on-start
...
let inject optionally fire at start in only at time mode.
2022-04-05 23:34:20 +01:00
Nick O'Leary
b4bcb7ace2
Merge pull request #3503 from node-red/debug-tooltip
...
Add a tooltip to debug sidebar messages to reveal full path to node
2022-04-05 23:33:14 +01:00
Kazuhito Yokoi
14fa9cfa4b
Change indents from tabs to 4 spaces
2022-03-30 15:20:39 +09:00
Dave Conway-Jones
8a40622815
tcp node - undo trim if we re-add split chars
...
and fix tests
2022-03-23 22:07:43 +00:00
Steve-Mcl
b918b75414
Merge remote-tracking branch 'upstream/master' into dev
2022-03-23 11:16:18 +00:00
Nick O'Leary
37f0e36c98
Merge pull request #3463 from Steve-Mcl/dynamic-link-call
...
Dynamic link call
2022-03-23 10:14:48 +00:00
Nick O'Leary
5b5553b9a3
Add debug message path info tooltip
...
Fixes #3477
2022-03-21 20:44:36 +00:00
Nick O'Leary
0f37b326a0
Merge pull request #3502 from Steve-Mcl/fix-mqtt-will-props
...
fix typo of will properties (properies)
2022-03-21 19:29:23 +00:00
Steve-Mcl
7f9f551cfe
fix typo of will properties (properies)
...
Fixes #3501
2022-03-21 15:24:23 +00:00
Nick O'Leary
3649f10600
Merge pull request #3478 from node-red/auto-gen-name
...
Allow node name to be auto-generated when added
2022-03-14 19:35:58 +00:00
Nick O'Leary
db1ad0df63
Add Junctions
2022-03-14 18:16:24 +00:00
Steve-Mcl
c5de18caae
fix: node save broken
...
- Revert last minute code tidy that changed too many `this` to `node`
2022-03-12 16:10:36 +00:00
Steve-Mcl
e57774e121
fix UI change events
...
- use `this` not `node` in UI change events
2022-03-12 15:02:25 +00:00
Steve-Mcl
b7ee46d400
revise header options
...
- remove Accept-Charset
- Use camel case by default
- additional encodings
2022-03-12 15:00:48 +00:00
Steve-Mcl
6007132640
rearange UI (name to bottom)
2022-03-12 14:59:15 +00:00
Steve-Mcl
31b3a4c342
Add UI for common headers/values
...
- Wrap HTML node script in IFFE (isolate module level vars & functions)
- Add UI elements for setting headers in http req node edit form
- Update built in help
- Add tests
2022-03-12 13:47:29 +00:00
Nick O'Leary
3c0b74005b
Add core:generate-node-names action
2022-03-09 11:32:37 +00:00
Steve-Mcl
10b18de3e0
fix: ensure mqtt v5 props can be set false
...
fixes #3471
2022-03-05 11:24:25 +00:00
Stephen McLaughlin
e85b925f40
Ensure linkType is a valid value (2nd attempt)
2022-03-01 16:48:31 +00:00
Steve-Mcl
b665698e78
Ensure linkType is a valid value
2022-02-28 19:00:58 +00:00
Steve-Mcl
249f7e45fb
Link Call should not call into subflow...
...
- includes missing jsdoc
- improves speed (no searching, only lookups)
- code formatting consistency
- improve tests
2022-02-28 13:57:22 +00:00
Dave Conway-Jones
c0612e6193
Merge branch 'master' of https://github.com/node-red/node-red
2022-02-28 09:59:35 +00:00
萧十一郎
380a08242a
fix html label mistake ( #3459 )
2022-02-26 10:10:17 +00:00
Steve-Mcl
e653a933f1
fix subflow calls
2022-02-25 18:39:48 +00:00
Steve-Mcl
19cf43a10e
Re-write link call targeting...
...
- Remove msg.target by object
- Remove :: scoping
- Always try to locate matching link-in on same flow first
- If not found, look on all flows
- if 1 found, call it
- If more than 1 link target found, raise error
2022-02-25 16:13:39 +00:00
Dave Conway-Jones
0398ef3b90
undo regression in tcp-in node (missed one)
...
and add test
2022-02-25 16:06:44 +00:00
Dave Conway-Jones
8c19daf949
TCP nodes- Add optional reattach delimiter to streaming strings
2022-02-25 15:56:13 +00:00
Steve-Mcl
e4f0688a02
dynamic link target 1st draft
2022-02-24 19:46:21 +00:00
Dave Conway-Jones
25f4fbf2bb
undo regression to tcp-in node
...
To fix #3454
2022-02-21 20:03:25 +00:00
Nick O'Leary
0533c08438
Merge branch 'master' into dev
2022-02-18 22:02:30 +00:00
Steve-Mcl
669aa769c2
Fix close timeout on MQTT nodes
...
fixes #2934
2022-02-17 10:18:46 +00:00
Nick O'Leary
95d3a8cc22
Merge pull request #3409 from node-red/let-switch-number-test-report-NaN-as-false
...
switch node - add check for NaN in is of type number to be false
2022-02-14 23:17:38 +00:00
Nick O'Leary
be11fda814
Allow nbRateUnits to be undefined when validating
...
Fixes #3407
2022-02-14 20:44:55 +00:00
Hiroyasu Nishiyama
9f98b4b082
add support of property validation message
2022-02-14 10:40:49 +09:00
Dave Conway-Jones
63ebadc526
add check for NaN in is of type number to be false
...
and add test
to fix issue #3408
2022-02-09 12:03:38 +00:00
Alexandre Alapetite
280d63fde7
Fix util.encodeObject
2022-02-03 15:59:25 +01:00
Alexandre Alapetite
e55cbb3e3d
Fix bug in debug node due to msg.hasOwnProperty construct
...
`msg.hasOwnProperty("status")` might make the debug node crash/produce an error if the payload was created with `Object.create(null)`.
This is the case e.g. for `ini` (to parse INI files), an official NPM node:
4f289946b3/lib/ini.js (L63)
My Node-RED node `node-red-contrib-parser-ini`, which is using that library, was hit by this bug and I had to ship a workaround
fe6b1eb4b1/parser-ini.js (L14)
The `msg.hasOwnProperty("xxx")` construct should not be used since ECMAScript 5.1.
ESLint advises in the same direction https://eslint.org/docs/rules/no-prototype-builtins
This patch was produced using the following regex:
Search: `\b([\w.]+).hasOwnProperty\(`
Replace: `Object.prototype.hasOwnProperty.call($1, `
This could be applied more gobally if desired.
2022-02-03 02:01:22 +01:00
Dave Conway-Jones
514da83961
let inject optionally fire at start in only at time mode.
2022-01-28 18:05:20 +00:00
Nick O'Leary
1cea1ced82
Merge pull request #3371 from node-red/node-alias
...
Add _path property to nodes and expose as node.path in Function node
2022-01-26 11:10:43 +00:00
Nick O'Leary
703c5adba7
Add _path property to nodes and expose as node.path in Function node
2022-01-25 21:32:28 +00:00
Steve-Mcl
8948ca5323
Merge branch 'dev' into mqtt-reconnect-fix
2022-01-25 12:32:49 +00:00
Steve-Mcl
9c3be51fe9
Improve MQTT broker disconnect situation
...
* Ensure topic is sane to prevent error 129
* Ensure a log entry is made
* Update node status
2022-01-25 12:29:51 +00:00
Nick O'Leary
4e5ddd57bf
Merge branch 'dev' of github.com:node-red/node-red into dev
2022-01-24 23:18:43 +00:00
Nick O'Leary
e0d4ecf835
Merge branch 'master' into dev
2022-01-24 23:18:25 +00:00
Hiroyasu Nishiyama
5effcdb024
use setCookieSync instead of setCookie
2022-01-19 23:45:13 +09:00
Nick O'Leary
c4465ba58d
Merge pull request #3351 from node-red-hitachi/fix-delay-rate-unit-validation
...
fix unit value validation of delay node
2022-01-18 09:45:56 +00:00
Hiroyasu Nishiyama
e7189ab81f
fix unit value validation of delay node
2022-01-13 23:52:06 +09:00
Hiroyasu Nishiyama
f786c7f144
fix JSON propety validation of inject node
2022-01-13 21:42:50 +09:00
Nick O'Leary
51f45293b8
Merge branch 'master' into dev
2022-01-13 10:52:36 +00:00
Nick O'Leary
e1467dfe23
Merge pull request #3348 from node-red/scrollbar-expand
...
Prevent function scrollbar from obscuring expand button
2022-01-13 09:49:15 +00:00
Nick O'Leary
c480f96d30
Prevent function scrollbar from obscuring expand button
...
Fixes #2955
2022-01-13 09:46:37 +00:00
Nick O'Leary
036a825892
Only setup ws client heartbeat once it is connected
...
Fixes #3264
2022-01-12 21:46:56 +00:00
Nick O'Leary
30b00741b5
Merge pull request #3296 from node-red/Json-try-parse-buffer
...
Let JSON node attempt to parse buffer if it contains a valid string
2022-01-12 18:58:02 +00:00
Nick O'Leary
f86e743cce
Merge branch 'master' into dev
2022-01-12 17:59:26 +00:00
Nick O'Leary
c6a38b8355
Merge pull request #3300 from node-red/remove-use-of-verbose-flag-in-core-nodes
...
Remove use of verbose flag in core nodes - and use node.debug level instead
2022-01-12 17:38:34 +00:00
Nick O'Leary
ee84eb666b
Merge pull request #3307 from node-red/add-tls-option-to-tcp-node
...
Add TLS option to tcp client nodes
2022-01-12 17:37:43 +00:00
Tobias Oort
555f155cad
Added support for commaseparated subprotocols
...
Removed placeholder from html
2022-01-12 09:10:35 +01:00
Dave Conway-Jones
52e4e0e569
Fix for narrrowbandEq mode start condition failure
...
And add test
As discussed https://discourse.nodered.org/t/the-filter-node-or-the-old-rbe-node/56371
2022-01-11 13:56:44 +00:00
Dave Conway-Jones
f77d161643
remove debug msg from inject close
2022-01-10 20:22:20 +00:00
Nick O'Leary
062f76214e
Merge pull request #3325 from hardillb/http-basic-username-only
...
Fix basic auth with empty username or password
2022-01-10 18:27:55 +00:00
Tobias Oort
bd77d7eec3
Implemented support for Websocket Subprotocols in WS Client Node.
2022-01-08 22:18:05 +01:00
Steve-Mcl
b5e48aa509
load extralibs when expanding monaco. fixes #3319
2022-01-08 19:29:49 +00:00
Ben Hardill
44616c6872
Fix basic auth with empty username or password
...
fix for #3324
2022-01-05 20:56:46 +00:00
Nick O'Leary
aaa2b4c3db
Merge pull request #3322 from node-red/inject-props-fix
...
Fix incorrect clearing of blank payload property in Inject node
2022-01-04 18:59:05 +00:00
Nick O'Leary
942b17b807
Fix incorrect clearing of blank payload property in Inject node
...
Fixes #3316
2022-01-03 21:51:49 +00:00
Nick O'Leary
0dbc35c252
Update Function to use correct api to access env vars
...
Fixes #3299
2021-12-27 11:55:10 +00:00
Dave Conway-Jones
c9f03f1ac5
better tests
...
(and a small fix as a result)
2021-12-27 09:51:50 +00:00
Dave Conway-Jones
02bd292b8c
fix and test
2021-12-26 16:12:47 +00:00
Dave Conway-Jones
e5f1029d0c
fix variable names for test
2021-12-26 15:37:41 +00:00
Dave Conway-Jones
cae247160f
Let tcprequest split incoming strings on delimiter (as per tcpin node)
...
and fixup i18n messages
2021-12-26 15:28:16 +00:00
Dave Conway-Jones
6692b1992c
TCP add tls option to inbound nodes
2021-12-26 12:12:31 +00:00
Dave Conway-Jones
0937837b7f
Add TLS config option to TCP client nodes
...
(not yet when in server mode)
2021-12-24 16:18:00 +00:00
Dave Conway-Jones
2cad42870e
chaneg exec, file and inject node to use node.debug rather than -v flag
2021-12-17 09:58:10 +00:00
Dave Conway-Jones
6ae42eb787
Let JSON parser attempt to parse buffers if they contain strings
...
and add/fix test
2021-12-10 15:21:43 +00:00
Nick O'Leary
68a80b9244
Merge pull request #3277 from node-red/debug-path-fix
...
Add proper error handling for 404 errors when serving debug files
2021-12-01 13:48:25 +00:00
Nick O'Leary
04ffa06221
Add proper error handling for 404 errors when serving debug files
2021-11-26 11:30:51 +00:00
Dave Conway-Jones
6ac0c0a367
fix 2nd output when in rate limit per topic modes
...
to fix issue found in #3260
2021-11-15 14:05:16 +00:00
Nick O'Leary
679e07189d
Do not modify inject node props in oneditprepare
...
Fixes #3241
2021-11-01 20:10:52 +00:00
Ben Hardill
b77a2dc353
Better fix
2021-10-28 10:08:28 +01:00
Ben Hardill
87af31de20
HTTP Basic Auth should always add : to username
...
fix for #3235
2021-10-28 09:18:17 +01:00
Nick O'Leary
e57183ed0e
Merge pull request #3219 from Steve-Mcl/mqtt-use-datatype
...
fix datatype in node config not used. fixes #3215
2021-10-24 22:58:36 +01:00
Steve-Mcl
153f87704b
fix datatype in node config not used. fixes #3215
2021-10-24 22:21:44 +01:00
Nick O'Leary
2b220abdb7
Fix issue with old inject nodes that migrated topic to 'string' type
2021-10-22 09:01:24 +01:00
Dave Conway-Jones
a7413cccd0
reuse existing labels for tcp request buffer/string option
2021-10-20 09:36:08 +01:00
Dave Conway-Jones
d3f978c90c
Add optional string type output to tcp request node
...
to be similar to tcp in. node
2021-10-19 21:34:23 +01:00
Nick O'Leary
8158487c3e
Reduce churn in setting Switch rule typedInput type
2021-10-19 10:12:13 +01:00
Nick O'Leary
d0ec055222
Fix Inject/Change node restoring typedInput options
2021-10-18 21:23:42 +01:00
Nick O'Leary
ae12ddd32b
Change node: Fix deepCopy checkbox spacing on Safari
2021-10-18 20:38:46 +01:00