Commit Graph

160 Commits

Author SHA1 Message Date
Hiroyasu Nishiyama accbf6ecfc update validator arguments not to use optional object 2022-04-12 08:09:46 +09:00
Nick O'Leary e606d0b1de
Merge pull request #3385 from node-red/allow-inject-on-start
let inject optionally fire at start in only at time mode.
2022-04-05 23:34:20 +01:00
Nick O'Leary b4bcb7ace2
Merge pull request #3503 from node-red/debug-tooltip
Add a tooltip to debug sidebar messages to reveal full path to node
2022-04-05 23:33:14 +01:00
Nick O'Leary 37f0e36c98
Merge pull request #3463 from Steve-Mcl/dynamic-link-call
Dynamic link call
2022-03-23 10:14:48 +00:00
Nick O'Leary 5b5553b9a3
Add debug message path info tooltip
Fixes #3477
2022-03-21 20:44:36 +00:00
Nick O'Leary 3649f10600
Merge pull request #3478 from node-red/auto-gen-name
Allow node name to be auto-generated when added
2022-03-14 19:35:58 +00:00
Nick O'Leary db1ad0df63
Add Junctions 2022-03-14 18:16:24 +00:00
Nick O'Leary 3c0b74005b
Add core:generate-node-names action 2022-03-09 11:32:37 +00:00
Stephen McLaughlin e85b925f40
Ensure linkType is a valid value (2nd attempt) 2022-03-01 16:48:31 +00:00
Steve-Mcl b665698e78 Ensure linkType is a valid value 2022-02-28 19:00:58 +00:00
Steve-Mcl 249f7e45fb Link Call should not call into subflow...
- includes missing jsdoc
- improves speed (no searching, only lookups)
- code formatting consistency
- improve tests
2022-02-28 13:57:22 +00:00
Steve-Mcl e653a933f1 fix subflow calls 2022-02-25 18:39:48 +00:00
Steve-Mcl 19cf43a10e Re-write link call targeting...
- Remove msg.target by object
- Remove :: scoping
- Always try to locate matching link-in on same flow first
  - If not found, look on all flows
    - if 1 found, call it
    - If more than 1 link target found, raise error
2022-02-25 16:13:39 +00:00
Steve-Mcl e4f0688a02 dynamic link target 1st draft 2022-02-24 19:46:21 +00:00
Hiroyasu Nishiyama 9f98b4b082 add support of property validation message 2022-02-14 10:40:49 +09:00
Alexandre Alapetite 280d63fde7
Fix util.encodeObject 2022-02-03 15:59:25 +01:00
Alexandre Alapetite e55cbb3e3d
Fix bug in debug node due to msg.hasOwnProperty construct
`msg.hasOwnProperty("status")` might make the debug node crash/produce an error if the payload was created with `Object.create(null)`.
This is the case e.g. for `ini` (to parse INI files), an official NPM node:
4f289946b3/lib/ini.js (L63)

My Node-RED node `node-red-contrib-parser-ini`, which is using that library, was hit by this bug and I had to ship a workaround
fe6b1eb4b1/parser-ini.js (L14)

The `msg.hasOwnProperty("xxx")` construct should not be used since ECMAScript 5.1.

ESLint advises in the same direction https://eslint.org/docs/rules/no-prototype-builtins

This patch was produced using the following regex:
Search: `\b([\w.]+).hasOwnProperty\(`
Replace: `Object.prototype.hasOwnProperty.call($1, `

This could be applied more gobally if desired.
2022-02-03 02:01:22 +01:00
Dave Conway-Jones 514da83961
let inject optionally fire at start in only at time mode. 2022-01-28 18:05:20 +00:00
Nick O'Leary e0d4ecf835
Merge branch 'master' into dev 2022-01-24 23:18:25 +00:00
Hiroyasu Nishiyama f786c7f144 fix JSON propety validation of inject node 2022-01-13 21:42:50 +09:00
Nick O'Leary f86e743cce
Merge branch 'master' into dev 2022-01-12 17:59:26 +00:00
Dave Conway-Jones f77d161643
remove debug msg from inject close 2022-01-10 20:22:20 +00:00
Nick O'Leary 942b17b807
Fix incorrect clearing of blank payload property in Inject node
Fixes #3316
2022-01-03 21:51:49 +00:00
Dave Conway-Jones 2cad42870e
chaneg exec, file and inject node to use node.debug rather than -v flag 2021-12-17 09:58:10 +00:00
Nick O'Leary 04ffa06221
Add proper error handling for 404 errors when serving debug files 2021-11-26 11:30:51 +00:00
Nick O'Leary 679e07189d
Do not modify inject node props in oneditprepare
Fixes #3241
2021-11-01 20:10:52 +00:00
Nick O'Leary 2b220abdb7
Fix issue with old inject nodes that migrated topic to 'string' type 2021-10-22 09:01:24 +01:00
Nick O'Leary d0ec055222
Fix Inject/Change node restoring typedInput options 2021-10-18 21:23:42 +01:00
Nick O'Leary de882f5849
Fix saving link out node links 2021-10-18 09:32:00 +01:00
Nick O'Leary 21fd6e3c21
Ensure link call node label updates when link-in changes 2021-10-14 12:00:27 +01:00
Nick O'Leary f030694ef4
Merge pull request #3183 from node-red/debug-filter-opts
Redesign debug filter options and make them persistant
2021-10-13 14:47:08 +01:00
Nick O'Leary e9ed13459a
Merge pull request #3184 from node-red/inject-spinner-css
Widen Inject interval box for >1 digit
2021-10-13 14:41:52 +01:00
Nick O'Leary 44aa1f4a5e
Filter out Link Out Return nodes in Link In edit dialog
Fixes #3187
2021-10-13 14:23:43 +01:00
Nick O'Leary bfd4fc81fe
Widen Inject interval box for >1 digit 2021-10-12 17:25:30 +01:00
Nick O'Leary 3204b04455
Overhaul Debug sidebar filter and clear button options 2021-10-12 17:24:51 +01:00
Nick O'Leary dfd9364061
Add timeout option to link-call node 2021-09-29 14:28:12 +01:00
Nick O'Leary 1931395fdb
Add basic link-call/return tests 2021-09-29 13:49:55 +01:00
Nick O'Leary b01fd24e15
Add link-call node and add return mode for link-out node 2021-09-29 10:45:00 +01:00
Nick O'Leary f8571023f6
Fix inject now button unable to send empty props 2021-07-28 10:59:16 +01:00
Nick O'Leary c8bcd2818d
Disable inject-now button if inside subflow 2021-06-08 10:56:34 +01:00
Steve-Mcl e1c5764fbf move new inject button to existing edit form
- revert refactoring of building editableList (not needed now)
- remove node button modifier click & tray.show feature
- add inject button to editableList [buttons] array
- add `id` option to editableList to permit DOM access after creation
- get the new inject button via its `id` and float it to the right
- removed the popup tray buttons i18n entries
2021-05-22 10:52:44 +01:00
Steve-Mcl 70f975e4f0 move inject button off dialog and onto form 2021-05-21 13:26:50 +01:00
Steve-Mcl f570447000 i18n for buttons on user inject values 2021-05-20 22:53:10 +01:00
Steve-Mcl 9d7b8f1f2f change user prop name for injected values
- less chance for collision
2021-05-20 22:35:42 +01:00
Steve-Mcl bae6bfc32d Add inject values without deploy feature 2021-05-20 21:12:32 +01:00
Nick O'Leary 5dbaaae68e
Merge branch 'master' into dev 2021-05-12 16:00:36 +01:00
Nick O'Leary ed3aa8189f
Shrink default notification box
Also reduces Inject/Debug notification display time as 5 seconds is a
long time for a message telling you it worked
2021-05-11 14:45:53 +01:00
Nick O'Leary 71ba73b38f
Merge branch 'master' into dev 2021-05-04 11:19:05 +01:00
Nick O'Leary cd3aba2b89
Allow nodes to access resolved theme files
Fixes #2968
2021-04-29 10:17:07 +01:00
Nick O'Leary 6da8e92f20
Fix inject node output tooltip extra property count 2021-04-28 22:01:39 +01:00
Dave Conway-Jones 19d391fa05
only move msg. instead 2021-04-27 11:28:01 +01:00
Dave Conway-Jones d1aa1fd4d8
reorder inject typedinput to de-empahsise context options 2021-04-27 11:15:16 +01:00
Nick O'Leary ea50ba16f9
Move Inject node to CronosJS module 2021-04-26 14:47:50 +01:00
Nick O'Leary ca5e45a46d
Flag validation errors in Inject node props config
Fixes #2914
2021-04-06 16:45:21 +01:00
Nick O'Leary 0dc4440a99
Merge branch 'master' into dev 2021-02-25 17:56:01 +00:00
Hiroyasu Nishiyama 74ea382cf2 update subflow finding algorithm 2021-02-19 14:35:59 +09:00
Hiroyasu Nishiyama 5a6568e7c2 allow filtering of debug node output within subflow 2021-02-10 17:32:27 +09:00
Nick O'Leary dd780945e1
Sanitize Debug node name when display enable/disable message 2021-02-09 15:04:00 +00:00
Nick O'Leary ea2e3f25d8
Implement node property typing
See https://github.com/node-red/designs/pull/37
2021-01-08 14:19:12 +00:00
Nick O'Leary 6ea978d83d
Prevent needless retention of node status messages 2020-11-16 21:05:13 +00:00
Kunihiko Toumura 2e19bc07df new-style callback function (link in/out node) 2020-07-14 18:59:09 +09:00
Kunihiko Toumura 3f4de43b67 new-style callback function (status node) 2020-07-14 18:56:16 +09:00
Kunihiko Toumura 0d0bf62fc4 new-style callback function (catch node) 2020-07-14 18:53:21 +09:00
Kunihiko Toumura 3c8654fa25 new-style callback function (complete node) 2020-07-14 18:50:03 +09:00
Kunihiko Toumura 756a6ec5aa new-style callback function (inject node) 2020-07-14 18:46:38 +09:00
Nick O'Leary c9acfdb1d7
Set apiRootUrl for debug pop-out to load locales properly
Fixes #2629, #2630
2020-07-07 21:14:44 +01:00
Dave Conway-Jones b96d562700
fix debug status to not loop, make migration more seamless, detect status type objects 2020-07-04 15:26:02 +01:00
Dave Conway-Jones f01866d76f
Fix backwards migration of inject without topic 2020-06-28 15:09:07 +01:00
Nick O'Leary 299b81f51b
Fix Link node filter
Fixes #2600
2020-06-05 16:20:40 +01:00
Nick O'Leary ad6b18e66f
Make catch/status/complete/link filter case-insensitive 2020-06-05 16:00:02 +01:00
Dave Conway-Jones 16a634063a
Fix debug node status to migrate old nodes to correct default mode. 2020-06-05 09:48:12 +01:00
JeanCarl Bisson aa8f4af339 Filter list of nodes on node type 2020-06-03 10:33:35 -07:00
Nick O'Leary 139ae547c6
Add filter to link node 2020-06-03 15:54:51 +01:00
Nick O'Leary 2ce424b567
Add compact searchBox to status/catch/complete nodes 2020-06-01 21:09:58 +01:00
Nick O'Leary 876a7a4646
Add bulk-activate actions for debug node
Adds the actions:

 - core:activate-all-debug-nodes
 - core:activate-all-flow-debug-nodes

to match the deactivate* actions.

Also adds:

 - core:activate-selected-debug-nodes
 - core:deactivate-selected-debug-nodes

Adds a new httpAdmin route - /debug/(enable/disable) - that can be
use to bulk enable/disable nodes via HTTP Post.
2020-05-27 12:20:23 +01:00
Nick O'Leary 95d1b7bc36
Merge branch 'dev' into pr_2570 2020-05-27 11:52:37 +01:00
Nick O'Leary 38872049fd
Fix checkbox appearance on status/complete/catch/link nodes 2020-05-21 10:39:49 +01:00
cinhcet 64b3c11682 debug nodes in subflows are ignored and changed name of callback to callback 2020-05-19 18:00:03 +02:00
cinhcet a6a781f67c fix debug undo/redo by introducing a sideEffectCallback in history object 2020-05-19 13:51:08 +02:00
Dave Conway-Jones a600feb5de
Move debug status text length check to just before dsiplay. 2020-05-19 10:57:33 +01:00
cinhcet a69db4d572 move to debug.html, rename to "deactivate" instead of "disable" 2020-05-19 11:03:15 +02:00
Dave Conway-Jones 1d36ce0fdf
debug node: add auto handling of error and status msgs if set to show status 2020-05-15 23:32:27 +01:00
Dave Conway-Jones 88d4d306f3
Add some colour smarts to debug status 2020-05-15 16:06:34 +01:00
Dave Conway-Jones 184d928cf7
ensure debug status in sync with main option 2020-05-14 23:01:26 +01:00
Dave Conway-Jones a849872c21
ensure old config work with new fields 2020-05-14 16:28:38 +01:00
Dave Conway-Jones 1d71fb3554
Let debug node show status indpendent of main output 2020-05-14 15:38:48 +01:00
Nick O'Leary 717bfffa63
[Inject] Use legacy properies by preference 2020-05-11 16:07:26 +01:00
Dave Conway-Jones 247fa0ce7c
Fix inject so more backwards compatible
reuse old payload property and copy over topic if a string.
2020-05-11 14:37:19 +01:00
Hiroyasu Nishiyama 00e080459e update handling of invalid jsonata expression 2020-05-11 14:51:47 +09:00
Nick O'Leary 189389f96a
[inject] Tidy up node label 2020-05-05 17:35:30 +01:00
Nick O'Leary 3d76137247
[inject] Modify output labels for multi-value inject 2020-05-04 15:37:09 +01:00
Nick O'Leary 20e84a847a
Merge pull request #2435 from PaulWieland/dev
Adding user definable properties to inject node
2020-05-04 14:02:10 +01:00
Paul Wieland 25aadc690a Added i18n and legacy output label support 2020-04-27 12:16:20 -04:00
Paul Wieland 3e898c487a Corrected output label logic 2020-04-22 15:13:11 -04:00
Paul Wieland 2efc2bc186 Update 20-inject.html
Scroll the div down automatically when the user changes the repeat drop down.
2020-04-08 13:37:51 -04:00
Paul Wieland 7c1853431a Update 20-inject.html
Cleanup old payload, topic & type.
Move name and remove tip.
2020-04-08 12:29:55 -04:00
Nick O'Leary 05fc3c5eca
Merge branch 'master' into dev 2020-03-30 23:41:33 +01:00
Nick O'Leary a8db3d8dd3
Don't double-sanitize node name in debug sidebar
Fixes #2521
2020-03-29 20:38:05 +01:00
Paul Wieland 82490b0a58 Implemented RED.util.setMessageProperty 2020-01-23 11:23:02 -05:00
Paul Wieland 2cbf625483 Removing form-row label. 2020-01-23 10:56:31 -05:00