1
0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Commit Graph

8 Commits

Author SHA1 Message Date
Nick O'Leary
d97e23947d Add uid to mqtt client log messages
This is a semi-temporary change to help debug the multiple-connection issue seen with the MQTT client
2014-02-19 22:17:20 +00:00
Nick O'Leary
b4ef1d354d Catch mqtt socket write error after disconnect
Part of #155
2014-02-19 21:30:46 +00:00
Nick O'Leary
79aeeea640 Handle duplicate PUBREL
Fixes #138

If the connection to a broker is lost mid qos 2 flow, there is a window where we have processed the PUBREL, released the message and deleted it from our store, but not sent the PUBCOMP. When the connection is re-established, and the PUBREL is resent by the broker, we assume the message still exists - and hit the error reported.

The fix is to check the message is valid before trying to process it. We send the PUBCOMP to complete the flow regardless.
2014-01-13 11:32:16 +00:00
Nick O'Leary
6b3010f95b Guard against null client in MQTT nodes
Fixes #130

There was a timing window where a client could connect to a broker just as new flows were deployed that would cause the on-connect callback to be called after client has been set to null. This caused an NPE.

The fix is to check client isn't null in the event handler.
2014-01-13 11:27:09 +00:00
Nick O'Leary
1c010c568d Fix keepalive handling in MQTT client
Fixes #124
2013-12-29 20:16:27 +00:00
Nicholas O'Leary
4475e74187 Overlapping mqtt subs get duplicate messages 2013-12-06 14:19:21 +00:00
Nicholas O'Leary
7040aaa179 Add clientid/username/password to MQTT nodes
Alternative implementation, closes #42

The username/password as not stored in the main flow file for security reasons;
they are stored in the adjacent credentials file. This does mean an extra step
to importing an MQTT node, as the user has to manually edit it to re-add username
and password if needed.
2013-11-25 22:50:08 +00:00
Nicholas O'Leary
48dabffefc Move all nodes into core subdirectory
This makes it easier to distinguish core nodes from those added later
2013-11-14 15:52:19 +00:00