Commit Graph

203 Commits

Author SHA1 Message Date
Stephen McLaughlin 294fc6b62f
Ensure userProps makes it through to runtime 2022-04-29 11:25:19 +01:00
Stephen McLaughlin 662a44fccf
save and restore v5 config user props 2022-04-29 10:44:19 +01:00
Stephen McLaughlin 020eaef5ba
Fix incorrect MQTT status
fixes #3550
2022-04-26 16:12:54 +01:00
Nick O'Leary f4bb62adbc
Merge branch 'dev' into pr_3438 2022-04-26 13:53:35 +01:00
Nick O'Leary c88a177cb2
Merge pull request #3530 from Steve-Mcl/mqtt-payload-auto-parsing
MQTT payload auto parsing improvements
2022-04-25 11:40:59 +01:00
Steve-Mcl 552408f488 Make new Auto Output mode optional
- adds entry to output data type
- adds depreciation tip
2022-04-21 21:20:41 +01:00
Nick O'Leary 12a25c37aa
Merge branch 'master' into dev 2022-04-20 10:56:55 +01:00
Nick O'Leary 958f57085f
Merge branch 'dev' into tcp-node-better-split 2022-04-20 09:34:16 +01:00
Steve-Mcl 8df53e441d remove unused vars 2022-04-19 10:42:00 +01:00
Stephen McLaughlin 6f89efa40b
remove unused if block
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
2022-04-19 10:30:08 +01:00
Stephen McLaughlin 78f456911a auto mode to auto parse string to JS Object 2022-04-14 22:47:18 +01:00
Steve-Mcl 8f5d3dc49c Use v5 properties to aid auto parsing payload
- closes #3421
- fixes bug in `function setBoolProp()`
2022-04-14 22:47:18 +01:00
Steve-Mcl 97678577fb call done after ws disconnects
fixes #3527
2022-04-14 22:07:52 +01:00
Hiroyasu Nishiyama accbf6ecfc update validator arguments not to use optional object 2022-04-12 08:09:46 +09:00
Stephen McLaughlin a7932da207
Merge pull request #3488 from Steve-Mcl/httpreq-headers-ui
Add UI for Http Request node headers
2022-04-06 08:35:32 +01:00
Dave Conway-Jones 8a40622815
tcp node - undo trim if we re-add split chars
and fix tests
2022-03-23 22:07:43 +00:00
Nick O'Leary 0f37b326a0
Merge pull request #3502 from Steve-Mcl/fix-mqtt-will-props
fix typo of will properties (properies)
2022-03-21 19:29:23 +00:00
Steve-Mcl 7f9f551cfe fix typo of will properties (properies)
Fixes #3501
2022-03-21 15:24:23 +00:00
Steve-Mcl c5de18caae fix: node save broken
- Revert last minute code tidy that changed too many `this` to `node`
2022-03-12 16:10:36 +00:00
Steve-Mcl e57774e121 fix UI change events
- use `this` not `node` in UI change events
2022-03-12 15:02:25 +00:00
Steve-Mcl b7ee46d400 revise header options
- remove Accept-Charset
- Use camel case by default
- additional encodings
2022-03-12 15:00:48 +00:00
Steve-Mcl 6007132640 rearange UI (name to bottom) 2022-03-12 14:59:15 +00:00
Steve-Mcl 31b3a4c342 Add UI for common headers/values
- Wrap HTML node script in IFFE (isolate module level vars & functions)
- Add UI elements for setting headers in http req node edit form
- Update built in help
- Add tests
2022-03-12 13:47:29 +00:00
Steve-Mcl 10b18de3e0 fix: ensure mqtt v5 props can be set false
fixes #3471
2022-03-05 11:24:25 +00:00
Dave Conway-Jones 0398ef3b90
undo regression in tcp-in node (missed one)
and add test
2022-02-25 16:06:44 +00:00
Dave Conway-Jones 8c19daf949
TCP nodes- Add optional reattach delimiter to streaming strings 2022-02-25 15:56:13 +00:00
Dave Conway-Jones 25f4fbf2bb
undo regression to tcp-in node
To fix #3454
2022-02-21 20:03:25 +00:00
Steve-Mcl 669aa769c2 Fix close timeout on MQTT nodes
fixes #2934
2022-02-17 10:18:46 +00:00
Hiroyasu Nishiyama 9f98b4b082 add support of property validation message 2022-02-14 10:40:49 +09:00
Steve-Mcl 8948ca5323 Merge branch 'dev' into mqtt-reconnect-fix 2022-01-25 12:32:49 +00:00
Steve-Mcl 9c3be51fe9 Improve MQTT broker disconnect situation
* Ensure topic is sane to prevent error 129
* Ensure a log entry is made
* Update node status
2022-01-25 12:29:51 +00:00
Hiroyasu Nishiyama 5effcdb024 use setCookieSync instead of setCookie 2022-01-19 23:45:13 +09:00
Nick O'Leary 51f45293b8
Merge branch 'master' into dev 2022-01-13 10:52:36 +00:00
Nick O'Leary 036a825892
Only setup ws client heartbeat once it is connected
Fixes #3264
2022-01-12 21:46:56 +00:00
Nick O'Leary f86e743cce
Merge branch 'master' into dev 2022-01-12 17:59:26 +00:00
Nick O'Leary ee84eb666b
Merge pull request #3307 from node-red/add-tls-option-to-tcp-node
Add TLS option to tcp client nodes
2022-01-12 17:37:43 +00:00
Tobias Oort 555f155cad Added support for commaseparated subprotocols
Removed placeholder from html
2022-01-12 09:10:35 +01:00
Tobias Oort bd77d7eec3 Implemented support for Websocket Subprotocols in WS Client Node. 2022-01-08 22:18:05 +01:00
Ben Hardill 44616c6872
Fix basic auth with empty username or password
fix for #3324
2022-01-05 20:56:46 +00:00
Dave Conway-Jones c9f03f1ac5
better tests
(and a small fix as a result)
2021-12-27 09:51:50 +00:00
Dave Conway-Jones 02bd292b8c
fix and test 2021-12-26 16:12:47 +00:00
Dave Conway-Jones e5f1029d0c
fix variable names for test 2021-12-26 15:37:41 +00:00
Dave Conway-Jones cae247160f
Let tcprequest split incoming strings on delimiter (as per tcpin node)
and fixup i18n messages
2021-12-26 15:28:16 +00:00
Dave Conway-Jones 6692b1992c
TCP add tls option to inbound nodes 2021-12-26 12:12:31 +00:00
Dave Conway-Jones 0937837b7f
Add TLS config option to TCP client nodes
(not yet when in server mode)
2021-12-24 16:18:00 +00:00
Ben Hardill b77a2dc353
Better fix 2021-10-28 10:08:28 +01:00
Ben Hardill 87af31de20
HTTP Basic Auth should always add : to username
fix for #3235
2021-10-28 09:18:17 +01:00
Steve-Mcl 153f87704b fix datatype in node config not used. fixes #3215 2021-10-24 22:21:44 +01:00
Dave Conway-Jones a7413cccd0
reuse existing labels for tcp request buffer/string option 2021-10-20 09:36:08 +01:00
Dave Conway-Jones d3f978c90c
Add optional string type output to tcp request node
to be similar to tcp in. node
2021-10-19 21:34:23 +01:00
Nick O'Leary b8f1386ad0
Dynamic MQTT connections (#3189)
* add mqtt-control
- adds auto-connect option to broker
- add new node mqtt-control
- adds i18n messages
- adds documentation

* documentation tweaks

* built in documentation improvements

* fix tip layout causing oversized editor

* remove unused requires

* add missing `unsubscribe` dropdown option
- oddly forgotten - now added

* ensure clientid is updated dynamically

* [rewrite] move mqtt-control login into mqtt-in

* Remove dynamic label

* remove redundant mqtt-control code left overs

* Callback for brokerConn.connect (improve done())
- done is now called on connect callback

* fix race condition if connect/disconnect too fast
- node.connected and node.client.connected getting out of sync

* fix connection fail when switching protocol 3 ~ 5
- ensure protocolId is correct for protocolVersion

* change msg.subscribe prop to `msg.topic`

* unsub all topics if msg.topic is `true`

* delete temprary debugger statements

* Final rework of dynamic mqtt connections

Co-authored-by: Steve-Mcl <sdmclaughlin@gmail.com>
2021-10-14 12:05:06 +01:00
Nick O'Leary 8042fe4e2b
Merge branch 'master' into dev 2021-10-06 09:12:16 +01:00
Nick O'Leary 3759e0f778
Add option to only send http response errors to Catch node 2021-10-04 14:04:59 +01:00
Nick O'Leary 0171ffac6a
Fix sizing of HTTP Response header fields 2021-10-04 10:52:36 +01:00
Dave Conway-Jones 4f23847546
Fix UDP node to not not use port if unassigned 2021-09-16 16:22:01 +01:00
Kunihiko Toumura 490547cd3d Use httpRequestTimingLog for enable detailed timing log 2021-09-05 15:22:13 +09:00
Dave Conway-Jones 17f9829498
Fix for incorrect tcpout connection count
to Close #3098
seems to need dummy data receiver in order to recognise other callbacks.
2021-09-03 13:00:06 +01:00
Kunihiko Toumura 401466d6c0 Add timing log 2021-08-23 11:54:05 +09:00
Nick O'Leary 6364e00202
Merge pull request #3092 from hardillb/http-req-ca-fix
Copy tls.cert to tls.certificate for GOT
2021-07-28 10:05:19 +01:00
Ben Hardill a76c6f86c6
Add Testcase & Fix typo 2021-07-28 08:52:35 +01:00
Ben Hardill 555e815402
Copy tls.cert to tls.certificate for GOT 2021-07-27 22:19:35 +01:00
Nick O'Leary f1775d4fd1
Handle partially encoded url query strings in request node 2021-07-26 14:21:52 +01:00
Ben Hardill 26087f8dc7
Fix support for supplied CA certs 2021-07-26 10:25:06 +01:00
Nick O'Leary 6e69cfbca4
Preserve case of user-provided http headers in request node
Fixes #3081
2021-07-23 09:55:32 +01:00
Nick O'Leary 775181f761
Set decompress to false for HTTP Request to keep 1.x compatibility
Fixes #3083
2021-07-23 08:57:44 +01:00
Nick O'Leary 5f6fcb2bc0
Do not throw HTTP errors in request node
Fixes #3082

GOT will throw errors for non-successful http responses by default. We need to turn that
off to be consistent with the 1.x behaviour using the request module
2021-07-22 23:48:30 +01:00
Nick O'Leary 7b106e5650
Ensure uri is properly encoded before passing to got module
Fixes #3080
2021-07-22 23:47:32 +01:00
Nick O'Leary 79d9c83a2d
Better detection of broken agent-base function patching 2021-07-22 11:19:25 +01:00
Nick O'Leary f7606e92ca
Detect if agent-base has patch https.request and undo it
Fixes #3072
2021-07-21 16:22:28 +01:00
Nick O'Leary 6750be3ec9
HTTP Request node - ignore invalid cookies rather than fail request
Fixes #3075

Keeps behaviour consistent with the request module
2021-07-21 14:09:15 +01:00
Ben Hardill 32dd186f4d
Prevent Overwite of configured creds 2021-07-16 08:47:30 +01:00
Ben Hardill 81f0fb3c74
Fix creds in URL 2021-07-15 18:32:51 +01:00
Ben Hardill 972c83cd52
Fix for #3067
Check if there are any content to the credential object
2021-07-15 17:35:03 +01:00
Nick O'Leary d8ee766860
Allow websocket client node to send pings 2021-07-08 10:51:36 +01:00
Nick O'Leary 19589d9117
Merge branch 'master' into dev 2021-07-02 10:00:43 +01:00
Nick O'Leary b848fe249f
Remove stray console.log from mqtt.html 2021-07-01 21:01:11 +01:00
Kazuhito Yokoi 13f1c12912 Add translations to message catalog 2021-06-14 15:54:05 +09:00
Ben Hardill 919aee64f9
Add support for user/pass in URL 2021-06-11 14:48:41 +01:00
Ben Hardill bcb6d1cf93
Fix for basic auth with @ in username 2021-06-11 14:25:18 +01:00
Nick O'Leary 133df75bd4
Merge branch 'dev' into get-got 2021-06-09 09:59:23 +01:00
Ben Hardill d5c5738aab
Fix proxy authentication problem & reinstate tests
Down to only 2 of the previous tests not working
2021-06-08 14:22:20 +01:00
Nick O'Leary 7bf938901a
Merge branch 'pr_2952' into dev 2021-06-08 11:09:56 +01:00
Nick O'Leary 01b5fc4d49
Merge pull request #2987 from node-red/clean-ids
Change node id generation to give fixed length values without '.'
2021-05-27 12:18:38 +01:00
Ben Hardill 0b52cd8b31
Fixes from testing
I set up a NGINX instance to test this and found I'd missed some bits.

Still can't find a way to test this easily from a nodejs unit test
2021-05-19 10:41:24 +01:00
Ben Hardill 8c95067ec4
Add ALPN support to TLS node 2021-05-18 13:13:32 +01:00
Nick O'Leary 8bbed2c831
Change node id generation to give fixed length values without '.' 2021-05-18 11:32:17 +01:00
Ben Hardill 8c1a749a5a
Fix msg.responseUrl
The original version would pick up the proxy servers port number
2021-05-12 11:08:57 +01:00
Ben Hardill 4c8e895ac7
Clean up console.logs 2021-05-11 09:56:22 +01:00
Ben Hardill f6a3671366
Get the http-request node got port working with Proxy 2021-05-10 23:01:29 +01:00
Nick O'Leary e23f20227a
Initial migration from request to got for http-request node 2021-04-23 14:19:15 +01:00
Ben Hardill 235690064f
Fix for #2935 2021-04-16 13:26:11 +01:00
Nick O'Leary 04a3c4bb22
Ensure mqtt-close message is published when closing mqtt nodes
The change in 1.3 where we ensure config nodes are closed last broke this behaviour. Previously, the config node would get closed triggering the close message. With the new 1.3 behaviour, the flow nodes are stopped and as soon as the last flow node deregisters itself, the broker node would disconnect without sending the close message.

The fix is to send the close message as part of the deregister flow as that will handle all cases properly
2021-04-14 22:28:25 +01:00
Nick O'Leary 5028377d45
Fix MQTT Broker TLS config row layout
Fixes #2927
2021-04-12 11:48:10 +01:00
Nick O'Leary 16e021e94f
Request node: set followAllRedirects to work with POSTs
Fixes #2017
2021-04-07 14:35:29 +01:00
Hiroyasu Nishiyama 7e40cb5331 update i18n and Japanese message for nodes 2021-03-03 10:07:33 +09:00
Steve-Mcl 080e2f2589 mqtt v5 fixes
- copy/paste issues with willMsg
- ensure helper func is ran for lwt messages
2021-02-25 19:58:59 +00:00
Nick O'Leary 255b8f2005
Update mqtt nodes for v5 2021-02-25 15:49:56 +00:00
Steve-Mcl 833ecfb1af MQTT V5 - prep for 1.3.0 beta...
* MQTT IN node tidy up
  * remove userProperties
  * remove subscriptionIdentifier
* MQTT OUT node tidy up
  * remove topicAlias
  * remove payloadFormatIndicator
  * remove subscriptionIdentifier
* MQTT BROKER node tidy up
  * remove topicAliasMaximum
  * remove maximumPacketSize
  * remove receiveMaximum
  * remove userProperties
2021-02-20 19:58:13 +00:00
Steve-Mcl c20bab2436 more specific class selectors for show/hide items 2021-02-20 15:52:14 +00:00
Steve-Mcl ab4a9e72d4 Merge branch 'dev' into mqtt5 2021-02-18 18:50:26 +00:00